From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Wed, 02 Aug 2023 20:00:19 +0200 Message-ID: <87sf91jpe4.fsf@ledu-giraud.fr> References: <874jruy7xx.fsf@ledu-giraud.fr> <87y1oz54bn.fsf@ledu-giraud.fr> <87wn4dra0h.fsf@ledu-giraud.fr> <87bklhtwhd.fsf@ledu-giraud.fr> <871qgumqh7.fsf@ledu-giraud.fr> <83ila5n8co.fsf@gnu.org> <87fs59qx54.fsf@ledu-giraud.fr> <83wmyll9s5.fsf@gnu.org> <87bkfxcaa2.fsf@ledu-giraud.fr> <83wmykjzji.fsf@gnu.org> <877cqkcrds.fsf@ledu-giraud.fr> <83bkfwjkh8.fsf@gnu.org> <871qgsc9fv.fsf@ledu-giraud.fr> <83y1izj2q6.fsf@gnu.org> <87leezhwq0.fsf@ledu-giraud.fr> <87edko9ixu.fsf@ledu-giraud.fr> <87h6piu1zj.fsf@ledu-giraud.fr> <83wmydzn4z.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40751"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: contovob@tcd.ie, stefankangas@gmail.com, 61394@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 02 20:01:44 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRGAK-000AHl-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Aug 2023 20:01:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRGA0-0008Hv-VN; Wed, 02 Aug 2023 14:01:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRG9f-0008Gn-OA for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 14:01:18 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRG9e-0003wE-6j for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 14:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRG9e-00078T-2g for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 14:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Aug 2023 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.169099922927369 (code B ref 61394); Wed, 02 Aug 2023 18:01:02 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 2 Aug 2023 18:00:29 +0000 Original-Received: from localhost ([127.0.0.1]:50122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRG97-00077M-Gk for submit@debbugs.gnu.org; Wed, 02 Aug 2023 14:00:29 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:12362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRG91-000777-75 for 61394@debbugs.gnu.org; Wed, 02 Aug 2023 14:00:27 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=V5StUMRW wSfRmNPKgyGznme67TC8LRUYZJtSbsO4fco=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=se38i9YaiKPIPWuPXefnIoNJXzZMto 2xqwHoTjhd8Zl3qgnQBNDsIPyJWUXQpGSXtWvFPH7zHEwLd5cBcYv/DQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=V5StUMRWwSfRmNPK gyGznme67TC8LRUYZJtSbsO4fco=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=CYJOdAZXDj9dvq1igTt+Ir/IrDorS00M9wdSnh AS+pUAfmTXQYw6mY3z1xQgRsADUDzqLBV45MEgiuk6nRxB9hB49FCZbpjXu6QdKaHa8x4G 2q/MO6v520Nrz96/fOv8YAF93iEmQcUWCEaXdBtuDhb7WM37jjq/bBRcq1Wr3HeN4+PSKk v1Cs0GtsSxNKdAjF90gPkWsm92ivvKp5yb5YLANwusABdA6Yp40SVlGFX4j6qlp/hbV+Df aeZCdm0awn4zuegS6RtZ+cqOdioePLGYiHmRQyrGMY4ao7ozTq7YvPRjjnsA6yA8h5jjrb AuW6wQI09k/CL0oxNVEaPgqQ== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id ddfb2f5b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 2 Aug 2023 20:00:21 +0200 (CEST) In-Reply-To: <83wmydzn4z.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Aug 2023 14:42:20 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266533 Archived-At: Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: stefankangas@gmail.com, contovob@tcd.ie, 61394@debbugs.gnu.org >> Date: Tue, 01 Aug 2023 19:05:52 +0200 >>=20 >> Manuel Giraud writes: >>=20 >> > Hi, >> > >> > FTR, there is a thing that does not work with this "thumb name based on >> > content": upon rotation the thumb is not updated properly. >> > >> > This comes from the fact that the image content has changed (obviously) >> > so the new thumb will have a new name and is not displayed in the >> > *image-dired* buffer =F0=9F=98=85. I'd have to find a way around it. >>=20 >> Hi, >>=20 >> So here is a patch that fixes this issue. Thanks. > > Thanks. Maybe I'm missing something, but isn't the problem limited to > just one method of naming the thumbnail files? If so, shouldn't these > changes be limited to that method alone? Yes. First I had a test about the method around the call to 'image-dired-update-thumbnail-at-point' but then I realize that nothing will be done for others methods as I'm doing a test on the thumb name change: ... (unless (string=3D thumb old-thumb) ... --=20 Manuel Giraud