From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65007: [PATCH] Allow displaying program IO in the GDB buffer. Date: Wed, 02 Aug 2023 21:38:12 +0800 Message-ID: <87sf91bm4b.fsf@yahoo.com> References: Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9469"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65007@debbugs.gnu.org To: StrawberryTea Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 02 15:39:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRC4E-0002EY-UA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Aug 2023 15:39:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRC47-0001el-9k; Wed, 02 Aug 2023 09:39:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRC46-0001eI-NE for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 09:39:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRC46-00036a-Es for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRC45-0005zu-W1 for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Aug 2023 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65007-submit@debbugs.gnu.org id=B65007.169098351423014 (code B ref 65007); Wed, 02 Aug 2023 13:39:01 +0000 Original-Received: (at 65007) by debbugs.gnu.org; 2 Aug 2023 13:38:34 +0000 Original-Received: from localhost ([127.0.0.1]:49270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRC3e-0005z7-6c for submit@debbugs.gnu.org; Wed, 02 Aug 2023 09:38:34 -0400 Original-Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:45503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRC3b-0005yp-SW for 65007@debbugs.gnu.org; Wed, 02 Aug 2023 09:38:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1690983504; bh=R/kbgWA5w1Z/Lvbkzj8WQwO/59pK6Ycs2kzRmiFtR/4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=pvPWN5kliJ/piQo4ti+Jrh3JBS5VxTuGcQNFuHLjAS0zuNvbMMJA863AgDKzQqCnSY8pA7EWCsQRsvuze9QL13BK7smciY2fxh7SabwHF9WsS8kyKykwThaWEdqfeC+yEKhlKM5Xc1W4xYLqHn4qFlPJvqF610Zg+9QnyYD/tNY+vj7jYj1rxiF3W4QDgYH1p/obwpKDnWQeYXrnNWms946ssKU54qGzQZjH2RT4Grk19v9PThYjjHTLM6IBycRQ8rG+UBCyBwn/rJ4IIcWLgyfO80UDxdvZ2Wi+7rCK/XFqKQOYh2jgZOFRS7fwlrVRMmh6PY4TUc57wgTM/sv8ZQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1690983504; bh=VJZ154IcAs1OKeyIVQflUMV4UoQ8oUSDNizum2Q25vS=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ZxoelEB5AsnhvBUyyP4EDOsAFFIp0Kwq0nvuagN77QyCczpODePDAkkiH1+fdHI9pOxdU8HEwfEt8DLb637t56rEvCdcuVKqOUSL40JVWlytRvnze4k2lFZSYJ33VHXVCLOhkf9oWvEElKRSO4tBCgOTCMAgxwsFX8WIkVC0wTdfIFuSBmmSaix6ZUr5UKFKZMQkST+F7dlcYfbWc7GGHgWJ9ucxmK1cXYrRXNKn5FxZWcq2iHZ4D4MgusvheHetYP+ui42g7j/8F6cnZWYdm33g82QKxHedp7NLKIIB6gYAVpeLVtnM1NK4bzJDWzV6T2eLvkYneCRSNvH7buorNg== X-YMail-OSG: FnZF45YVM1lG7OYdqlw_f6YlFyKsg.FMfb4zF93JJ8so7aBP0cZ9uY0WLaV8yKQ IN2Dbi6utjNMt9P86t0xkF.o78cfKCceWitUBqWTCo4f264Yy0f5CJFWGZ0lZHBH8iOny4MLAMno HyXSfw09_ZBwYLh6aqZuB869Om7Shv2.wuAaw_e3xVsMNVa.XGOC5eRXWTUUeTF3pOSCEWaHXHpw ELGQ3MVty38cihYkkzAiYHzfkANFQLscxvryysr0eatDQ_88A8ugvgfkcDw1V1ZUiwcycA3V0iUl PLchI9kPHp8REmNFRsgSaLXjR_EIg9rfItmPIGwdAgdTqSk3qIqS4yDkrtejnYHleSE_YsCiLHXz n3n6i.u9hQ488lxp1NHsYPHkpgJZFFtjKvd8jvdNFN.hOqrIbJrGvDFZGoAAJmUnSH7zF_AoImdD 1eYULs2exkFHH7t2dSAs0ZSNXijLjN9ipPNcRJkkI6YlNf4R.y_fU2UGTrztUBNMn6G3.OV0azUQ 4OjnuPmx1nGvqnWbkSZRw0OYPPV4d2oAwKCRTfJ8.3duugiwaIKs.L9Pjr0uuMkNJjeIQsIvhycX QE58LDDjW2qfgdU_uEbfSWGC36zd4L.C5..5YZcOZssQN5AI6yH_0Nxu4XSPtN.cbNUAaBhk5sAE aHESuC70ICBlrVgK4XkQV7Vz4aHU4rht5zLWVb_Va_1h_Z3EsaTjKJSFB0pJq.Mb5vi4BQIMJa6l Yuv59GnbCC1pgdoXuJRiL37UPlU1z_Go67i_G3P85i32_vnL2eBrxj0yUUjdorXNuJtsZSjOVy8x TpLDeT.a.03kOKEd14wfJvtY1ArYfD0sVVArRDjb0z X-Sonic-MF: X-Sonic-ID: 59a16b57-f299-4c39-9362-62f3080ec344 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Wed, 2 Aug 2023 13:38:24 +0000 Original-Received: by hermes--production-sg3-6b8fc8d58f-wjdpm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 97028aad5083012546c6eb42967ff4c7; Wed, 02 Aug 2023 13:38:18 +0000 (UTC) In-Reply-To: (StrawberryTea's message of "Thu, 27 Jul 2023 20:33:39 -0400") X-Mailer: WebService/1.1.21685 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266514 Archived-At: StrawberryTea writes: > * gdb-mi.el: Add new customizable variable `gdb-split-io-flag'. > > This change allows the user to control whether program IO is displayed > in the GDB buffer or in a separate buffer. The default is to display it > in the the `gdb-inferior-io' buffer. > --- > lisp/progmodes/gdb-mi.el | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el > index a1091de43e9..8f4f06abb9a 100644 > --- a/lisp/progmodes/gdb-mi.el > +++ b/lisp/progmodes/gdb-mi.el > @@ -1098,9 +1098,10 @@ detailed description of this mode. > (if gdb-debuginfod-enable "on" "off")) > 'gdb-debuginfod-message) > > - (gdb-get-buffer-create 'gdb-inferior-io) > - (gdb-clear-inferior-io) > - (gdb-inferior-io--init-proc (get-process "gdb-inferior")) > + (when gdb-split-io-flag > + (gdb-get-buffer-create 'gdb-inferior-io) > + (gdb-clear-inferior-io) > + (gdb-inferior-io--init-proc (get-process "gdb-inferior"))) > > (when (eq system-type 'windows-nt) > ;; Don't create a separate console window for the debuggee. > @@ -1828,6 +1829,15 @@ this trigger is subscribed to `gdb-buf-publisher' and called with > :group 'gdb > :version "25.1") > > +(defcustom gdb-split-io-flag t > + "Non-nil means to split the program's I/O from the GDB buffer. > + > +If t, create the `gdb-inferior-io' buffer and redirect the > +program's I/O to it." > + :type 'boolean > + :group 'gdb > + :version "30.1") > + > (defun gdb-inferior-filter (proc string) > (unless (string-equal string "") > (let (buf) Please append a ChangeLog entry to your commit messages, formatted in adherence with GNU standards. In particular, it should contain one entry for each function changed or variable introduced: Add new customizable variable `gdb-split-io-flag'. * lisp/progmodes/gdb-mi.el (gdb-split-io-flag): Don't create IO buffer if `gdb-split-io-flag'. (gdb-split-io-flag): New user option. Moreover, wouldn't `gdb-use-io-buffer' make a better name for this option? We don't typically name variables or user options ``flags'' in Emacs.