unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Gemini Lasswell <gazally@runbox.com>, 64536@debbugs.gnu.org
Subject: bug#64536: 30.0.50; Make cl-print put buttons on ellipses
Date: Sat, 12 Aug 2023 08:39:57 +0000	[thread overview]
Message-ID: <87sf8o3b8i.fsf@localhost> (raw)
In-Reply-To: <jwvbkfcu9r2.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hmm... we could re-add it, but with the new `cl-print.el` your code
> should simply not use `backtrace-ellipsis` at all because `cl-print.el`
> did it for you already.
>
> IOW, I think a patch like the one below my sig is the better option.

Sure. Thanks for the patch! I will let inspector.el author know about
it.

However, other users of `backtrace-ellipsis' button may be affected if
they used it for different purposes.

May it be possible to create an obsolete alias for this button type?

>> At least, I'd expect to see the removal documented in NEWS.
>
> How 'bout:
>
>      The code that allowed "..." to be expanded in the "*Backtrace*" buffer
>      should now work anywhere the data is generated by 'cl-print'.
>      
>     +*** The 'backtrace-ellipsis' button is replaced by 'cl-print-ellipsis'.

Looks reasonable.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>





  reply	other threads:[~2023-08-12  8:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-09  4:42 bug#64536: 30.0.50; Make cl-print put buttons on ellipses Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-13 23:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-11  7:53 ` Ihor Radchenko
2023-08-12  5:23   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12  8:39     ` Ihor Radchenko [this message]
2023-08-12 18:17       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-13  9:26         ` Ihor Radchenko
2023-08-13 16:02           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-14 11:01             ` Ihor Radchenko
2023-08-14 14:07               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-14 15:15                 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf8o3b8i.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=64536@debbugs.gnu.org \
    --cc=gazally@runbox.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).