From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ivan Sokolov Newsgroups: gmane.emacs.bugs Subject: bug#64531: [PATCH v2] Add new command vc-dir-copy-filename-as-kill Date: Sun, 20 Aug 2023 02:12:32 +0300 Message-ID: <87sf8eeie7.fsf@ya.ru> References: <87bkgmq1ra.fsf@ya.ru> <83jzvadabq.fsf@gnu.org> <87bkfhy7fr.fsf_-_@ya.ru> <83a5un1mn3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32368"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64531@debbugs.gnu.org, Dmitry Gutov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 01:14:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXV9D-0008Ds-GT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 01:14:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXV8s-0000Ta-Rz; Sat, 19 Aug 2023 19:14:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXV8r-0000TJ-BD for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 19:14:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXV8r-0004XF-22 for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 19:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXV8r-0005r8-P3 for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 19:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Sokolov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 23:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64531 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64531-submit@debbugs.gnu.org id=B64531.169248678322437 (code B ref 64531); Sat, 19 Aug 2023 23:14:01 +0000 Original-Received: (at 64531) by debbugs.gnu.org; 19 Aug 2023 23:13:03 +0000 Original-Received: from localhost ([127.0.0.1]:52440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXV7u-0005pp-Pi for submit@debbugs.gnu.org; Sat, 19 Aug 2023 19:13:03 -0400 Original-Received: from forward100b.mail.yandex.net ([178.154.239.147]:42086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXV7r-0005pM-6a for 64531@debbugs.gnu.org; Sat, 19 Aug 2023 19:13:01 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-45.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-45.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:c83:0:640:84f9:0]) by forward100b.mail.yandex.net (Yandex) with ESMTP id AC6DE60031; Sun, 20 Aug 2023 02:12:55 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-45.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id sCtbGSPWnmI0-85Bl4iUl; Sun, 20 Aug 2023 02:12:55 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ya.ru; s=mail; t=1692486775; bh=8qn5yJDgVO4GIr2/x4v6Inuw6iKehAvGMUCQfGjHBb4=; h=Message-ID:Date:Cc:In-Reply-To:Subject:References:To:From; b=Lf5kmbKt73Rj+AT4L/nvR10HHjMQBF9ogn7MV+PpBpVvQq8ZOUEa4+PdvVdeQVkXm 9fHqYkn1VzhyFf3pRHQd97oBJHJH6r/uC+bnwXR9Nf62+2Z+0K7gEGdlg6yGSeZ8mZ +YNgdWYHgkouyRcaGKh+PVNqGeYxoQu7c5DIw3o4= Authentication-Results: mail-nwsmtp-smtp-production-main-45.sas.yp-c.yandex.net; dkim=pass header.i=@ya.ru In-Reply-To: <83a5un1mn3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Aug 2023 11:06:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267925 Archived-At: Eli Zaretskii writes: >> From: Ivan Sokolov >> Cc: 64531@debbugs.gnu.org >> Date: Tue, 08 Aug 2023 16:44:56 +0300 >> >> Eli Zaretskii writes: >> >> > However, new commands should be called out in NEWS, and commands that >> > are important enough should also be mentioned in the user manual. >> >> Added entry in NEWS, but not in the user manual, there is no such for >> vc-dir afaik. >> >> >> +(defun vc-dir-copy-filename-as-kill (&optional absolutep) >> >> + "Copy names of marked files (or file under cursor) into the kill ring. >> > >> > This sentence is too general: it doesn't mention VC Dir, although >> > AFAIU it is specific to vc-dir. >> >> Fixed. > > Dmitry, is this good to go in? > > I still think it should be mention in the Emacs user manual, where we > document vc-dir. Hi, Eli! I am working on the 3rd version of the patch with all the necessary documentation and changes to the command which I will explain in the cover letter. Not sure when I'll finish it though.