From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Fri, 15 Dec 2023 10:19:29 +0000 Message-ID: <87sf43ix8u.fsf@localhost> References: <878r919qfh.fsf@localhost> <87plzbxtxa.fsf@localhost> <87y1dzvvf0.fsf@localhost> <83plzas3pg.fsf@gnu.org> <87r0jqw8u9.fsf@localhost> <83jzpis08a.fsf@gnu.org> <87il52w744.fsf@localhost> <83fs06rz10.fsf@gnu.org> <87fs06w4ui.fsf@localhost> <83bkaurut9.fsf@gnu.org> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> <87r0jooatf.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, Eli Zaretskii , mattias.engdegard@gmail.com, 66117@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 15 11:17:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE5Fw-00068h-IP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Dec 2023 11:17:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rE5Fg-0000d2-Vd; Fri, 15 Dec 2023 05:17:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rE5Ff-0000cX-JZ for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 05:17:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rE5Ff-0004CE-1F for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 05:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rE5Fe-0001Vs-HZ for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 05:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Dec 2023 10:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.17026354095793 (code B ref 66117); Fri, 15 Dec 2023 10:17:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 15 Dec 2023 10:16:49 +0000 Original-Received: from localhost ([127.0.0.1]:51658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE5FC-0001V9-2s for submit@debbugs.gnu.org; Fri, 15 Dec 2023 05:16:49 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:39843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE5F9-0001Uv-Kd for 66117@debbugs.gnu.org; Fri, 15 Dec 2023 05:16:32 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 302FC240105 for <66117@debbugs.gnu.org>; Fri, 15 Dec 2023 11:16:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702635386; bh=DGgVQQXJ7jKWkIrtI+dHPMyiuPV65pMGhdvYHdMbuSE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=W3s6TbDHuPWDHlFvJlFXiDiMxSdxrNVNgGEl73tGpi+dTfgUBvGe60/XvfWtlYn1C IJvjtNsRumjQ2zKtHp4CuoZxZelQeSozD86WxYqlKJr+52eyiwGPzoi4lEDfwdLR4+ dx7ggt4ICBH9BJd/ndWYHATopHsKnCMjPTN2vokoL5pjLMeQZqNZTQUn4VKxYoXzhs fsE5rn54KBw3hcISYyl2D6ABHdDVxfrPlYX7xHIH10E/3gcskWVkHNCWZM5G1/bV/f QI7AP848cDolcGyGYlal8Vt8ZE1ExvBWdYbIDr4XxfyW8Kt2TeErsq032hJs6nq8iZ V7bqvvfd9GcFg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ss4r909fdz6tyH; Fri, 15 Dec 2023 11:16:24 +0100 (CET) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276260 Archived-At: Stefan Monnier writes: >> In my mind, another benefit is that the new variable will not be >> affected by buffer-local values - (let (case-fold-search-override value) ...) >> will be guaranteed to use VALUE everywhere, even if current buffer is >> changed. This will make the case I described in >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66117#208 more predictable >> (and, since it is a new variable, will not break any existing code). > > But of course, as always it cuts both ways. E.g. if you do > > (let ((case-fold-search-override t)) > (dolist (buf (buffer-list)) > (when (string-match "foo" buffer-file-name) > (do-something)))) > > your `case-fold-search-override` will override all the careful > `case-fold-search` let-bindings used during the execution of `do-something` > which will likely lead to new bugs. Good point. I was hoping that together with this new variable we also add a compiler warning encouraging to use the case-fold-search-override _instead_ of case-fold-search everywhere. But I can indeed see how people can get even more confused in such scenario. Within the scope of this particular bug report, I am now leaning more towards your idea with DEFVAR_LISP then. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at