From: Emanuel Berg <incal@dataswamp.org>
To: 68401@debbugs.gnu.org
Cc: emacs-erc@gnu.org
Subject: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt
Date: Tue, 23 Jan 2024 07:20:34 +0100 [thread overview]
Message-ID: <87sf2oin9p.fsf@dataswamp.org> (raw)
In-Reply-To: <87v87yvnly.fsf@dataswamp.org>
>>>> (defun erc-drop-leading-whitespace (str)
>>>> (if (string-match "^ \\(.*\\)$" str)
>>>> (match-string 1 str)
>>>> str) )
>>>
>>> Why not use `string-prefix-p' and `substring' to
>>> accomplish this? Also, please name this using the internal
>>> "--" convention, something like
>>> `erc--drop-initial-space-char' or
>>> `erc--drop-single-leading-space'.
>>
>> Good idea to use `string-prefix-p' and `substring', but it
>> hasn't anything to do with ERC at this point - it should be
>> put in some string manipulation library and then ERC should
>> `require' it. [...]
Someone told me (thanks) there is already
a `string-remove-prefix' to do this so that whole thing can
be dropped.
;;; -*- lexical-binding: t -*-
;;
;; this file:
;; https://dataswamp.org/~incal/emacs-init/erc/erc-misc.el
;;
;; Make erc-cmd-AMSG session-local, add /GMSG /AME /GME
;;
;; * lisp/erc/erc.el (erc-cmd-AMSG): Make good on behavior described in
;; the doc string by limiting damage to the current connection.
;; (erc-cmd-GMSG, erc-cmd-GME, erc-cmd-AME): New functions, all IRC
;; "slash commands". (Bug#68401)
(require 'erc)
(defun erc--connected-and-joined-p ()
(and (erc--current-buffer-joined-p)
erc-server-connected))
(defun erc-cmd-GMSG (line)
"Send LINE to all channels on all networks you are on."
(setq line (string-remove-prefix " " line))
(erc-with-all-buffers-of-server nil
(lambda () (erc-channel-p (erc-default-target)))
(when (erc--connected-and-joined-p)
(erc-send-message line))))
(put 'erc-cmd-GMSG 'do-not-parse-args t)
(defun erc-cmd-AMSG (line)
"Send LINE to all channels of the current network.
Interactively, prompt for the line of text to send."
(interactive "sSend to all channels on this network: ")
(setq line (string-remove-prefix " " line))
(erc-with-all-buffers-of-server erc-server-process
(lambda () (erc-channel-p (erc-default-target)))
(when (erc--connected-and-joined-p)
(erc-send-message line))))
(put 'erc-cmd-AMSG 'do-not-parse-args t)
(defun erc-cmd-GME (line)
"Send LINE as an action to all channels on all networks you are on."
(erc-with-all-buffers-of-server nil
(lambda () (erc-channel-p (erc-default-target)))
(when (erc--connected-and-joined-p)
(erc-cmd-ME line))))
(put 'erc-cmd-GME 'do-not-parse-args t)
(defun erc-cmd-AME (line)
"Send LINE as an action to all channels on the current network."
(erc-with-all-buffers-of-server erc-server-process
(lambda () (erc-channel-p (erc-default-target)))
(when (erc--connected-and-joined-p)
(erc-cmd-ME line))))
(put 'erc-cmd-AME 'do-not-parse-args t)
(provide 'erc-misc)
--
underground experts united
https://dataswamp.org/~incal
next prev parent reply other threads:[~2024-01-23 6:20 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87v87yvnly.fsf@dataswamp.org>
2024-01-12 12:08 ` bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt Eli Zaretskii
2024-01-12 14:12 ` Emanuel Berg
2024-01-12 14:39 ` Eli Zaretskii
2024-01-13 2:09 ` Emanuel Berg
2024-01-13 2:31 ` Emanuel Berg
2024-01-13 2:45 ` Emanuel Berg
2024-01-13 7:23 ` Eli Zaretskii
2024-01-14 9:11 ` Emanuel Berg
[not found] ` <834jfikb4d.fsf@gnu.org>
2024-01-12 12:36 ` Emanuel Berg
[not found] ` <87ply6vidl.fsf@dataswamp.org>
2024-01-12 14:03 ` Eli Zaretskii
2024-01-12 14:30 ` Emanuel Berg
[not found] ` <87mstavias.fsf@dataswamp.org>
[not found] ` <87wmseoskl.fsf@dataswamp.org>
2024-01-19 2:58 ` J.P.
2024-01-22 10:18 ` Emanuel Berg
2024-01-22 15:11 ` J.P.
2024-01-22 17:00 ` Emanuel Berg
2024-01-22 19:23 ` Emanuel Berg
[not found] ` <87y1ch851b.fsf@igel.home>
2024-01-22 21:05 ` Emanuel Berg
2024-01-22 21:27 ` J.P.
2024-01-23 4:25 ` Emanuel Berg
2024-01-23 4:32 ` Emanuel Berg
2024-01-23 6:20 ` Emanuel Berg [this message]
2024-01-23 13:31 ` Emanuel Berg
2024-01-24 0:36 ` J.P.
2024-01-24 0:56 ` Emanuel Berg
2024-01-24 1:38 ` J.P.
2024-01-24 2:01 ` Emanuel Berg
2024-01-23 13:42 ` Emanuel Berg
2024-01-24 0:34 ` J.P.
2024-01-24 1:28 ` Emanuel Berg
2024-01-24 1:38 ` Emanuel Berg
2024-01-24 11:15 ` Emanuel Berg
2024-01-24 11:55 ` Emanuel Berg
2024-02-05 0:52 ` Emanuel Berg
2024-02-06 3:44 ` J.P.
2024-02-11 1:58 ` Emanuel Berg
2024-02-11 2:27 ` Emanuel Berg
2024-02-11 3:30 ` Emanuel Berg
2024-02-11 3:52 ` Emanuel Berg
2024-02-14 1:42 ` J.P.
2024-02-17 5:21 ` Emanuel Berg
2024-02-17 8:52 ` Emanuel Berg
2024-02-21 1:11 ` J.P.
[not found] ` <87ttm2boza.fsf@neverwas.me>
2024-02-21 1:16 ` Emanuel Berg
2024-03-01 0:18 ` J.P.
2024-01-12 10:43 Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf2oin9p.fsf@dataswamp.org \
--to=incal@dataswamp.org \
--cc=68401@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).