From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Fri, 14 Jun 2024 14:23:17 +0200 Message-ID: <87sexfaf2i.fsf@gmail.com> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6887"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , 71499@debbugs.gnu.org, bkhl@elektrubadur.se, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 14 14:25:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sI5zc-0001bm-V4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jun 2024 14:25:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sI5zO-0000gM-2E; Fri, 14 Jun 2024 08:25:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI5zM-0000fz-6y for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 08:25:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sI5zL-0006KS-So for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 08:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sI5zK-0003hG-Iz for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jun 2024 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71499-submit@debbugs.gnu.org id=B71499.171836786814155 (code B ref 71499); Fri, 14 Jun 2024 12:25:02 +0000 Original-Received: (at 71499) by debbugs.gnu.org; 14 Jun 2024 12:24:28 +0000 Original-Received: from localhost ([127.0.0.1]:40097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI5ym-0003gF-2X for submit@debbugs.gnu.org; Fri, 14 Jun 2024 08:24:28 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:46124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI5yj-0003fz-TY for 71499@debbugs.gnu.org; Fri, 14 Jun 2024 08:24:27 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4210aa012e5so20446175e9.0 for <71499@debbugs.gnu.org>; Fri, 14 Jun 2024 05:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718367800; x=1718972600; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1bEUAtkNvbssaom2GLUVEjItTvs8MmdY6TiGH2MR1VI=; b=CVFuPHtP9QqOMCHuYE9/6Vdeq+Mn2WrQZhJWZer/7z+oL/JxLlNm1MLtBfY7wziH9z /hi2VF27EJf0kEmn5gcchNWVpfUWCy5dJLQ01s/UNCaECQz0ZkQsWIoLjHPDaaU2YbMR 2ZBJbnaWGl1Uast7GQKI7nQFvUu7mZdxB6bcmJgNRvNcvLWqsIKaqSTOQHim0biPqX66 GdUSJH5MUsKnEdl44xOr72oMycpxVXr7Pe/F7JM/KmLNL7fZq3nde5usJkaIsg5aeRCU tozoZtmF48dwPijvCcGQQbDiue6SaY0N58O8e7e8NKkte/LoHi1kQvfDTWekk9gqFhgg rXQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718367800; x=1718972600; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1bEUAtkNvbssaom2GLUVEjItTvs8MmdY6TiGH2MR1VI=; b=DiUPHR+VZ3islmQCJkax7BVyYRCfn+ZyNuS7/DPeRayh48lSuc00AqhQs0kc70NiEg Es19oKFZLvfbapF80svrJiTXWlbzqYi/ZdqKtNERYfT/Co+5mopR3YOrJW9a1YLQJDwn HP36vVnHpoiDKZ2wlIgpG1764+l0c+2c4slmsI8fyTZKXhf+3BQumhhg9F1oSO6+0EaA B0FiEWtp0yfDjVpXeFZhrYFPYU52tw/Y/qzqgSiJdv0iyqnSbLnq/g3E1PhKTr22Y9g1 MJINMLc0CIFWoK2f5WMVhiTvRUT2Ag1nnfC/YjHq71KgLc36C5uE3USlej0RLQuT2/yZ A5EQ== X-Forwarded-Encrypted: i=1; AJvYcCWDuKCQxVE8WpHCmZlvIgmQ9/kf+NI2+EPiIEfQ/IZLhI6aQf+UxA5BaCQtv3xYuJNwwShKP/SejE6tsCIljTUUsh5/bK8= X-Gm-Message-State: AOJu0YxRdLCd8H2h7opEr5SoHTXC1/0MTFz16YiC/ZAG9uGRiJJbS8QK PI4Yt4bI4x+pH9Ep3nxwX8726kO9QxkrrSs8SDjooJkGwzG3PD3T X-Google-Smtp-Source: AGHT+IHfVQ++NgEny4TS+dm8OUl/CDUGqUOa9M5Uc9GH031fWPCj3O7eROkgPR7yQF4LW771/sbhvQ== X-Received: by 2002:a05:600c:1d9f:b0:422:fe45:2629 with SMTP id 5b1f17b1804b1-4230482b87dmr22003965e9.23.1718367799649; Fri, 14 Jun 2024 05:23:19 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f641a64bsm59399855e9.46.2024.06.14.05.23.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 05:23:18 -0700 (PDT) In-Reply-To: <86jzitz1l0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Jun 2024 11:30:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287221 Archived-At: >>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii said: >> I'm as well for having the patch in, but I guess would be safer in 3= 1 so >> we have plenty of time to react if needed. Eli> OK, thanks. I will then install after the branch is cut. Eli> Meanwhile, Bj=C3=B6rn, I have a few comments to the patch: Eli> . it needs a NEWS entry announcing the new feature Eli> . is there any reason your code to handle the missing newline is= not Eli> identical to what the implementation of require-final-newline Eli> does? I=CA=BCm going to chime in and say that, even though I highlight missing newlines at eob, I don=CA=BCt normally set `require-final-newline' to t, because of various reasons involving collaboration with others. So I=CA=BCd have to turn this off once it goes in. Robert --=20