From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrea Corallo <acorallo@gnu.org>,
71499@debbugs.gnu.org, bkhl@elektrubadur.se,
stefankangas@gmail.com
Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline
Date: Fri, 14 Jun 2024 14:23:17 +0200 [thread overview]
Message-ID: <87sexfaf2i.fsf@gmail.com> (raw)
In-Reply-To: <86jzitz1l0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Jun 2024 11:30:51 +0300")
>>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> I'm as well for having the patch in, but I guess would be safer in 31 so
>> we have plenty of time to react if needed.
Eli> OK, thanks. I will then install after the branch is cut.
Eli> Meanwhile, Björn, I have a few comments to the patch:
Eli> . it needs a NEWS entry announcing the new feature
Eli> . is there any reason your code to handle the missing newline is not
Eli> identical to what the implementation of require-final-newline
Eli> does?
Iʼm going to chime in and say that, even though I highlight missing
newlines at eob, I donʼt normally set `require-final-newline' to t,
because of various reasons involving collaboration with others. So Iʼd
have to turn this off once it goes in.
Robert
--
next prev parent reply other threads:[~2024-06-14 12:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 18:16 bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Björn Lindström
2024-06-12 5:21 ` Björn Lindström
2024-06-12 7:46 ` Eli Zaretskii
2024-06-12 9:04 ` Björn Lindström
2024-06-12 9:41 ` Eli Zaretskii
2024-06-12 12:38 ` Stefan Kangas
2024-06-13 7:38 ` Andrea Corallo
2024-06-13 8:30 ` Eli Zaretskii
2024-06-14 12:23 ` Robert Pluim [this message]
2024-06-14 12:50 ` Eli Zaretskii
2024-06-20 7:55 ` Stefan Kangas
2024-06-20 8:22 ` Robert Pluim
2024-06-20 8:55 ` Stefan Kangas
2024-06-20 9:45 ` Robert Pluim
2024-06-20 11:23 ` Stefan Kangas
2024-06-27 7:37 ` Eli Zaretskii
2024-06-29 11:59 ` Björn Lindström
2024-06-29 13:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sexfaf2i.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=71499@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=bkhl@elektrubadur.se \
--cc=eliz@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).