From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72230: 29.4; Cursor Disappears with Hebrew Text Date: Mon, 22 Jul 2024 10:05:05 +0800 Message-ID: <87sew2xju6.fsf@yahoo.com> References: <86o76qbvd9.fsf@gnu.org> <86ikwybuoq.fsf@gnu.org> <86a5iabq90.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3921"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , hermann sorgel , 72230@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 22 04:06:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sViRg-0000sr-MM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jul 2024 04:06:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sViRR-0001NF-Ui; Sun, 21 Jul 2024 22:06:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sViRA-0001H2-SQ for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 22:06:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sViR5-00021F-Fa for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 22:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sViR7-00031Q-R7 for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 22:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jul 2024 02:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72230 X-GNU-PR-Package: emacs Original-Received: via spool by 72230-submit@debbugs.gnu.org id=B72230.172161393011578 (code B ref 72230); Mon, 22 Jul 2024 02:06:01 +0000 Original-Received: (at 72230) by debbugs.gnu.org; 22 Jul 2024 02:05:30 +0000 Original-Received: from localhost ([127.0.0.1]:56426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sViQc-00030e-EZ for submit@debbugs.gnu.org; Sun, 21 Jul 2024 22:05:30 -0400 Original-Received: from sonic316-21.consmr.mail.ne1.yahoo.com ([66.163.187.147]:36257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sViQZ-00030R-Pk for 72230@debbugs.gnu.org; Sun, 21 Jul 2024 22:05:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1721613919; bh=q7T6QSye1Yw28pFfR51GcS0Rx9zU1wD6tGFkvbCKdw0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=XMH5h6qc2IAx4OCiemm1InayDcGh+RRRaZ/KoIpv75YSmDnSNJFshh/nde6rATtD4HgfxOYDWLWZUEI8n4L1B47jFPF6nAsL0jvQCS0UHM3nh8NhLaT5l3e7C+09V5n27NpI7H3KlYg2VbV9Yb5aASHpgpgy+AOrIlKujPJfjbjfMmkpUFh1/aWnZ8954LFo3IKbe0+yKLWD9TNYNJPbbfQIb3vA11BNsVm7oX7eIrTPFhp9L33a8mQOYFxknKnj1NnebSSJJPTJ6hmWaKhZXm/7F/+Mwaoud4Ljl3Mvt+0Lzov9LLWWzbUPVTwTdGGjL+z2ObxnLTLs/kzEEhJHCw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1721613919; bh=4z1PA3i/HRwXQbuIfFTTx85pgzLP5yvhBdYtJtRPt8Z=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=tdaTpw3ydmblN2mx5WoJRkJ+lXAN582sgN36TXQDaUjH7eYb+uYDz2qdR8rHQWwQXW8PJM3F8xrHZZ6uHcgGTmmBXcYW96o9T5a3T3ubphNc9VPZmsMpESuSM1UTRaqkbX3p6xSuDMo4b8qwZDBq9nbCX78Z9yaVqmuDeOfgjuhJjtdrif7Kb2G27ylrMlAk0GAHouIrDVWGhI1hM5Ad7MtH4RqZQlwZt4508Eoyj30xFaQJq2UTlnLgvXkYI99/qpGFsafoTEz+W3M2hG46qdh0/MG7P1kYlBz1hPNqpy0WCy6ubawHb1QGqjxKW9iI1DGK5swxPK+nc1lyAMubzA== X-YMail-OSG: R6kCxTMVM1nhCWxUBmhOZcDeY_Rb79suVNoJHxIP410EkLmYEAZcf_DTj682RLQ fjhJXiwQCaqLNmwTOIvgq9yLYhrAtCTlxjqcg74xZxzrQWHnhvRLF3qzfa9RWCpY8y0P3hPEfXx2 L5hoU2NPsK9fJrkOdz.F_kW5E0OTiswgEoxCPvVflDspea3Cl8RNS3Y98N9M0CgG1raeFRrbl55. XSQjOkiNwiz3LfoLRxEJcWaUMPjZdTlnuoiWZHVeUtGyYVprYhJ1HdJzc4MkCf2pRc6Llm2Opi5m woZLh6qygtAVLd90mawaUpUxUWbUoo.NXTftyLuvGnpEmIdLAS7VCfpZSdQivkU3wMs9vRWG3k98 9rag3g3DYb.axkF6S0WlPAxYGiB_g1djPpNsYs1fR0R2kphuljhlZ_gYLu_0JUvjYhH02e2cIbSR a9Wn8zLqAEcg8WoT8PGojB_D_Stluxoc7NUAqGtpoDLj2lW4Adspmtei1tXP2LlNTIGEf5.y2L7F a5wjLQovKjDo741SUme3dwHWkosbUssrV4WAFLM27vRkCI8gUTwKzGZi06.UAhvPIHaMPC3RivWp 7CmRW7i0S9vWdwZrvJyb_kHGkSUZPzo6MqrheM4fw6P8DjYvqdX67uvHz4nw3Bw3RT6m8YGFDBYR ySYPDvirytBijxfjJ2wIJxW1vqGYy8TF95BFWofrKzFbxZJA.H0A7_36zDi59jGDXvdWDbVyIKAL u0kwYIBgfV_tNWqzJcsJENsi9itvvi3r4LMzw2ozDxbpe7uF215bPKxj97.PP9rEqFWzyNLxgPf8 qHnvXkbMsBV.zTFsLJMYMCZWAph8puLJSl0eazj3Uk X-Sonic-MF: X-Sonic-ID: da1cc6f3-ec90-4a38-b34d-76ebdee76de1 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Mon, 22 Jul 2024 02:05:19 +0000 Original-Received: by hermes--production-sg3-85fdb5cfc8-ls28f (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5d1cbfae47ba5dd4f33f05b82aa211db; Mon, 22 Jul 2024 02:05:15 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Sun, 21 Jul 2024 11:05:57 -0700") X-Mailer: WebService/1.1.22501 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289105 Archived-At: Stefan Kangas writes: > Eli Zaretskii writes: > >> So maybe the problem is elsewhere. One thing is almost certain: it's >> a problem specific to the macOS build of Emacs. People who can debug >> on that platform are encouraged to suggest insights and changes. > > This seems to have something to with the clipping path, and is fixed > here by the below patch. I don't think it's suitable for installing > though. > > Po Lu, since you added the below NSRectClip call, do you have any > thoughts here? Yes, this will cause the overhangs of a cursor glyph to overwrite its surroundings. There is certain to be some other factor that has not been accounted for, while mindlessly removing clipping operations is not the solution. > diff --git a/src/nsterm.m b/src/nsterm.m > index 794630de1c1..54b15bc851d 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -3102,7 +3102,7 @@ Note that CURSOR_WIDTH is meaningful only for > (h)bar cursors. > #ifdef NS_IMPL_GNUSTEP > GSRectClipList (ctx, &r, 1); > #else > - NSRectClip (r); > + // NSRectClip (r); > #endif > > [FRAME_CURSOR_COLOR (f) set]; > @@ -3135,7 +3135,7 @@ Note that CURSOR_WIDTH is meaningful only for > (h)bar cursors. > on the right of its glyph, rather than on the left. */ > cursor_glyph = get_phys_cursor_glyph (w); > if ((cursor_glyph->resolved_level & 1) != 0) > - s.origin.x += cursor_glyph->pixel_width - s.size.width; > + s.origin.x += cursor_glyph->pixel_width - cursor_width; I don't recollect what `s' is supposed to represent.