From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#72735: 31.0.50; [PATCH] Make more bug-reference variables customizeable Date: Wed, 21 Aug 2024 07:20:27 +0200 Message-ID: <87seuyh2p0.fsf@gnu.org> References: <86plq3uib0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9415"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: =?UTF-8?Q?Bj=C3=B6rn?= Bidar , 72735@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 21 07:23:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgdoi-0002Ji-0C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Aug 2024 07:23:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgdoV-0006r2-Nx; Wed, 21 Aug 2024 01:23:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgdoU-0006qn-3S for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 01:23:18 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgdoT-0004LB-PV for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 01:23:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=lhoicBoufMRJWmXyH0Wb1L+UiVkCFByMExkLsuXbqcQ=; b=UrBSdGqQkwJtMkettVFWF6wXnP+4OxIJiVb7+vm0PJeOXD5QFDLeKEM7sXgyPYe62spc0WaSc8R7dz76J6+A3bZXYMsR80jelIymo2Ng6N/slmBMzad2twPBgwWeUx8zdTCDoAAQMqrKJIqiIFX8zehv0AUUCEfbWfeNcBx68qXwjp0SwGvgO9/pv98ueOxa1uwFohSOIPghtu/fAQ0NF9wFr22vzgamf1U+5GQbISFTUsVdyizOPAMMbY3BNo1UlLoTeHXbxtrOrWcJyWybSBB17LUaLWzISy5AgzIFvehHVwQ33WgEY2bIM6MMphAzmnGD/cKodO83TOc7F5a2+g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgdpB-0004oA-Mf for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 01:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2024 05:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72735 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72735-submit@debbugs.gnu.org id=B72735.172421781518405 (code B ref 72735); Wed, 21 Aug 2024 05:24:01 +0000 Original-Received: (at 72735) by debbugs.gnu.org; 21 Aug 2024 05:23:35 +0000 Original-Received: from localhost ([127.0.0.1]:34758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgdok-0004mn-LC for submit@debbugs.gnu.org; Wed, 21 Aug 2024 01:23:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgdoi-0004mU-JE for 72735@debbugs.gnu.org; Wed, 21 Aug 2024 01:23:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgdlo-0004CI-Q8; Wed, 21 Aug 2024 01:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lhoicBoufMRJWmXyH0Wb1L+UiVkCFByMExkLsuXbqcQ=; b=criGaUF7hTjJ4Yclb0RY q0IBz6TijgGfz/hkjOOsxs71pltJ7g1NMjyAWQW+9u1hTrYrkH7l45eRCp6/EE/gOiJlbFUFbNCDD Fv2xSmi2xmtlMTqgEARHfLVf5/NJJ8k7c0LChFeqJtFtXheL2gQQRsQBpxlVAecBCrxHHTiiQLFNP l10fU3RP6Y665f9D+J1ImzjPokK/K2A3RFU8uItRXbzSNS2bxPOhBJ+CqLuv/nAR093QeYo1i3eON UL7F0mTEk12Y8TB+uW6wZspLn95H/jET2O0s0zZHAxVOmZlWLb65y8yzpgkEu3+YObKIU+ZEPBhQO voYqRk2a0ERr8g==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddujedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgesthdtredttdertden ucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenuc ggtffrrghtthgvrhhnpedthedvfffhkedtleejvdelgefgieefgeekudeffeeitdffteeg vdetvefgjeehudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieej feekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilh drfhhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthho peejvdejfeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepsghjohhrnh drsghiuggrrhesthhhrghouggrnhdruggvpdhrtghpthhtohepvghlihiisehgnhhurdho rhhg X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-Reply-To: <86plq3uib0.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Aug 2024 22:04:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290480 Archived-At: Eli Zaretskii writes: Hi all, >> I noticed that there are other variable such as >> bug-reference-setup-from-mail-alist that should be change similarly. > > Which ones, specifically? > > And let's get Tassilo (CC'ed) on board of this discussion. As Eli already mentioned, bug-reference-url-format is usually set via a file local variables section or programatically so neither a defcustom nor a default value makes sense. Wrt. bug-reference-setup-from-mail-alist, bug-reference-setup-from-irc-alist, and bug-reference-setup-from-vc-alist: yes, they could be defcustoms but their entries can all (and are likely to) contain functions which are hard to specify in the defcustom interface. I've thought it wouldn't be needed. After all, bug-reference is a programmer's tool. Wrt. bug-reference-forge-alist: if it became a defcustom and a user would set it, she wouldn't see updates (like support for some new forge) in its default value anymore because their old saved custom value overrides the new default value. It's much better to add new entries programatically using add-to-list or push/cl-pushnew. Of course, one could split the variable in some *-default-alist defvar and a defcustom *-alist where the latter is meant for user customization but I think it's not worth the added complexity here. So I'd rather keep it as-is. Bye, Tassilo