From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#72358: 29.4; oauth2.el improvements Date: Wed, 21 Aug 2024 19:42:28 +0000 Message-ID: <87seuxacij.fsf@posteo.net> References: <87mslz8yzk.fsf@debian-hx90.lan> <87frrr725m.fsf@gmail.com> <87ed7a8ye6.fsf@debian-hx90.lan> <87jzh2vt3y.fsf@gmail.com> <87frrp6ch8.fsf@debian-hx90.lan> <87ttg349yd.fsf@debian-hx90.lan> <86r0b6up8p.fsf@gnu.org> <87ikw4qdvx.fsf@debian-hx90.lan> <86plqbfzat.fsf@gnu.org> <877ccjecnc.fsf@debian-hx90.lan> <86wmkj8o29.fsf@gnu.org> <87wmk9busk.fsf@debian-hx90.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24168"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bjorn.bidar@thaodan.de, Eli Zaretskii , fitzsim@fitzsim.org, rpluim@gmail.com, 72358@debbugs.gnu.org To: Xiyue Deng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 21 21:43:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgrEw-00065q-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Aug 2024 21:43:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgrEm-00029R-6B; Wed, 21 Aug 2024 15:43:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgrEk-000294-4i for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 15:43:18 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgrEj-0006cb-Dk for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 15:43:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=wIYE19/UJUZ/P6xdkhin33I+GkOf1Kce3ReLkXWMvb4=; b=sd8JJMINrRVrcdvE7dtmPllOBdCjgp3qeJXGoFMGwML3OmpSbEzp+wbn63We4b7JsTCFDdYW7MM269B4kW+Y3dqSGfSN/aiz+48WNOUC8aCveaDZuMqjdY0Aw6IZkTpiTjdQrql4uA1jfqz5U00DHs/1FE2HxC5Uc2cXRgnSJJrDhF4qMlE9B38VibucFQ6bLF5lA9Lle9zB301BbtVneT6kHxRzIi80P9cJ4ynJrQoq0+6qHDqWxpMi17JTdfWcBvDD7rat/kGBAwMTh8SgJEgW9VR4TIVh4PnXhvnBFgNf+oAnW4Y5gQ4Zk1anAp5EcWoAdyimoY11XNUwgQ4MHA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgrFS-00064O-4r for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 15:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2024 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72358 X-GNU-PR-Package: emacs Original-Received: via spool by 72358-submit@debbugs.gnu.org id=B72358.172426940523279 (code B ref 72358); Wed, 21 Aug 2024 19:44:02 +0000 Original-Received: (at 72358) by debbugs.gnu.org; 21 Aug 2024 19:43:25 +0000 Original-Received: from localhost ([127.0.0.1]:36393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgrEq-00063O-Su for submit@debbugs.gnu.org; Wed, 21 Aug 2024 15:43:25 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:49441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgrEo-000639-LA for 72358@debbugs.gnu.org; Wed, 21 Aug 2024 15:43:24 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3FC35240104 for <72358@debbugs.gnu.org>; Wed, 21 Aug 2024 21:42:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1724269352; bh=+lPT3UJA4pb9ibXlVbE5JvLMI/6fMTS/mYvxf9MpqLY=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=E8nHC4av2ntUsbeSUEJ5AHYD9SApIcibZM8bUWN4vQxuCrh3YnEbaDF5w5pOwpnJY 2WDwkfoYkz5ODJL61y6vjGX+qEdeTOJdLIjznEsPFMOX1Hrekt2YE9NIdyeIfn2xEh StAoA3LOwjOMXdkJIVlGJQAyEArmkcW4cB5b3SMs9I8Rz2f43U2sJO0/bnNojcUepp rqXMgXPtYGP8/Eldr5RNrLL19ewqkgeXmgBSwu5pX9FFGONqI3F88/GILfMNdd3RNv 4vFcD6RgkSjdRBGDON5lNEwgbSrqC+qxLD2SZ2mvv7ql49gFhGLmcsURAJw1IYMmho kS+/l/7rfr8KA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WpxYy12WXz9rxR; Wed, 21 Aug 2024 21:42:29 +0200 (CEST) In-Reply-To: <87wmk9busk.fsf@debian-hx90.lan> (Xiyue Deng's message of "Wed, 21 Aug 2024 11:22:19 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290502 Archived-At: Xiyue Deng writes: > Eli Zaretskii writes: > >>> From: Xiyue Deng >>> Cc: Thomas Fitzsimmons , Bj=C3=B6rn Bidar >>> , rpluim@gmail.com, 72358@debbugs.gnu.org >>> Date: Wed, 14 Aug 2024 01:23:19 -0700 >>>=20 >>> >> It's been a few days since the last time I received feedback for >>> >> improvements regarding my patches. Is there any other feedbacks/rev= iews >>> >> I am expecting from the co-maintainers? Please also let me know when >>> >> it's time to ask for merging and requesting a new tagged release. >>> > >>> > ?? The last message in this discussion was just yesterday evening, and >>> > my understanding is that you are still discussing the issues and did >>> > not reach the final conclusion. If I'm mistaken, my apologies; >>>=20 >>> The recent communication was not related to my patches but to check >>> whether it is possible to support outlook.com OAuth2 login (and the >>> conclusion was no because refreshing access token was disabled as >>> confirmed by MS representative during an online chat.) >>>=20 >>> > please describe your conclusion and post the patch that you-all agree >>> > would solve the issues, and let's take it from there. >>>=20 >>> I actually only received comments from Robert and I have updated my >>> patches according in [1][2] (also attached in EOM). >>>=20 >>> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72358#20 >>> [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72358#44 >> >> Thanks. >> >> Philip, could you please DTRT here? This seems to be an ELPA package. > > Friendly ping. Please also let me know if there are more review > comments. I'm sorry, this was a rather long thread and I didn't have the time yet to follow up on it. Can you confirm that you want me to review the patches attached to this message: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72358#20 ? --=20 Philip Kaludercic on peregrine