From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#75291: Redisplay not updating fringe when face filter changes Date: Fri, 03 Jan 2025 14:46:20 -0500 Message-ID: <87sepz65pv.fsf@dancol.org> References: <874j2h3yzb.fsf@dancol.org> <8634i1jeai.fsf@gnu.org> <87ttah2hcd.fsf@dancol.org> <86v7uxhv9c.fsf@gnu.org> <87ikqx2dwh.fsf@dancol.org> <86h66hhr3a.fsf@gnu.org> <87ldvrajym.fsf@dancol.org> <867c7bheyp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33002"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.8; emacs 31.0.50 Cc: 75291@debbugs.gnu.org, mina86@mina86.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 03 20:47:27 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTndm-0008QB-85 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Jan 2025 20:47:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTndQ-0001QJ-Ok; Fri, 03 Jan 2025 14:47:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTndO-0001J0-Kk for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 14:47:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTndO-0001Oj-CD for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 14:47:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=/XgSUiLqqirWa5dh2YYN40DsLaZ/kI3hbU2vZvuCGqg=; b=tfCmIhOIn+O5vHKPtrjUPqAkh7CwKLCqbNnZ/3SXPLuBh/3OmLYWdLCIEV6i8Jp863v83sq4mReXX7EGw41IT682Fp3Vdg4u1MoVsxSzQCsR4g7SUdhJ7YQHhnG5uDIGfjTTpeCGO6CqhrCxnrevcm800VZ948/RrDPduYPPFnsxjRK9P3rmyQ2NsxQQzijA5JK/ConVANM1AtFdRsHUDv7GUuQII2CGGJCqQNfjRA37Bvd6JO85A27ZwoQkTFRuNIeYZsNIwDadbquqX/UMsXvOAqNcmW5srFtoPtzGA9AJDl/dT+g8/Xzuk2/cpI9JOs0R/EuqSMThBKm6B0FUlw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTndO-0004zR-5t for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 14:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2025 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75291 X-GNU-PR-Package: emacs Original-Received: via spool by 75291-submit@debbugs.gnu.org id=B75291.173593358919105 (code B ref 75291); Fri, 03 Jan 2025 19:47:02 +0000 Original-Received: (at 75291) by debbugs.gnu.org; 3 Jan 2025 19:46:29 +0000 Original-Received: from localhost ([127.0.0.1]:52234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTncr-0004y4-1S for submit@debbugs.gnu.org; Fri, 03 Jan 2025 14:46:29 -0500 Original-Received: from dancol.org ([2600:3c01:e000:3d8::1]:56376) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tTncn-0004xZ-Pb for 75291@debbugs.gnu.org; Fri, 03 Jan 2025 14:46:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/XgSUiLqqirWa5dh2YYN40DsLaZ/kI3hbU2vZvuCGqg=; b=h3eogWw+2N1gK6XFgfXK2QNhki C5by5eE/p8tu5eReW8735F8PlU7iqTyM/IPpAJO340+7unWZat8FsMD1o2vZ8WdjkOZH0fDDhVT4E 9T36jhbX4wnBql+c9UaMzMLUQ2P6qtoTn/7wTw5TikSk7KbW2GY/2pC6fWhgHms+P/26ghQu58594 q5sxHWn9NkR6qJt9qBnL6UPAQziblfgzJ12QUZTsY2zGxmHiUMZ2XHi6/Fawn9AAJ7T5FnB8YB9z1 po+KTrySbpOU6+DGJVbBZpGUzP9zUGt2CaIfGPizpK7wUZpmxDXUxAgM5Ox/zqmBEjcsg9m94quf5 ZzXvelvg==; Original-Received: from syn-097-104-088-154.res.spectrum.com ([97.104.88.154]:41154 helo=localhost) by dancol.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tTnck-0007dx-2h; Fri, 03 Jan 2025 14:46:23 -0500 In-Reply-To: <867c7bheyp.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 03 Jan 2025 21:31:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298304 Archived-At: Eli Zaretskii writes: >> From: Daniel Colascione >> Cc: 75291@debbugs.gnu.org, mina86@mina86.com >> Date: Fri, 03 Jan 2025 12:25:05 -0500 >> >> > I think it depends on whether you use double-buffering (some people >> > don't or cannot) and whether you have the mouse pointer over an Emacs >> > frame. Also, depending on the GUI toolkit, the decorations might >> > flicker. >> >> TTY windows don't have fringes, and the most commonly-used window >> systems all do atomic updates nowadays. > > People still report flickering from time to time, so I don't think > this never happens. > >> > So you want to add to display_line code that sets each glyph_row's >> > redraw_fringe_bitmaps_p flag when the fringe face changes? That could >> > probably work, provided that we disable redisplay optimizations which >> > might avoid calling display_line (you will see that we already disable >> > such optimizations when overlay_arrows_changed_p returns non-zero). >> > We might actually need to disable more of the optimizations, because >> > the overlay-arrow thing doesn't contradict the optimizations that >> > scroll the pixels, something that reaction to changes in the fringe >> > face cannot tolerate. >> >> That might work, but I don't think we even need anything that >> complicated or low-level. Not many are using :filtered now, and those >> that do big redraws anyway. How about this simpler code that gets us >> correctness, albeit more conservatively? > > Doesn't that only support face remapping with :filtered attribute? > What about the more general case where the fringe face is remapped in > a way that's independent of the windows? That seems to work already. It's only in the fringe that I see problems --- it just doesn't seem worth it to limit the redraw to the fringe.