From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#75354: (29.4; eww buffer is not displayed correctly when used from bookmark-jump ) Date: Wed, 08 Jan 2025 14:47:26 +0000 Message-ID: <87septicqp.fsf@posteo.net> References: <87zfk6eekc.fsf@posteo.net> <87h669vjm9.fsf@posteo.net> <8634ht4fkd.fsf@gnu.org> <87sept5s67.fsf@posteo.net> <86y0zl2yix.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22026"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thierry Volpiatto , 75354@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 08 15:42:16 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVXGC-0005aS-D4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jan 2025 15:42:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVXG0-0000zP-F4; Wed, 08 Jan 2025 09:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVXFy-0000y4-MB for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 09:42:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVXFy-0008Cw-Ds for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 09:42:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=h2VJOrW8u7IG70ttpXCEP5Lbk04nqS3AcuzJ+LrOEfo=; b=IT8cNgvstK5YYQB2+4IvNxBnyzOhcraciebkXWZ7OA6tWihIk/NHz18zOQEt6lg1Fzv4O7yVPhcvJdYeIivvfhOlMvJpk87ccfUbpPIKfO9MBxb4vhzfM9M8I0QP8uwpxxqpNJgkvEkDAoTeMNv+Jr6Ey5SOvxa4gaQG0gSyzHqbNjV0ZQ4CNNMIJWfNAcZnpaRRcbg7XOYQtESwJ6oxphIpZuFw0xXWcc50iPrHU7rcGgg3+IY0umXwosBrtIfsn6JTNBCdWMBvVn8Dlow3BSQHsWhqk0gmz9pyKcgL8/kCKGlupuyQ670byK+Io77D54AcNEzw8PbA6gOiK6hthg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVXFx-0006HJ-Oa for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 09:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2025 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75354 X-GNU-PR-Package: emacs Original-Received: via spool by 75354-submit@debbugs.gnu.org id=B75354.173634729124091 (code B ref 75354); Wed, 08 Jan 2025 14:42:01 +0000 Original-Received: (at 75354) by debbugs.gnu.org; 8 Jan 2025 14:41:31 +0000 Original-Received: from localhost ([127.0.0.1]:46574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVXFT-0006GU-4S for submit@debbugs.gnu.org; Wed, 08 Jan 2025 09:41:31 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:37571) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVXFO-0006GB-EH for 75354@debbugs.gnu.org; Wed, 08 Jan 2025 09:41:29 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 15386240101 for <75354@debbugs.gnu.org>; Wed, 8 Jan 2025 15:41:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1736347277; bh=I/7DM1hXTl2pc6dic23DDVrbDspo9fVdn47Y7ddj9VY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=J1J5nzRPIf6jvXMI41d4r+tLsOoSeuKaYTdYzN9BVu3+rrMDI7KzRkofzggveOyy3 WfxDuw6IpPtbKaiuTDMYdJUs19ydqoDms+ywwFr+y+3QB8byONaOT/xxkK51xxHnbp REJtZPxMPkWB5ws3YebxflxOixoLcblRDLrxlBWCve6LyV1Y33rz2TMv8D4pZAGf2r WcjF1l2QSoRzxxAoDdOWOiq0fe0EV+XwAqLa1Z0iMbsfgQciz4l+K9u1E55iMQ0ghS 2nMqZqZ1UBD7llIHnqeKGidwcCRDbfgiqYvQwDJEAmLesZY70jpE8YQLx8AJSpGs3u j5aA5sxez3tTA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YSrFj3FZSz6tvr; Wed, 8 Jan 2025 15:41:12 +0100 (CET) In-Reply-To: <86y0zl2yix.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 Jan 2025 16:03:34 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298784 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Thierry Volpiatto >> Cc: Thierry Volpiatto , 75354@debbugs.gnu.org >> Date: Wed, 08 Jan 2025 13:52:32 +0000 >>=20 >> > This is contrary to what you originally wrote (with which I agree): >>=20 >> Yes, after deeper search I found that `bookmark--jump-via` is behaving >> like this AFAIU: >> - It calls the handler which creates a new buffer related to bookmark. >> - It then displays the current-buffer (the one before jumping to bmk) in >> a window according to DISPLAY-FUNCTION and make the bookmark buffer cur= rent. >>=20 >> This approach is OK as long as the handler fn doesn't try do do one part >> of the job (window handling) itself, which is not the case at least with >> eww and w3m. It is as well counter intuitive, DISPLAY-FUNCTION should >> be called on the buffer generated by bookmark and not the contrary, so >> this change makes the code simpler and easier to understand. >>=20 >> > By contrast, the change you propose now will affect all the uses of >> > bookmarks, everywhere, >>=20 >> Yes, this is intended, in addition of fixing eww, it fixes w3m and also >> the quit function of eww (actually broken). >>=20 >> > which is riskier, given how many different variants of bookmark usage >> > are out there. >>=20 >> Tested here on many different kinds of bookmarks and work as expected >> unlike the current code. > > OK, thanks. Let's leave this for a few days to give people time to > post comments if they have them. Ok, I will make changes to commit message (needs * lisp/bookmark.el (...): bla) and also when-let =3D> when-let* to fit with emacs-30+. Thanks. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmd+j/4THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk9URDACfyPYjlXJbYLBA8QgnNFl5uJ1v2fdx Efbofa4WZisWpXttJwAAMipryv7mWs+mB3+E0eyA7AhVdZxaY5mBOoBn0LmqcEBr DANQY4iRNDuSlw5M/ffVF78yomgwR0dABeatf6MSO1L3CeWBIurHPZowSax+WC9I Gyn0nTP1Qjgupeva0BmMs3dwYqeI/+jSxS5XsUDCJjBQjWnSnTKSfO4BwMKyzhF7 M4Qm6vpVeZBsJTwMxFh+GAwBt9kU3qyoPyz5pnVVd8VrCczClhKQGzgePKvUCqiB lWoDQfybEnB/SDSCRR5wC/08W1F3iN/BsT1D7jpTmRyWL062goN9sKB53Zmkqxne 4TcuSoh4l3MBTndHiNxVseHujRmK7us1IqD2WCF90TmSPkLie3Sd/G9N9fWCc5Vl jfaD8l43uMhGCICt6qOnNsWqqTeu8KqYOz8wN/1qg0cOT1Xb5zh2P5u/I9QqGkDe h/Q8D2aDV+VX4qkVHC53EqGTv3mcXoWVivg= =O0uO -----END PGP SIGNATURE----- --=-=-=--