bug#1545: 23.0.60; scroll-bar-mode and fringe

bug#1545: 23.0.60; scroll-bar-mode and fringe

[TAKAHASHI Naoto]

$ emacs -Q
M-x scroll-bar-mode RET
M-< C-e 1 2 3 4 5 6 7

The character '6' is not displayed.


In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.11) of
 2008-12-09 on duron Windowing system distributor `The X.Org
 Foundation', version 11.0.10402000 Important settings: value of
 $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value
 of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC:
 nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS:
 nil locale-coding-system: nil default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-p C-p C-p C-p C-e 1 2 3 4 5 6 7 8 M-x s c r o l l 
SPC b SPC m SPC o SPC RET M-x M-p RET M-x r e p o r 
t SPC e m SPC SPC RET

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list...

bug#1545: 23.0.60; scroll-bar-mode and fringe

[Daiki Ueno]

>>>>> In <E1LB2Zx-00035M-76@duron.m17n.org> 
>>>>>	TAKAHASHI Naoto <ntakahas@duron.m17n.org> wrote:
> $ emacs -Q
> M-x scroll-bar-mode RET
> M-< C-e 1 2 3 4 5 6 7

> The character '6' is not displayed.

I've also experienced the same problem for months.  I just did
git-bisect to find the cause.  Here is the log:

git-bisect good a7ed2949c9a3769de4c44c8e9b1000fa708860e1
git-bisect bad 64ed432df346190927205d0c7f5adb7c32ba13ea
git-bisect bad 0509621969ae0bf6cc78f58bb0aa6c8c2c0109ee
git-bisect skip ca88bf954c086af59495e5c7f1b6e6de5c4b7124
git-bisect skip e7b1f8ef280ab2a452d01b5d67d4319d56fc6b28

commit e7b1f8ef280ab2a452d01b5d67d4319d56fc6b28
Author: Jan Djärv <jan.h.d@swipnet.se>
Date:   Sat Mar 1 14:56:53 2008 +0000

    (xg_resize_outer_widget): Only do one of set_geometry or
    set_char_size.
    (xg_frame_resized): Renamed from xg_resize_widgets.  Remove all
    operations on widgets here.  Just set frame size if needed.
    (flush_and_sync, x_wm_size_hint_off, xg_pack_tool_bar): New functions.
    (xg_frame_set_char_size): Call x_wm_size_hint_off before resizing.
    (x_wm_set_size_hint): Set size hints on the edit widget only, not
    the whole frame.
    (xg_create_tool_bar): Move attachement of the tool bar to
    xg_pack_tool_bar.  Do not attach the tool bar if there are no items.
    (free_frame_tool_bar): Remove call to SET_FRAME_GARBAGED.

This change introduced an extra guard around resize handling (in
gtkutil.c:xg_frame_resized), so that the layout logic no longer takes
place even if scroll-bar is turned off.

+      if (rows != FRAME_LINES (f) || columns != FRAME_COLS (f)
+          || (f->new_text_lines != 0 && f->new_text_lines != rows)
+          || (f->new_text_cols != 0 && f->new_text_cols != columns))
+        {
+          change_frame_size (f, rows, columns, 0, 1, 0);
+          SET_FRAME_GARBAGED (f);
+          cancel_mouse_face (f);
+        }
-      change_frame_size (f, rows, columns, 0, 1, 0);
-      SET_FRAME_GARBAGED (f);
-      cancel_mouse_face (f);

Regards,
-- 
Daiki Ueno

bug#1545: 23.0.60; scroll-bar-mode and fringe

[Jan Djärv]

I have fixed that now.

	Jan D.

Daiki Ueno skrev:
>>>>>> In <E1LB2Zx-00035M-76@duron.m17n.org> 
>>>>>> 	TAKAHASHI Naoto <ntakahas@duron.m17n.org> wrote:
>> $ emacs -Q
>> M-x scroll-bar-mode RET
>> M-< C-e 1 2 3 4 5 6 7
> 
>> The character '6' is not displayed.
> 
> I've also experienced the same problem for months.  I just did
> git-bisect to find the cause.  Here is the log:
> 
> git-bisect good a7ed2949c9a3769de4c44c8e9b1000fa708860e1
> git-bisect bad 64ed432df346190927205d0c7f5adb7c32ba13ea
> git-bisect bad 0509621969ae0bf6cc78f58bb0aa6c8c2c0109ee
> git-bisect skip ca88bf954c086af59495e5c7f1b6e6de5c4b7124
> git-bisect skip e7b1f8ef280ab2a452d01b5d67d4319d56fc6b28
> 
> commit e7b1f8ef280ab2a452d01b5d67d4319d56fc6b28
> Author: Jan Djärv <jan.h.d@swipnet.se>
> Date:   Sat Mar 1 14:56:53 2008 +0000
> 
>     (xg_resize_outer_widget): Only do one of set_geometry or
>     set_char_size.
>     (xg_frame_resized): Renamed from xg_resize_widgets.  Remove all
>     operations on widgets here.  Just set frame size if needed.
>     (flush_and_sync, x_wm_size_hint_off, xg_pack_tool_bar): New functions.
>     (xg_frame_set_char_size): Call x_wm_size_hint_off before resizing.
>     (x_wm_set_size_hint): Set size hints on the edit widget only, not
>     the whole frame.
>     (xg_create_tool_bar): Move attachement of the tool bar to
>     xg_pack_tool_bar.  Do not attach the tool bar if there are no items.
>     (free_frame_tool_bar): Remove call to SET_FRAME_GARBAGED.
> 
> This change introduced an extra guard around resize handling (in
> gtkutil.c:xg_frame_resized), so that the layout logic no longer takes
> place even if scroll-bar is turned off.
> 
> +      if (rows != FRAME_LINES (f) || columns != FRAME_COLS (f)
> +          || (f->new_text_lines != 0 && f->new_text_lines != rows)
> +          || (f->new_text_cols != 0 && f->new_text_cols != columns))
> +        {
> +          change_frame_size (f, rows, columns, 0, 1, 0);
> +          SET_FRAME_GARBAGED (f);
> +          cancel_mouse_face (f);
> +        }
> -      change_frame_size (f, rows, columns, 0, 1, 0);
> -      SET_FRAME_GARBAGED (f);
> -      cancel_mouse_face (f);
> 
> Regards,