unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daiki Ueno <ueno@unixuser.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: TAKAHASHI Naoto <ntakahas@duron.m17n.org>,
	1545@emacsbugs.donarmstrong.com
Subject: bug#1545: 23.0.60; scroll-bar-mode and fringe
Date: Wed, 17 Dec 2008 12:03:42 +0900	[thread overview]
Message-ID: <87r647wlip.fsf@broken.deisui.org> (raw)
In-Reply-To: <E1LB2Zx-00035M-76@duron.m17n.org> (TAKAHASHI Naoto's message of "Fri, 12 Dec 2008 16:36:53 +0900")

>>>>> In <E1LB2Zx-00035M-76@duron.m17n.org> 
>>>>>	TAKAHASHI Naoto <ntakahas@duron.m17n.org> wrote:
> $ emacs -Q
> M-x scroll-bar-mode RET
> M-< C-e 1 2 3 4 5 6 7

> The character '6' is not displayed.

I've also experienced the same problem for months.  I just did
git-bisect to find the cause.  Here is the log:

git-bisect good a7ed2949c9a3769de4c44c8e9b1000fa708860e1
git-bisect bad 64ed432df346190927205d0c7f5adb7c32ba13ea
git-bisect bad 0509621969ae0bf6cc78f58bb0aa6c8c2c0109ee
git-bisect skip ca88bf954c086af59495e5c7f1b6e6de5c4b7124
git-bisect skip e7b1f8ef280ab2a452d01b5d67d4319d56fc6b28

commit e7b1f8ef280ab2a452d01b5d67d4319d56fc6b28
Author: Jan Djärv <jan.h.d@swipnet.se>
Date:   Sat Mar 1 14:56:53 2008 +0000

    (xg_resize_outer_widget): Only do one of set_geometry or
    set_char_size.
    (xg_frame_resized): Renamed from xg_resize_widgets.  Remove all
    operations on widgets here.  Just set frame size if needed.
    (flush_and_sync, x_wm_size_hint_off, xg_pack_tool_bar): New functions.
    (xg_frame_set_char_size): Call x_wm_size_hint_off before resizing.
    (x_wm_set_size_hint): Set size hints on the edit widget only, not
    the whole frame.
    (xg_create_tool_bar): Move attachement of the tool bar to
    xg_pack_tool_bar.  Do not attach the tool bar if there are no items.
    (free_frame_tool_bar): Remove call to SET_FRAME_GARBAGED.

This change introduced an extra guard around resize handling (in
gtkutil.c:xg_frame_resized), so that the layout logic no longer takes
place even if scroll-bar is turned off.

+      if (rows != FRAME_LINES (f) || columns != FRAME_COLS (f)
+          || (f->new_text_lines != 0 && f->new_text_lines != rows)
+          || (f->new_text_cols != 0 && f->new_text_cols != columns))
+        {
+          change_frame_size (f, rows, columns, 0, 1, 0);
+          SET_FRAME_GARBAGED (f);
+          cancel_mouse_face (f);
+        }
-      change_frame_size (f, rows, columns, 0, 1, 0);
-      SET_FRAME_GARBAGED (f);
-      cancel_mouse_face (f);

Regards,
-- 
Daiki Ueno






  reply	other threads:[~2008-12-17  3:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-12  7:36 bug#1545: 23.0.60; scroll-bar-mode and fringe TAKAHASHI Naoto
2008-12-17  3:03 ` Daiki Ueno [this message]
2008-12-18 18:31   ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r647wlip.fsf@broken.deisui.org \
    --to=ueno@unixuser.org \
    --cc=1545@emacsbugs.donarmstrong.com \
    --cc=jan.h.d@swipnet.se \
    --cc=ntakahas@duron.m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).