unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kevin Ryde <user42@zip.com.au>
To: bug-gnu-emacs@gnu.org
Subject: bug#4740: 23.1; two error re-signals
Date: Sat, 17 Oct 2009 10:18:19 +1100	[thread overview]
Message-ID: <87r5t3rkqs.fsf@blah.blah> (raw)

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Below is untested.  Of course never-executed code isn't worth the bits
its written in, but I've got no idea how to reach either spot.  I see
other similar things doing signal instead of apply -- is that right?

2009-10-16  Kevin Ryde  <user42@zip.com.au>

	* ibuffer.el (ibuffer-confirm-operation-on),
	cedet/semantic/wisent.el (wisent-parse-stream):
	Fix error re-signal, err is a pair not a list so can't use `apply'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ibuffer.el.signal-error.diff --]
[-- Type: text/x-diff, Size: 422 bytes --]

--- ibuffer.el.~1.117.~	2009-10-02 10:23:54.000000000 +1000
+++ ibuffer.el	2009-10-17 10:10:46.000000000 +1100
@@ -1191,7 +1191,7 @@
 				  ;; This definitely falls in the
 				  ;; ghetto hack category...
 				  (not (string-match "too small" (cadr err)))))
-			 (apply #'signal err)
+			 (signal (car err) (cdr err))
 		       (enlarge-window 3))))))
 	      (select-window (next-window))
 	      (switch-to-buffer buf)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: wisent.el.signal-error.diff --]
[-- Type: text/x-diff, Size: 561 bytes --]

--- wisent.el.~1.5.~	2009-10-08 11:00:26.000000000 +1100
+++ wisent.el	2009-10-16 11:27:58.000000000 +1100
@@ -232,7 +232,7 @@
                                     (error-message-string error-to-filter))
                            (message "wisent-parse-max-stack-size \
 might need to be increased"))
-                       (apply 'signal error-to-filter))))))
+                       (signal (car error-to-filter) (cdr error-to-filter)))))))
     ;; Manage returned lookahead token
     (if wisent-lookahead
         (if (eq (caar la-elt) wisent-lookahead)

[-- Attachment #4: Type: text/plain, Size: 732 bytes --]



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

             reply	other threads:[~2009-10-16 23:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <878wf8mh0p.fsf@blah.blah>
2009-10-16 23:18 ` Kevin Ryde [this message]
2009-10-17  2:18   ` bug#4740: 23.1; two error re-signals Stefan Monnier
2009-10-18 23:20   ` bug#4740: marked as done (23.1; two error re-signals) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r5t3rkqs.fsf@blah.blah \
    --to=user42@zip.com.au \
    --cc=4740@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).