* bug#6164: 24.0.50; scroll-all-mode is broken
@ 2010-05-10 21:51 Stephen Berman
2010-05-10 23:19 ` Juri Linkov
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Berman @ 2010-05-10 21:51 UTC (permalink / raw)
To: 6164
1. emacs -Q
2. Visit two files that are big enough to scroll up and down.
3. Type `C-x 2' or `C-x 3' and the `C-x b' to display the two visited
filed in the split windows.
4. Type `M-x scroll-all-mode' to enable this minor mode.
5. Type `C-v'.
=> Only the selected buffer scrolls, whereas with scroll-all-mode
enabled both buffers should scroll.
This is because `C-v' is bound to scroll-up-command, whereas
scroll-all-mode expects (in scroll-all-check-to-scroll) scroll-up. I
guess this is a consequence of this change:
2010-04-05 Juri Linkov <juri@jurta.org>
Scrolling commands which do not signal errors at top/bottom.
http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01452.html
* simple.el (scroll-up-command, scroll-down-command): New commands.
In GNU Emacs 24.0.50.2 (i686-pc-linux-gnu, GTK+ Version 2.18.6)
of 2010-05-08 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.10605000
configured using `configure '--without-toolkit-scroll-bars''
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6164: 24.0.50; scroll-all-mode is broken
2010-05-10 21:51 bug#6164: 24.0.50; scroll-all-mode is broken Stephen Berman
@ 2010-05-10 23:19 ` Juri Linkov
2010-05-11 7:53 ` Stephen Berman
0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2010-05-10 23:19 UTC (permalink / raw)
To: Stephen Berman; +Cc: 6164
> 1. emacs -Q
> 2. Visit two files that are big enough to scroll up and down.
> 3. Type `C-x 2' or `C-x 3' and the `C-x b' to display the two visited
> filed in the split windows.
> 4. Type `M-x scroll-all-mode' to enable this minor mode.
> 5. Type `C-v'.
> => Only the selected buffer scrolls, whereas with scroll-all-mode
> enabled both buffers should scroll.
Thanks for the bug report. This patch should fix it:
=== modified file 'lisp/scroll-all.el'
--- lisp/scroll-all.el 2010-01-13 08:35:10 +0000
+++ lisp/scroll-all.el 2010-05-10 23:18:25 +0000
@@ -90,9 +90,9 @@ (defun scroll-all-check-to-scroll ()
(call-interactively 'scroll-all-scroll-down-all))
((eq this-command 'previous-line)
(call-interactively 'scroll-all-scroll-up-all))
- ((eq this-command 'scroll-up)
+ ((memq this-command '(scroll-up scroll-up-command))
(call-interactively 'scroll-all-page-down-all))
- ((eq this-command 'scroll-down)
+ ((memq this-command '(scroll-down scroll-down-command))
(call-interactively 'scroll-all-page-up-all))
((eq this-command 'beginning-of-buffer)
(call-interactively 'scroll-all-beginning-of-buffer-all))
--
Juri Linkov
http://www.jurta.org/emacs/
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6164: 24.0.50; scroll-all-mode is broken
2010-05-10 23:19 ` Juri Linkov
@ 2010-05-11 7:53 ` Stephen Berman
2010-05-11 19:49 ` Juri Linkov
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Berman @ 2010-05-11 7:53 UTC (permalink / raw)
To: Juri Linkov; +Cc: 6164
On Tue, 11 May 2010 02:19:20 +0300 Juri Linkov <juri@jurta.org> wrote:
>> 1. emacs -Q
>> 2. Visit two files that are big enough to scroll up and down.
>> 3. Type `C-x 2' or `C-x 3' and the `C-x b' to display the two visited
>> filed in the split windows.
>> 4. Type `M-x scroll-all-mode' to enable this minor mode.
>> 5. Type `C-v'.
>> => Only the selected buffer scrolls, whereas with scroll-all-mode
>> enabled both buffers should scroll.
>
> Thanks for the bug report. This patch should fix it:
Confirmed, so please install it at your convenience. Thanks,
Steve Berman
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6164: 24.0.50; scroll-all-mode is broken
2010-05-11 7:53 ` Stephen Berman
@ 2010-05-11 19:49 ` Juri Linkov
0 siblings, 0 replies; 4+ messages in thread
From: Juri Linkov @ 2010-05-11 19:49 UTC (permalink / raw)
To: 6164-done
>>> 1. emacs -Q
>>> 2. Visit two files that are big enough to scroll up and down.
>>> 3. Type `C-x 2' or `C-x 3' and the `C-x b' to display the two visited
>>> filed in the split windows.
>>> 4. Type `M-x scroll-all-mode' to enable this minor mode.
>>> 5. Type `C-v'.
>>> => Only the selected buffer scrolls, whereas with scroll-all-mode
>>> enabled both buffers should scroll.
>>
>> Thanks for the bug report. This patch should fix it:
>
> Confirmed, so please install it at your convenience. Thanks,
Installed and closed, thanks.
--
Juri Linkov
http://www.jurta.org/emacs/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-11 19:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-10 21:51 bug#6164: 24.0.50; scroll-all-mode is broken Stephen Berman
2010-05-10 23:19 ` Juri Linkov
2010-05-11 7:53 ` Stephen Berman
2010-05-11 19:49 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).