From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: bug-gnu-emacs@gnu.org
Subject: bug#7040: 24.0.50; tramp-handle-directory-files is not loaded
Date: Thu, 16 Sep 2010 23:19:40 +0200 [thread overview]
Message-ID: <87r5gtz8r7.fsf@tux.homenetwork> (raw)
In-Reply-To: <87lj71bdm6.fsf@gmx.de> (Michael Albinus's message of "Thu, 16 Sep 2010 23:08:33 +0200")
Michael Albinus <michael.albinus@gmx.de> writes:
> Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
>
>>> Oops, it is not recommended to call `tramp-handle-*' functions directly
>>> (you would bypass locking mechanisms).
>>
>> Yes, but i don't call this function directly, i just inline the actual
>> tramp-handle-directory-files to allow users of old tramp/emacs version
>> to use this version of the function that fix ".", "..", and sorting
>> (what we have fixed some months ago).
>>
>> At first it was inlined inside a function with a flet, but i realized
>> that it is not called when i copy/rename, etc.. files, so it is now
>> (re)defined as defun.
>>
>> I think the definition inlined in flet was confusing tramp.
>
> Maybe the best solution is defadvice. Then you don't need to redefine
> Tramp's internals (and you are independent from further changes in that
> function).
Well, i don't like defadvice, so i will see if i maintain this as
emacs23.2 is a stable emacs version.
Thank you anyway for your help and advices.
>> I have now tried in emacs -Q (so without anything) and copy recursively
>> from remote work fine.
>>
>>> With recent Tramp 2.2, those
>>> functions have been moved to another package. Likely, that's why you
>>> don't see them. Instead of, call
>>>
>>> (tramp-file-name-handler 'directory-files ...)
>>
>> Ok thanks, that's good to know, but as said above i don't use
>> tramp-handle-directory-files directly, i let tramp do the job.
>>
>> Sorry for the noise, but things are clearer now, thanks ;-)
>
> So we can close the bug report?
Yes.
> Best regards, Michael.
>
--
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2010-09-16 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 6:32 bug#7040: 24.0.50; tramp-handle-directory-files is not loaded Thierry Volpiatto
2010-09-16 8:35 ` Michael Albinus
2010-09-16 9:59 ` Thierry Volpiatto
2010-09-16 10:14 ` Michael Albinus
2010-09-16 17:06 ` Thierry Volpiatto
2010-09-16 21:08 ` Michael Albinus
2010-09-16 21:19 ` Thierry Volpiatto [this message]
2010-09-17 20:53 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5gtz8r7.fsf@tux.homenetwork \
--to=thierry.volpiatto@gmail.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).