From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#6963: More usecases, patch attached Date: Sat, 02 Oct 2010 20:00:52 -0400 Message-ID: <87r5g8i1qj.fsf@stupidchicken.com> References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1286064707 12441 80.91.229.12 (3 Oct 2010 00:11:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Oct 2010 00:11:47 +0000 (UTC) Cc: 6963@debbugs.gnu.org, Wolfgang Schnerring To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 03 02:11:45 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P2CB5-0001YZ-1M for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Oct 2010 02:11:43 +0200 Original-Received: from localhost ([127.0.0.1]:60774 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P2CB4-0000O1-6j for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Oct 2010 20:11:42 -0400 Original-Received: from [140.186.70.92] (port=52927 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P2CAy-0000Nv-25 for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2010 20:11:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P2CAx-000111-1Z for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2010 20:11:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P2CAw-00010x-Ua for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2010 20:11:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P2Bxp-0007Qb-W7; Sat, 02 Oct 2010 19:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Oct 2010 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128606387328547 (code B ref 6963); Sat, 02 Oct 2010 23:58:01 +0000 Original-Received: (at 6963) by debbugs.gnu.org; 2 Oct 2010 23:57:53 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2Bxh-0007QO-3C for submit@debbugs.gnu.org; Sat, 02 Oct 2010 19:57:53 -0400 Original-Received: from pantheon-po24.its.yale.edu ([130.132.50.118]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2Bxf-0007QJ-S8 for 6963@debbugs.gnu.org; Sat, 02 Oct 2010 19:57:52 -0400 Original-Received: from furry (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po24.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o9300rTp001109 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 2 Oct 2010 20:00:53 -0400 Original-Received: by furry (Postfix, from userid 1000) id 113A8C018; Sat, 2 Oct 2010 20:00:53 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Thu, 30 Sep 2010 03:52:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 02 Oct 2010 19:58:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40650 Archived-At: Juanma Barranquero writes: > 1) The emacs server sends -error XXX, and closes the connection. > emacsclient prints the error and exits. > 2) The emacs server sends an unknown command; emacsclient prints an > error and continues. > > With your patch, the case 2) would return EXIT_FAILURE (or the new > exit code we discussed) even if subsequent commands are dealt with > correctly. > > IIRC, receiving an unknown command from Emacs shouldn't be a fatal > error; it can happen if you use an older emacsclient to connect to a > more recent server.el with new functionality. Or should it? I agree, the second case should not lead to EXIT_FAILURE. I've checked the patch, with this and a couple of other corrections, into the trunk.