From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#7548: [FIXED] bookmark-default-handler wrong documentation Date: Wed, 08 Dec 2010 03:12:51 -0500 Message-ID: <87r5dsd6nw.fsf@red-bean.com> References: Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1291796151 31905 80.91.229.12 (8 Dec 2010 08:15:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Dec 2010 08:15:51 +0000 (UTC) To: 7548-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 08 09:15:47 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PQFBi-0000UR-Ij for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Dec 2010 09:15:47 +0100 Original-Received: from localhost ([127.0.0.1]:48684 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQFBh-0004OI-Bj for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Dec 2010 03:15:45 -0500 Original-Received: from [140.186.70.92] (port=58659 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQFBX-0004NF-JL for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 03:15:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQFBW-0002am-BP for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 03:15:35 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQFBW-0002ai-9v for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 03:15:34 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PQF3G-0000sl-VL for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 03:07:02 -0500 In-Reply-To: Resent-From: Karl Fogel Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2010 08:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 7548@debbugs.gnu.org, kfogel@red-bean.com Original-Received: via spool by 7548-done@debbugs.gnu.org id=D7548.12917956183380 (code D ref 7548); Wed, 08 Dec 2010 08:07:02 +0000 Original-Received: (at 7548-done) by debbugs.gnu.org; 8 Dec 2010 08:06:58 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQF3C-0000sT-91 for submit@debbugs.gnu.org; Wed, 08 Dec 2010 03:06:58 -0500 Original-Received: from osh-net-219-98.onshore.net ([66.146.219.98] helo=sanpietro.red-bean.com) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQF39-0000sD-Mp for 7548-done@debbugs.gnu.org; Wed, 08 Dec 2010 03:06:56 -0500 Original-Received: from localhost ([127.0.0.1]:53307 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.72) (envelope-from ) id 1PQF8u-000428-Am for 7548-done@debbugs.gnu.org; Wed, 08 Dec 2010 02:12:52 -0600 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 08 Dec 2010 03:07:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42287 Archived-At: Thanks, Leo and Theirry. Fixed in bzr rev 102609. Specifically: ------------------------------------------------------------ revno: 102609 revision-id: kfogel@red-bean.com-20101208080927-5j9jqnb2xvcw4ogm parent: rgm@gnu.org-20101208050012-qhxovv7ey54v8w3h committer: Karl Fogel branch nick: trunk timestamp: Wed 2010-12-08 03:09:27 -0500 message: Adjust parameter names and doc strings to resolve confusion over whether "bookmark" meant a bookmark name or a bookmark record. Along the way, shorten one function's name for similar reasons. (Issue #7548) * lisp/bookmark.el (bookmark-name-from-record): New name for `bookmark-name-from-full-record'. All callers changed. (bookmark-get-bookmark, bookmark-get-bookmark-record, bookmark-default-annotation-text, bookmark-prop-get, bookmark-prop-set, bookmark-get-annotation, bookmark-set-annotation, bookmark-get-filename, bookmark-set-filename, bookmark-get-position, bookmark-set-position, bookmark-get-front-context-string, bookmark-set-front-context-string, bookmark-get-rear-context-string, bookmark-set-rear-context-string, bookmark-get-handler, bookmark-edit-annotation, bookmark--jump-via, bookmark-handle-bookmark, bookmark-location, bookmark-show-annotation): Rename `bookmark' parameter to `bookmark-name-or-record', to clearly show its role, and shorten or adjust doc strings accordingly. (bookmark-set-name): Same, and pass the parameter directly to `bookmark-get-bookmark' instead of redundantly doing the callee's work. (bookmark-default-annotation-text, bookmark-send-edited-annotation, bookmark-relocate, bookmark-insert-location, bookmark-insert, bookmark-delete): Rename `bookmark' parameter to `bookmark-name', and in some cases shorten doc string accordingly. (bookmark-rename): Change `old' and `new' parameters to `old-name' and `new-name', and adjust an internal variable to avoid confusion. (bookmark-jump, bookmark-jump-noselect): Clarify `bookmark' parameter in doc string. modified: lisp/ChangeLog changelog-20091113204419-o5vbwnq5f7feedwu-1432 lisp/bookmark.el bookmark.el-20091113204419-o5vbwnq5f7feedwu-621 ------------------------------------------------------------