From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#1779: 23.0.60; proced with variable-pitch header line Date: Tue, 19 Jul 2011 23:24:26 +0200 Message-ID: <87r55motf9.fsf@escher.fritz.box> References: <873afzcwdi.fsf@cyd.mit.edu> <877hfnajcm.fsf@escher.home> <871v5tsw5q.fsf@escher.home> <8739i72r0o.fsf@escher.fritz.box> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1311110747 24119 80.91.229.12 (19 Jul 2011 21:25:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2011 21:25:47 +0000 (UTC) Cc: Chong Yidong , 1779@debbugs.gnu.org To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 23:25:42 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QjHnS-0002PY-Cq for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2011 23:25:42 +0200 Original-Received: from localhost ([::1]:56558 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjHnQ-0005B5-FB for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2011 17:25:40 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:37305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjHmv-00056P-1T for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2011 17:25:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjHmp-0003wa-1R for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2011 17:25:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjHmo-0003wV-Mg for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2011 17:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QjHmn-000566-N6; Tue, 19 Jul 2011 17:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2011 21:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 1779-submit@debbugs.gnu.org id=B1779.131111068219568 (code B ref 1779); Tue, 19 Jul 2011 21:25:01 +0000 Original-Received: (at 1779) by debbugs.gnu.org; 19 Jul 2011 21:24:42 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QjHmT-00055Z-0x for submit@debbugs.gnu.org; Tue, 19 Jul 2011 17:24:41 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1QjHmM-00055I-Nq for 1779@debbugs.gnu.org; Tue, 19 Jul 2011 17:24:39 -0400 Original-Received: (qmail invoked by alias); 19 Jul 2011 21:24:27 -0000 Original-Received: from i59F5423D.versanet.de (EHLO escher.home) [89.245.66.61] by mail.gmx.net (mp048) with SMTP; 19 Jul 2011 23:24:27 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1/qmzFqpjHqayYFrLvmofcO5mphgqU9E7wmB/KM66 qgqZ/guu73Pu1J Original-Received: by escher.home (Postfix, from userid 1000) id D838B5F912; Tue, 19 Jul 2011 23:24:26 +0200 (CEST) In-Reply-To: <8739i72r0o.fsf@escher.fritz.box> (Stephen Berman's message of "Fri, 15 Jul 2011 23:05:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 19 Jul 2011 17:25:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:49450 Archived-At: On Fri, 15 Jul 2011 23:05:59 +0200 Stephen Berman wrote: > On Fri, 15 Jul 2011 19:54:11 +0200 Lars Magne Ingebrigtsen wrote: > >> Stefan Monnier writes: >> >>> I guess lack of time. I don't think I agree with the change to the face >>> definition, but the part of the code that adds :align-to properties to >>> the spaces looks fine. >> >> Stephen, could you send an updated patch with just the :align-to >> properties? (If that makes any sense. :-) I'm not familiar enough >> with the code to know whether that would be an improvement or not >> without the other bits in the patch.) > > Sure. I'll do it as soon as I can, but I probably won't have time until > Monday or Tuesday. The patch is below. The only change I made from the previous patch (aside from leaving out the face change) is to omit the comment from buff-menu.el about assuming fixed-pitch, since obviously we aren't making that assumption (though it's true that :align-to works best with fixed-pitch, but still I definitely think it's an improvement). Steve Berman *** /home/steve/bzr/emacs/trunk/lisp/proced.el 2011-07-08 15:13:26.000000000 +0200 --- /home/steve/bzr/emacs/quickfixes/lisp/proced.el 2011-07-19 23:06:48.000000000 +0200 *************** *** 1509,1514 **** --- 1509,1524 ---- (if (string-match "[ \t]+$" proced-header-line) (setq proced-header-line (substring proced-header-line 0 (match-beginning 0)))) + (setq proced-header-line (concat " " proced-header-line)) + ;; From buff-menu.el: Turn whitespace chars in the header into + ;; stretch specs so they work regardless of the header-line face. + (let ((pos 0) + (header proced-header-line)) + (while (string-match "[ \t\n]+" header pos) + (setq pos (match-end 0)) + (put-text-property (match-beginning 0) pos 'display + (list 'space :align-to pos) + header))) ;; (delete-trailing-whitespace) (goto-char (point-min)) (while (re-search-forward "[ \t\r]+$" nil t) *************** *** 1602,1608 **** (while (not (eobp)) (insert " ") (forward-line)) - (setq proced-header-line (concat " " proced-header-line)) (if revert (set-buffer-modified-p nil)) ;; set `goal-column' --- 1612,1617 ----