From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Mon, 16 Jan 2012 09:58:10 +0100 Message-ID: <87r4z0yqfx.fsf@gmail.com> References: <87mx9su32g.fsf@web.de> <8362ggkquq.fsf@gnu.org> <87lipcrlga.fsf@gmail.com> <87fwfkc4pn.fsf@gmx.de> <87fwfjsw8t.fsf@gmail.com> <87aa5rdazl.fsf@gmx.de> <87d3anogf5.fsf@gmail.com> <011AEED9E81C4DEFA6B1E03B0F57F28F@us.oracle.com> <878vlbljnc.fsf@gmx.de> <8739bj8mu1.fsf@gmail.com> <87fwfjo24c.fsf@gmx.de> <87pqen76p4.fsf@gmail.com> <83fwfik92e.fsf@gnu.org> <87mx9q1sz7.fsf@gmail.com> <87vcodm8ns.fsf@gmx.de> <87pqekopb5.fsf@gmail.com> <87hazwoost.fsf@gmail.com> <87ty3w9639.fsf@gmx.de> <8762gckckt.fsf@gmail.com> <87pqek9269.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326704367 24847 80.91.229.12 (16 Jan 2012 08:59:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 16 Jan 2012 08:59:27 +0000 (UTC) Cc: 10489@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 16 09:59:23 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RmiPQ-0000m0-5q for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 09:59:20 +0100 Original-Received: from localhost ([::1]:38677 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmiPP-0000qz-Nm for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 03:59:19 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:48109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmiPH-0000pZ-5r for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 03:59:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmiPG-0000OG-6a for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 03:59:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmiPG-0000O8-3e for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 03:59:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RmiQ6-00084J-RY for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 04:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jan 2012 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.132670435330934 (code B ref 10489); Mon, 16 Jan 2012 09:00:02 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 16 Jan 2012 08:59:13 +0000 Original-Received: from localhost ([127.0.0.1]:59143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmiPI-00082r-Nj for submit@debbugs.gnu.org; Mon, 16 Jan 2012 03:59:12 -0500 Original-Received: from mail-ww0-f46.google.com ([74.125.82.46]:47274) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmiPG-00082j-6n for 10489@debbugs.gnu.org; Mon, 16 Jan 2012 03:59:11 -0500 Original-Received: by wgbdt14 with SMTP id dt14so1107455wgb.15 for <10489@debbugs.gnu.org>; Mon, 16 Jan 2012 00:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=xPDIkPRFI9tK31TEN1teWJPzIxQxhVCiZnYfycEqBKE=; b=bAvrfajfo39BH/U05h0mBiLgkAIZJ+fifXo0dnb0xVrrcb24usVq4eTKsSg471zUc2 lwurh3PDGoJwKGQU7Muj+f6ORVTvqQDomdUrK9CGBs5fLi9+d1cOjhqar5dM6B7XQjgR 0nQANmp8z/xFkM66KfKuYPWX4jI6EQY2LDboI= Original-Received: by 10.180.81.72 with SMTP id y8mr18043471wix.14.1326704296425; Mon, 16 Jan 2012 00:58:16 -0800 (PST) Original-Received: from thierry-MM061 (3.211.85.79.rev.sfr.net. [79.85.211.3]) by mx.google.com with ESMTPS id ga4sm21417505wbb.4.2012.01.16.00.58.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Jan 2012 00:58:14 -0800 (PST) In-Reply-To: <87pqek9269.fsf@gmx.de> (Michael Albinus's message of "Sun, 15 Jan 2012 20:49:18 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55779 Archived-At: Michael Albinus writes: > Thierry Volpiatto writes: > >> IMHO we should fix this bug for most use cases with a compare function >> maybe not perfect in many points but ok for most basic usages. >> The function shown by Drew and I put in last patch as you said isn't >> sufficient and fail in many cases even on local filesystem: >> >> (defun bmkp-same-file-p (file1 file2) >> "Return non-nil if FILE1 and FILE2 name the same file. >> If either name is not absolute, then it is expanded relative to >> `default-directory' for the test." >> (and (equal (file-remote-p file1) (file-remote-p file2)) >> (string= (file-truename (expand-file-name file1)) >> (file-truename (expand-file-name file2))))) >> >> (bmkp-same-file-p "~/Test" "/home/thierry/Test/") => nil > > So it must be > > (string= (directory-file-name (file-truename (expand-file-name file1))) > (directory-file-name (file-truename (expand-file-name file2)))))) So, any objections to apply my patch to trunk with these changes? -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997