From: Kenichi Handa <handa@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 13084@debbugs.gnu.org
Subject: bug#13084: boyer_moore crashes with certain characters in the case table
Date: Thu, 13 Dec 2012 22:39:29 +0900 [thread overview]
Message-ID: <87r4mu6pgu.fsf@gnu.org> (raw)
In-Reply-To: <831uewa9cq.fsf@gnu.org> (message from Eli Zaretskii on Tue, 11 Dec 2012 17:37:09 +0200)
In article <831uewa9cq.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
> In addition, I'd suggest that Handa-san (or someone else) takes a good
> look at the code that sets up the simple_translate table in
> boyer_moore, because the constants there, like 0200 and 0x3F, and all
> the talk about characters that belong "to the same charset and row"
> smell of pre-Unicode (a.k.a. "MULE") representation of characters.
> For now, I disabled boyer_moore for unibyte characters beyond 160,
> because my reading of the code is that simple_translate and the
> supporting code cannot handle that. Maybe I'm wrong.
I have not yet checked the code, but what I remember is that
search_buffer checks the search string and decides which to
use; boyer_moore or simple_search. If all equivalent
characters of all non-ASCII characters in the search string
are in the same character group, we can use boyer_moore.
Here, A and B belongs to the same character group iff A and
B has the same multibyte sequence except for the last byte.
In this condition, we should be able to use the table
simple_translate.
---
Kenichi Handa
handa@gnu.org
next prev parent reply other threads:[~2012-12-13 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 0:34 bug#13084: boyer_moore crashes with certain characters in the case table Juri Linkov
2012-12-11 15:37 ` Eli Zaretskii
2012-12-11 23:17 ` Juri Linkov
2012-12-12 3:55 ` Eli Zaretskii
2012-12-12 9:27 ` Juri Linkov
2012-12-12 10:21 ` martin rudalics
2012-12-12 10:31 ` Juri Linkov
2012-12-12 12:43 ` martin rudalics
2012-12-12 16:47 ` Eli Zaretskii
2012-12-12 23:05 ` Juri Linkov
2012-12-13 13:39 ` Kenichi Handa [this message]
2012-12-13 17:32 ` Eli Zaretskii
2012-12-15 13:17 ` Kenichi Handa
2012-12-15 13:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4mu6pgu.fsf@gnu.org \
--to=handa@gnu.org \
--cc=13084@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).