From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#15648: 24.2.50; gnutls SSL connection to IMAP server causes emacs to crash completely Date: Mon, 04 Nov 2013 13:05:40 -0500 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <87r4awqbyj.fsf@flea.lifelogs.com> References: <21089.32240.198931.971000@consult.pretender> <87fvrun1pw.fsf@flea.lifelogs.com> <21093.32992.278229.646703@consult.pretender> <877gd5mo5x.fsf@flea.lifelogs.com> <21094.39055.449629.706850@consult.pretender> <21094.40085.664080.69561@consult.pretender> <21094.52645.645440.977584@consult.pretender> <21094.64459.131668.849138@consult.pretender> <21095.19949.639350.970770@consult.pretender> <83wql4hvam.fsf@gnu.org> <21096.920.835718.562924@consult.pretender> <83hac7j2a2.fsf@gnu.org> <21097.58066.940940.323995@consult.pretender> <83iowlh27q.fsf@gnu.org> <87eh79ico2.fsf_-_@flea.lifelogs.com> <83a9hxgpt1.fsf@gnu.org> <8738ncru9y.fsf@flea.lifelogs.com> <83ppqg85av.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383588373 12970 80.91.229.3 (4 Nov 2013 18:06:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Nov 2013 18:06:13 +0000 (UTC) Cc: emacs@kosowsky.org, 15648@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 04 19:06:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VdOXY-0000GG-7X for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Nov 2013 19:06:16 +0100 Original-Received: from localhost ([::1]:51350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdOXX-0004lc-LM for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Nov 2013 13:06:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdOXP-0004lS-35 for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 13:06:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdOXK-0002Cp-6T for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 13:06:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdOXK-0002Ck-2n for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 13:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VdOXJ-0001gP-LG for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 13:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Nov 2013 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15648-submit@debbugs.gnu.org id=B15648.13835883156394 (code B ref 15648); Mon, 04 Nov 2013 18:06:01 +0000 Original-Received: (at 15648) by debbugs.gnu.org; 4 Nov 2013 18:05:15 +0000 Original-Received: from localhost ([127.0.0.1]:34491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdOWY-0001f4-D4 for submit@debbugs.gnu.org; Mon, 04 Nov 2013 13:05:14 -0500 Original-Received: from mail-qa0-f42.google.com ([209.85.216.42]:46528) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdOWW-0001eq-JB for 15648@debbugs.gnu.org; Mon, 04 Nov 2013 13:05:13 -0500 Original-Received: by mail-qa0-f42.google.com with SMTP id i13so305896qae.1 for <15648@debbugs.gnu.org>; Mon, 04 Nov 2013 10:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=7ugDXusDPhZYif4VNBwWc0BPXFOmpXIIx4uMnKU8hzc=; b=AZPy/BNLhoj6mY4hgS/7vzOYJFIfTSqm1i2IDrngW2aDkFS0mxRJhKmT/+OwLzs7Ov UdLggPE8r4EffR6JcPiDch/PVN+/mwQHQGO8AKAwt9heHs15NG4N1oc3pcLizqvbPZUF LCHr91TCP8UYKuFNlbtGXbmVeMelZvb87FXRs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=7ugDXusDPhZYif4VNBwWc0BPXFOmpXIIx4uMnKU8hzc=; b=GsuyzP2iPtfAFYOIjifLnY03ftKOtuYOiVk4J838LnAafIqyMMg9qDa56mvxJztDoX vktySwX6V7sbQl5egCnGTh0+tIh3+XxbsOICoSICA9EGO80MjE+egMgkFsDQB/Lz+adx B6Qlw9IswioKWWvBe19dAqmAsUclIpuz4aP4W66FewFJHOkk2w1xz8hNaNM+pzVoFs0p D60HUovEpNSLWoBJe1A5hkOtaEkUZ5CN0tEaidHPTVbjPv0skrQCRcQ0S/tU9Xw0NisP w28dQ4qhcmyI478IfuWHHcqnPln+zc700Q2uCAG4Nm7lGaSvS32rKfbMXjPiahYtqJZq lCww== X-Gm-Message-State: ALoCoQl2sKTO7Wmh6zf51oWCpsE9TMQeeM1sS39dLJ5iNcbQbsLuqeksLf5u/oWzCJo7J/H6XL8T X-Received: by 10.224.161.146 with SMTP id r18mr23719349qax.57.1383588306721; Mon, 04 Nov 2013 10:05:06 -0800 (PST) Original-Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id k2sm57293742qan.8.2013.11.04.10.05.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Nov 2013 10:05:06 -0800 (PST) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83ppqg85av.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 04 Nov 2013 19:06:48 +0200") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79986 Archived-At: On Mon, 04 Nov 2013 19:06:48 +0200 Eli Zaretskii wrote: >> From: Ted Zlatanov >> Cc: emacs@kosowsky.org, 15648@debbugs.gnu.org >> Date: Mon, 04 Nov 2013 11:44:41 -0500 >> EZ> If so, perhaps the problem is that we leave the process object EZ> marked as a GnuTLS process, but with a NULL state? Should we remove EZ> the mark, or maybe delete the process object in gnutls-negotiate? >> >> >> >> I would abort with a message like any other error. >> EZ> Maybe you should install a change that does that, and see if it solves EZ> the problem. >> >> You mean like this? EZ> Something like that, yes. >> Should I have a special check for "gnutls_p is set but gnutls_state >> is NULL"? EZ> That's what this patch does, doesn't it? Or did I misunderstand you? The process.c change checks that "gnutls_p is set and gnutls_state is not NULL" but wouldn't make a note of the case where gnutls_state got set to NULL somehow. I meant to have a special check for that case and maybe issue a message... but it seems a bit like overkill. >> You're absolutely right. Can you check if this patch is good? It looks >> OK to me. EZ> It compiles fine. But since I cannot reproduce the original problem, EZ> I'd ask the OP to please see if this fixes that problem. Right, I needed your review to ensure I was not missing something :) OP, can you please try my patch? Ted