unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 16116@debbugs.gnu.org, Steve Purcell <steve@sanityinc.com>
Subject: bug#16116: 24.3.50; smie-indent-close aligns inner closing paren with the outer opening paren
Date: Sat, 14 Dec 2013 20:25:29 +0200	[thread overview]
Message-ID: <87r49fe1d2.fsf@yandex.ru> (raw)
In-Reply-To: <jwv61qrzc1w.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Sat, 14 Dec 2013 10:32:43 -0500")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> That's exactly what I'm suggesting, yes.

So, call `smie-indent--rule' from `smie-indent-close'? That should work.

>> I thought rather to add a defvar to switch between the two behaviors in
>> smie-indent-close,
>
> That could be acceptable, tho so far all the indentation is controlled
> by the rules-function, so it makes sense to keep it that way rather than
> to introduce a variable.

Maybe so.

> Also, if it's done in the rules-function, the
> function may return different results depending on context.

True, but so far I don't see a situation in Ruby where it'd depend on
the context.

>> or make smie-indent-functions buffer-local and replace
>> smie-indent-close there with a modified implementation.
>
> This approach would work if the requirement is very specific to one
> particular major mode, but in this case, it seems to be a fairly
> common one.

I believe this argument also works against doing it in the rules
function, and in favor of adding a defvar.





  reply	other threads:[~2013-12-14 18:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  1:57 bug#16116: 24.3.50; smie-indent-close aligns inner closing paren with the outer opening paren Dmitry Gutov
2013-12-12 12:55 ` Stefan Monnier
2013-12-12 16:30   ` Dmitry Gutov
2013-12-14  8:23 ` Steve Purcell
2013-12-14 14:13   ` Stefan Monnier
2013-12-14 15:04     ` Dmitry Gutov
2013-12-14 15:32       ` Stefan Monnier
2013-12-14 18:25         ` Dmitry Gutov [this message]
2013-12-15  1:50           ` Stefan Monnier
2013-12-15  2:44             ` Dmitry Gutov
2013-12-15 13:00               ` Stefan Monnier
2013-12-15 23:22                 ` Dmitry Gutov
2013-12-16 14:23                   ` Stefan Monnier
2013-12-17  3:03                     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r49fe1d2.fsf@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=16116@debbugs.gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=steve@sanityinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).