From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Arne Babenhauserheide Newsgroups: gmane.emacs.bugs Subject: bug#13124: 24.1; shell-mode does not hide sudo password prompts Date: Thu, 16 Jan 2014 15:50:16 +0100 Message-ID: <87r4880ymv.wl%arne_bab@web.de> References: <87zk1owu6p.fsf@web.de> <1624103.WhpMEyUi7x@fluss> <2651799.fvDoQSk02G@fluss> <877gocj6rn.fsf@gnu.org> <87k3sbjyau.fsf@gnu.org> <87txrfsd0y.fsf@gmx.de> <87k3s1fgv2.fsf@gnu.org> Reply-To: arne_bab@web.de NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1389883877 13128 80.91.229.3 (16 Jan 2014 14:51:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Jan 2014 14:51:17 +0000 (UTC) Cc: 13124@debbugs.gnu.org, Arne Babenhauserheide , Michael Albinus To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 16 15:51:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W3oHw-000805-Vb for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jan 2014 15:51:21 +0100 Original-Received: from localhost ([::1]:33128 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3oHw-00008T-KI for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jan 2014 09:51:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3oHm-0008ST-GB for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2014 09:51:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3oHf-00032W-3F for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2014 09:51:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3oHf-0002yf-0Y for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2014 09:51:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3oHe-0002sw-5p for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2014 09:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Arne Babenhauserheide Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2014 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13124 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13124-submit@debbugs.gnu.org id=B13124.138988382111037 (code B ref 13124); Thu, 16 Jan 2014 14:51:02 +0000 Original-Received: (at 13124) by debbugs.gnu.org; 16 Jan 2014 14:50:21 +0000 Original-Received: from localhost ([127.0.0.1]:53092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3oGy-0002ru-Ul for submit@debbugs.gnu.org; Thu, 16 Jan 2014 09:50:21 -0500 Original-Received: from mout.web.de ([212.227.17.12]:65470) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3oGw-0002ri-Vg for 13124@debbugs.gnu.org; Thu, 16 Jan 2014 09:50:19 -0500 Original-Received: from kaverne.draketo.de ([212.255.228.37]) by smtp.web.de (mrweb004) with ESMTPA (Nemesis) id 0Ly7vR-1VFmcG3Iyz-015Vb9 for <13124@debbugs.gnu.org>; Thu, 16 Jan 2014 15:50:18 +0100 In-Reply-To: <87k3s1fgv2.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 Emacs/24.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Provags-ID: V03:K0:Aa27B+UCN8545DhHaWmrbXz/b8ir15zwQPkuxQX1UkzuimqqgU9 UW+nCHIQthBzRoJhESeFuQRUzsOp85Xx2AGwQ36I+v/jRrg1e/c0BigFsCy+wkuEga70da8 J1RW/mmbYhaS8b/J66M7FJxUFrpxuTXBVMLwIsC+ht98BKDCUnPsoQ9pl304PMbfcukSqsY 0SWvT9U3kae60REOhV/4w== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83593 Archived-At: At Sat, 29 Dec 2012 15:38:09 +0800, Hi, Chong Yidong wrote: > Anyone have objections to the following patch? It introduces a new > option `password-word-equivalents' for this purpose. > ! "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)" For me this would fix the issue. I now applied something similar as variable, but I would much prefer to see it be the default: That would also solve the issue for a collegue of mine without me having to explain him how the regexp works. =20 > + (defcustom password-word-equivalents > + '("password" "passphrase" "pass phrase" > + "=D9=83=D9=84=D9=85=D8=A9 =D8=A7=D9=84=D8=B3=D8=B1" ; ar > + "=E0=A6=97=E0=A7=81=E0=A6=AA=E0=A7=8D=E0=A6=A4=E0=A6=B6=E0=A6=AC=E0= =A7=8D=E0=A6=A6" ; as > + "=E0=A6=AA=E0=A6=BE=E0=A6=B8=E0=A6=93=E0=A7=9F=E0=A6=BE=E0=A6=B0=E0= =A7=8D=E0=A6=A1" ; bn_IN > + "contrasenya" ; ca > + "heslo" ; cs > + "adgangskode" ; da > + "passwort" ; de > + "pasvorto" ; eo > + "contrase=C3=B1a" ; es > + "pasahitza" ; eu > + "salasana" ; fi > + "mot de passe" ; fr > + "=E0=AA=AA=E0=AA=BE=E0=AA=B8=E0=AA=B5=E0=AA=B0=E0=AB=8D=E0=AA=A1" = ; gu > + "=D7=A1=D7=A1=D7=9E=D7=94" ; he > + "=E0=A4=B6=E0=A4=AC=E0=A5=8D=E0=A4=A6=E0=A4=95=E0=A5=82=E0=A4=9F" = ; hi > + "lozinka" ; hr > + "Jelsz=C3=B3: " ; hu > + "=E3=83=91=E3=82=B9=E3=83=AF=E3=83=BC=E3=83=89" ; ja > + "=D0=9F=D0=B0=D1=80=D0=BE=D0=BB=D1=8C" ; kk > + "=E0=B2=97=E0=B3=81=E0=B2=AA=E0=B3=8D=E0=B2=A4=E0=B2=AA=E0=B2=A6" = ; kn > + "=EC=95=94=ED=98=B8" ; ko > + "=E1=9E=96=E1=9E=B6=E1=9E=80=E1=9F=92=E1=9E=99=E1=9E=9F=E1=9E=98=E1= =9F=92=E1=9E=84=E1=9E=B6=E1=9E=8F=E1=9F=8B" ; km > + "slapta=C5=BEodis" ; lt > + "=E0=B4=85=E0=B4=9F=E0=B4=AF=E0=B4=BE=E0=B4=B3=E0=B4=B5=E0=B4=BE=E0= =B4=95=E0=B5=8D=E0=B4=95=E0=B5=8D" ; ml > + "=E0=A4=97=E0=A5=81=E0=A4=AA=E0=A5=8D=E0=A4=A4=E0=A4=B6=E0=A4=AC=E0= =A5=8D=E0=A4=A6" ; mr > + "passord" ; nb > + "wachtwoord" ; nl > + "=E0=AC=AA=E0=AD=8D=E0=AC=B0=E0=AC=AC=E0=AD=87=E0=AC=B6 =E0=AC=B8= =E0=AC=99=E0=AD=8D=E0=AC=95=E0=AD=87=E0=AC=A4" ; or > + "=E0=A8=AA=E0=A8=BE=E0=A8=B8=E0=A8=B5=E0=A8=B0=E0=A8=A1" ; pa > + "has=C5=82o" ; pl > + "senha" ; pt > + "=D0=9F=D0=B0=D1=80=D0=BE=D0=BB=D1=8C" ; ru > + "=E0=B6=BB=E0=B7=84=E0=B7=83=E0=B7=8A=E0=B6=B4=E0=B6=AF=E0=B6=BA" = ; si > + "Heslo" ; sk > + "geslo" ; sl > + "lozinka" ; sr > + "=D0=9B=D0=BE=D0=B7=D0=B8=D0=BD=D0=BA=D0=B0" ; sr > + "l=C3=B6senord" ; sv > + "=E0=AE=95=E0=AE=9F=E0=AE=B5=E0=AF=81=E0=AE=9A=E0=AF=8D=E0=AE=9A=E0= =AF=8A=E0=AE=B2=E0=AF=8D" ; ta > + "=E0=B0=B8=E0=B0=82=E0=B0=95=E0=B1=87=E0=B0=A4=E0=B0=AA=E0=B0=A6=E0= =B0=AE=E0=B1=81" ; te > + "parola" ; tr > + "=D0=9F=D0=B0=D1=80=D0=BE=D0=BB=D1=8C" ; uk > + "M=E1=BA=ADt kh=E1=BA=A9u" ; vi > + "=E5=AF=86=E7=A0=81" ; zh_CN > + "=E5=AF=86=E7=A2=BC" ; zh_TW > + "iphasiwedi" ; zu > + ) > + "List of words equivalent to \"password\". > + This is used by Shell mode and other parts of Emacs to recognize > + password prompts, including prompts in languages other than > + English. Different case choices should not be assumed to be > + included; callers should bind `case-fold-search' to t." > + :type '(repeat string) > + :version "24.4" > + :group 'processes) Regarding the need to translate other parts of the password prompt (like "enter"), I think that those would be useful, but that the current fix is already a huge improvement, so it should not be held back by not being perfect right away. Should the :version keyword of defcustom for comint-password-prompt-regexp be set to 24.4, too? Best wishes, Arne PS: I=E2=80=99m sorry that I only answer now. I lost track of the issue and only now found it again when the bug finally disturbed me enough that I decided to fix it myself (I have a local fix, but it is not as nice as your fix). I now answered here again, because I saw no fix in the current trunk.