From: Arne Babenhauserheide <arne_bab@web.de>
To: Chong Yidong <cyd@gnu.org>
Cc: 13124@debbugs.gnu.org, Arne Babenhauserheide <arne_bab@web.de>,
Michael Albinus <michael.albinus@gmx.de>
Subject: bug#13124: 24.1; shell-mode does not hide sudo password prompts
Date: Thu, 16 Jan 2014 15:50:16 +0100 [thread overview]
Message-ID: <87r4880ymv.wl%arne_bab@web.de> (raw)
In-Reply-To: <87k3s1fgv2.fsf@gnu.org>
At Sat, 29 Dec 2012 15:38:09 +0800,
Hi,
Chong Yidong wrote:
> Anyone have objections to the following patch? It introduces a new
> option `password-word-equivalents' for this purpose.
> ! "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)"
For me this would fix the issue. I now applied something similar as
variable, but I would much prefer to see it be the default: That would
also solve the issue for a collegue of mine without me having to
explain him how the regexp works.
> + (defcustom password-word-equivalents
> + '("password" "passphrase" "pass phrase"
> + "كلمة السر" ; ar
> + "গুপ্তশব্দ" ; as
> + "পাসওয়ার্ড" ; bn_IN
> + "contrasenya" ; ca
> + "heslo" ; cs
> + "adgangskode" ; da
> + "passwort" ; de
> + "pasvorto" ; eo
> + "contraseña" ; es
> + "pasahitza" ; eu
> + "salasana" ; fi
> + "mot de passe" ; fr
> + "પાસવર્ડ" ; gu
> + "ססמה" ; he
> + "शब्दकूट" ; hi
> + "lozinka" ; hr
> + "Jelszó: " ; hu
> + "パスワード" ; ja
> + "Пароль" ; kk
> + "ಗುಪ್ತಪದ" ; kn
> + "암호" ; ko
> + "ពាក្យសម្ងាត់" ; km
> + "slaptažodis" ; lt
> + "അടയാളവാക്ക്" ; ml
> + "गुप्तशब्द" ; mr
> + "passord" ; nb
> + "wachtwoord" ; nl
> + "ପ୍ରବେଶ ସଙ୍କେତ" ; or
> + "ਪਾਸਵਰਡ" ; pa
> + "hasło" ; pl
> + "senha" ; pt
> + "Пароль" ; ru
> + "රහස්පදය" ; si
> + "Heslo" ; sk
> + "geslo" ; sl
> + "lozinka" ; sr
> + "Лозинка" ; sr
> + "lösenord" ; sv
> + "கடவுச்சொல்" ; ta
> + "సంకేతపదము" ; te
> + "parola" ; tr
> + "Пароль" ; uk
> + "Mật khẩu" ; vi
> + "密码" ; zh_CN
> + "密碼" ; zh_TW
> + "iphasiwedi" ; zu
> + )
> + "List of words equivalent to \"password\".
> + This is used by Shell mode and other parts of Emacs to recognize
> + password prompts, including prompts in languages other than
> + English. Different case choices should not be assumed to be
> + included; callers should bind `case-fold-search' to t."
> + :type '(repeat string)
> + :version "24.4"
> + :group 'processes)
Regarding the need to translate other parts of the password prompt
(like "enter"), I think that those would be useful, but that the
current fix is already a huge improvement, so it should not be held
back by not being perfect right away.
Should the :version keyword of defcustom for
comint-password-prompt-regexp be set to 24.4, too?
Best wishes,
Arne
PS: I’m sorry that I only answer now. I lost track of the issue and
only now found it again when the bug finally disturbed me enough that
I decided to fix it myself (I have a local fix, but it is not as nice
as your fix). I now answered here again, because I saw no fix in the
current trunk.
next prev parent reply other threads:[~2014-01-16 14:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 13:27 bug#13124: 24.1; shell-mode does not hide sudo password prompts Arne Babenhauserheide
2012-12-08 19:24 ` Glenn Morris
2012-12-10 16:21 ` Arne Babenhauserheide
2012-12-10 17:00 ` Glenn Morris
2012-12-11 0:12 ` Arne Babenhauserheide
2012-12-11 4:55 ` Glenn Morris
2012-12-11 13:42 ` Arne Babenhauserheide
2012-12-13 14:14 ` Kenichi Handa
2012-12-13 16:14 ` Arne Babenhauserheide
2012-12-18 19:54 ` Stefan Monnier
2012-12-21 5:47 ` Chong Yidong
2012-12-21 14:03 ` Stefan Monnier
2012-12-21 14:05 ` Chong Yidong
2012-12-21 14:19 ` Michael Albinus
2012-12-29 7:38 ` Chong Yidong
2012-12-29 8:39 ` Andreas Schwab
2012-12-29 10:22 ` Vitalie Spinu
2012-12-29 16:40 ` Michael Albinus
2014-01-16 14:50 ` Arne Babenhauserheide [this message]
2014-01-17 8:38 ` Michael Albinus
2014-01-17 14:11 ` Stefan Monnier
2014-01-17 14:15 ` Michael Albinus
2014-01-17 15:07 ` Stefan Monnier
2014-01-17 15:44 ` Michael Albinus
2014-01-17 18:31 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4880ymv.wl%arne_bab@web.de \
--to=arne_bab@web.de \
--cc=13124@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).