From: Stephen Berman <stephen.berman@gmx.net>
To: 17985@debbugs.gnu.org
Subject: bug#17985: 24.3.92; doc-view-open-text raises wrong-type-argument error
Date: Thu, 10 Jul 2014 14:26:18 +0200 [thread overview]
Message-ID: <87r41twgb9.fsf@rosalinde.fritz.box> (raw)
If I'm using Gnus to read mail with an attachment, I can type `c' on the
attachment to view it in another buffer, and if the attachment is
something that Doc View can handle, I can type `C-c C-c' in the buffer
to view the rendered image of the attachment. But if I then type `C-c
C-t' (doc-view-open-text) to view the ascii text of the attachment, I
get this error:
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
file-name-nondirectory(nil)
doc-view-open-text()
call-interactively(doc-view-open-text nil nil)
command-execute(doc-view-open-text)
The reason is that Doc View expects the buffer to be visiting a file.
But with an mail attachment, that does not have to be the case (when I
type `C-c C-c', Doc View says: "The buffer has been modified. Save the
changes? (y or n)", but if I answer "n", it still renders the image).
The following patch lets me view the ascii text whether or not the
buffer containing the document is visiting a file. (The patch is
against emacs-24; the error also happens in trunk.)
Steve Berman
In GNU Emacs 24.3.92.7 (x86_64-suse-linux-gnu, GTK+ Version 3.10.4)
of 2014-07-10 on rosalinde
Repository revision: 117368 monnier@iro.umontreal.ca-20140709185406-m0q0fjepl42pcrqx
Windowing system distributor `The X.Org Foundation', version 11.0.11403901
System Description: openSUSE 13.1 (Bottle) (x86_64)
Configured using:
`configure --without-toolkit-scroll-bars CFLAGS=-g3'
Important settings:
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
=== modified file 'lisp/doc-view.el'
*** lisp/doc-view.el 2014-04-04 17:42:55 +0000
--- lisp/doc-view.el 2014-07-10 11:54:18 +0000
***************
*** 1402,1412 ****
(interactive)
(if doc-view--current-converter-processes
(message "DocView: please wait till conversion finished.")
! (let ((txt (expand-file-name "doc.txt" (doc-view--current-cache-dir))))
(if (file-readable-p txt)
(let ((name (concat "Text contents of "
! (file-name-nondirectory buffer-file-name)))
! (dir (file-name-directory buffer-file-name)))
(with-current-buffer (find-file txt)
(rename-buffer name)
(setq default-directory dir)))
--- 1402,1413 ----
(interactive)
(if doc-view--current-converter-processes
(message "DocView: please wait till conversion finished.")
! (let ((txt (expand-file-name "doc.txt" (doc-view--current-cache-dir)))
! (bname (or buffer-file-name (buffer-name))))
(if (file-readable-p txt)
(let ((name (concat "Text contents of "
! (file-name-nondirectory bname)))
! (dir (or (file-name-directory bname) default-directory)))
(with-current-buffer (find-file txt)
(rename-buffer name)
(setq default-directory dir)))
next reply other threads:[~2014-07-10 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 12:26 Stephen Berman [this message]
2014-07-28 9:10 ` bug#17985: 24.3.92; doc-view-open-text raises wrong-type-argument error Tassilo Horn
2014-07-28 9:21 ` Eli Zaretskii
2014-07-28 9:33 ` Tassilo Horn
2014-07-28 10:07 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r41twgb9.fsf@rosalinde.fritz.box \
--to=stephen.berman@gmx.net \
--cc=17985@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).