bug#18981: 24.3; gs and filenames with percent signs

bug#18981: 24.3; gs and filenames with percent signs

[Юрий Пухальский]

I've a file named: A13+Datasheet+-+v1.12+%282012-03-29%29.pdf
When I invoke docview (hitting return in dired), it doesn't work because
of percent signs in the file name: DocView: process pdf/ps->png changed status to exited abnormally with code 1.
Tracing docview I get:

1 -> doc-view-start-process: name="pdf/ps->png" program="gs" args=("-dSAFER" "-dNOPAUSE" "-sDEVICE=png16m" "-dTextAlphaBits=4" "-dBATCH" "-dGraphicsAlphaBits=4" "-dQUIET" "-r100" "-sOutputFile=/tmp/docview1000/A13+Datasheet+-+v1.12+%282012-03-29%29.pdf-1dc1b37082c745e206fc9363f828eb08/page-%d.png" "/home/pooh/work/srvdoc/A13+Datasheet+-+v1.12+%282012-03-29%29.pdf") callback=#[0 "\302\303\300!\304\305\306\307 \"\304\310%\210	\203

bug#18981: 24.3; gs and filenames with percent signs

[Marcin Borkowski]

On 2014-11-07, at 14:02, aikipooh@gmail.com (Юрий Пухальский) wrote:

> I've a file named: A13+Datasheet+-+v1.12+%282012-03-29%29.pdf
> When I invoke docview (hitting return in dired), it doesn't work because
> of percent signs in the file name: DocView: process pdf/ps->png changed status to exited abnormally with code 1.
> Tracing docview I get:
>
> 1 -> doc-view-start-process: name="pdf/ps->png" program="gs" args=("-dSAFER" "-dNOPAUSE" "-sDEVICE=png16m" "-dTextAlphaBits=4" "-dBATCH" "-dGraphicsAlphaBits=4" "-dQUIET" "-r100" "-sOutputFile=/tmp/docview1000/A13+Datasheet+-+v1.12+%282012-03-29%29.pdf-1dc1b37082c745e206fc9363f828eb08/page-%d.png" "/home/pooh/work/srvdoc/A13+Datasheet+-+v1.12+%282012-03-29%29.pdf") callback=#[0 "\302\303\300!\304\305\306\307 \"\304\310%\210	\203.\311	!\210\304\312p\313\"\207" [100 doc-view-current-timer write-region prin1-to-string nil expand-file-name "resolution.el" doc-view-current-cache-dir silently cancel-timer doc-view-display force] 6 "
>
> (fn)"]
>
> I see the percent signs from the filename verbatim in gs invocation, but
> it's not allowed as they are (I think) getting to the printf-like
> function (for %d in batches), and therefore must be presented as %%.
>
> So the fix is easy: when preparing the invocation string for gs, change
> single percent signs to double.

Hi Юрий,

I know it's been some time since your report, but could you please check
whether this bug is still present?  I tried to reproduce it (with a file
called foo%.pdf, on Fedora), and it seemed to work just fine.

Best,

-- 
Marcin

bug#18981: 24.3; gs and filenames with percent signs

[Юрий Пухальский]

Hi Marcin!

I've 24.5.1 now, and it looks fine.

> Hi Юрий,
>
> I know it's been some time since your report, but could you please check
> whether this bug is still present?  I tried to reproduce it (with a file
> called foo%.pdf, on Fedora), and it seemed to work just fine.
>
> Best,

bug#18981: 24.3; gs and filenames with percent signs

[Marcin Borkowski]

On 2016-03-04, at 22:03, Юрий Пухальский <aikipooh@gmail.com> wrote:

> Hi Marcin!
>
> I've 24.5.1 now, and it looks fine.

Thanks for the quick confirmation, so I'm closing this bug.

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University