From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#20206: 25.0.50; [PATCH] keep diff-mode's window visible when we visit sources from diff-mode Date: Sun, 29 Mar 2015 12:48:12 -0700 Message-ID: <87r3s7wpe2.fsf@secretsauce.net> References: <87a8yzy5t4.fsf@secretsauce.net> <551456ED.8060101@gmx.at> <87twx4wztk.fsf@secretsauce.net> <55183DDD.7070303@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1427658865 24775 80.91.229.3 (29 Mar 2015 19:54:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Mar 2015 19:54:25 +0000 (UTC) Cc: 20206@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 29 21:54:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YcJHg-0000l2-5W for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Mar 2015 21:54:12 +0200 Original-Received: from localhost ([::1]:58034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcJHf-0006DN-Cm for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Mar 2015 15:54:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcJHb-0006D7-L5 for bug-gnu-emacs@gnu.org; Sun, 29 Mar 2015 15:54:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcJHW-0005dK-Iq for bug-gnu-emacs@gnu.org; Sun, 29 Mar 2015 15:54:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcJHW-0005dE-5g for bug-gnu-emacs@gnu.org; Sun, 29 Mar 2015 15:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YcJHV-0005zM-Pm for bug-gnu-emacs@gnu.org; Sun, 29 Mar 2015 15:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Mar 2015 19:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20206-submit@debbugs.gnu.org id=B20206.142765880622973 (code B ref 20206); Sun, 29 Mar 2015 19:54:01 +0000 Original-Received: (at 20206) by debbugs.gnu.org; 29 Mar 2015 19:53:26 +0000 Original-Received: from localhost ([127.0.0.1]:39827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YcJGv-0005yS-Uo for submit@debbugs.gnu.org; Sun, 29 Mar 2015 15:53:26 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43504) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YcJGt-0005yH-AM for 20206@debbugs.gnu.org; Sun, 29 Mar 2015 15:53:24 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 68806209F2 for <20206@debbugs.gnu.org>; Sun, 29 Mar 2015 15:53:19 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sun, 29 Mar 2015 15:53:22 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Qnx6b MVBdjwVYdXnDpDfN+m9TlY=; b=JYnpMQH8XmDQA2XsNe4Qc1f2Qq2KIiuM3b4KL q+v0I5xuK78YWnXiCj3x4qerdEncrl4JB1vH+Phf7vz75kIKF5+hyo9Jhg3FEofn A8a/sADHUF2O+wxpo0esmdc2xvBI1WmApfQML7XGsPafEksT/LfhkIbuFz0oFVhx 6qogPY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=Qnx6bMVBdjwVYdXnDpDfN+m9TlY=; b=Dy89U WY6PLHjb3XmSxXFDeaMl6XdQVqi1Y2J63bQLznqungeHmYg/Mjkw48cCberpWvcn cybHh1QiXGSenKxtYHM2vwAfMg1KhpZOFDk7IQbXURS58xnSO8fLJO6umGEucUso DvOj7M2bn/oy9aWYh/Tva7QPBwt8RtHolOkxWw= X-Sasl-enc: FRREwZznWYxOxoxAoMqetEPkaO3dQSXzwUWE81Q3/l0C 1427658802 Original-Received: from shorty.local (unknown [104.35.103.243]) by mail.messagingengine.com (Postfix) with ESMTPA id 2CC1B68009D; Sun, 29 Mar 2015 15:53:22 -0400 (EDT) Original-Received: from ip6-localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1YcJHx-0004HW-Rk; Sun, 29 Mar 2015 12:54:29 -0700 In-reply-to: <55183DDD.7070303@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101030 Archived-At: martin rudalics writes: > > 2. The display-buffer-pop-up-window action is there to handle bug 19901. > > There the user already has two windows, and by default a third is > > created. It's less obvious to me which is the "right" behavior here, but > > the earlier behavior of reusing the window seems reasonable. > > Agreed. But if you have a two windows frame and your settings for > popping up a third window would normally allow that, your solution would > nevertheless try to use another window in that case. Wouldn't it be > sufficient to just use '((inhibit-same-window . t))? I'm not sure what you mean: '((inhibit-same-window . t)) is not a valid as an action argument to display-buffer, and emacs barfs if I try to use it as such. I'm not at all married to using display-buffer-pop-up-window here. If you have a better idea for solving 19901 (or if you think there's nothing to fix), then I'm fine with it. Another wrinkle is that the behavior reported in 19901 as a bug is only observable with particular geometries of the emacs X11 window. On my machine, 19901 is reproducible if emacs takes up my whole screen (1440x1050), but not if it takes only half (720x1050). Presumably emacs thinks that splitting into a 3rd window will create new windows that are too narrow. That is all to say that maybe 19901 is not a bug.