From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#23571: 25.1.50; Click-mouse-1 = Drag-mouse-1 in Gnus Article buffer Date: Mon, 06 Jun 2016 21:38:02 +0200 Message-ID: <87r3caw1k5.fsf@gmx.net> References: <87futfbio4.fsf@gmx.net> <874m9k3inf.fsf@gmx.net> <83zirc22sf.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1465242450 6006 80.91.229.3 (6 Jun 2016 19:47:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Jun 2016 19:47:30 +0000 (UTC) Cc: 23571@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 06 21:47:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bA0UX-0007t1-AP for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jun 2016 21:47:17 +0200 Original-Received: from localhost ([::1]:45318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0UW-0005Gm-FZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jun 2016 15:47:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0Mc-0006Xd-Lz for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:39:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA0MY-00008b-K6 for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0MY-00008X-HC for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bA0MY-0008CB-CE for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jun 2016 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23571 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23571-submit@debbugs.gnu.org id=B23571.146524189231442 (code B ref 23571); Mon, 06 Jun 2016 19:39:02 +0000 Original-Received: (at 23571) by debbugs.gnu.org; 6 Jun 2016 19:38:12 +0000 Original-Received: from localhost ([127.0.0.1]:57068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA0Lk-0008B4-7W for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:38:12 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:62194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA0Li-0008Aq-JM for 23571@debbugs.gnu.org; Mon, 06 Jun 2016 15:38:11 -0400 Original-Received: from rosalinde ([89.245.72.42]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Ll0tl-1bhh4Y42VR-00ajIe; Mon, 06 Jun 2016 21:38:04 +0200 In-Reply-To: <83zirc22sf.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 May 2016 19:37:52 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:sHnYkhkhXThbaAuEhYHkAXfz0/e1Tgikd+zvcWR8rNP2nydWUMg XSOTRI4x883wVfuk0UAjhmQPIRkbFhiDk2/9cMkPD6JQz5B3gGL2XiSz9f7lsLFHi/mOTRd ZbRThBchk9bV6k/5MNrfYZQMCLaMJFOzTuFgELH8LwEt9B+Lq47uqFX38sLeKCuZMmovTXD nPd4gs3nQhd7aw6AV3cLA== X-UI-Out-Filterresults: notjunk:1;V01:K0:TGz73/DgQ3Y=:KjFHxdXB0IUoZr/dvD9eBZ g3YMTN5Bjw0CI8n19spwGigY+MuH7kUzqlx/jBy2z0yxSnC16PUwFDtbLTfLBuUtgPlb71wDm 8hWDIVB40gygb8JHyAY5oZ9dtkG2wFLVkabJtATgD20nZ4v/1e7VdUsFPypHfkmpm1FBmzIUd kNTqSwqs4Xqx6/iR0J6q0AKWcZajxI9gfnSIX4Z2JTR5tKHclag44z6GV9ak8wVeQW7E0rw0j S0erEkistFTNj605iQKzqPwrW7LkzKfKljsGNpfsD1xqj4/YM5AZwz+J+BNBOLVzZ/j/nSy3i FmoqUOH1E2BojsmQ29VMCI4d2FAe1+N+mXn7KLECDpBu+On1b6L6s9b2kMq/kZtfGN/UfqEsO CmZBSwtyU+cjiSI7uQVBVxNguRg7d3I0jSGTWLK1NUQy3bz8GfJ4TuClh4dbRWE14WNG4Tu5z 1sbZlrdHwkCSHe3USzifa2UOoIZtbilxhB+7NyXLfEpmIDCw0PIWGb7ulp1Q3eHW+Hw8ltRRy Gyd9ok3YwQhffYWyXjpaIsR35wMBSVeuP7Dd/C9AUhC+6a69kuhXjlNFEZlKsz7Ghqz/sWloU NwYd/Srl3DpH1Rtj5wi9OcyJ9Mr5YqrgxJhKmnF353sh9tWWABczf2X/hhG01j2Mi4NaxBhg0 7kMOxdvzH/9fSk/XO7Y5ZBp/Ra/NiuHoNIPKqEs//J/W9aaJ+Hf2Ro4cgt3yhMd25E11nK5cA WwCP0N+jfimHcZG81ps7Hw05w2OZhOhCuubHqovpD5RNZjbRHKlheDVOQ8b+XmStEiyc0ViS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119179 Archived-At: On Thu, 26 May 2016 19:37:52 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Thu, 26 May 2016 18:09:56 +0200 >> >> On Wed, 18 May 2016 15:27:23 +0200 Stephen Berman wrote: >> >> > Clicking mouse-1 in a Gnus Article buffer, then releasing it and moving >> > the mouse (without holding down a mouse key) highlights a region, just >> > as when the mouse is dragged with mouse-1 held down. To reproduce: >> > >> > 0. emacs -Q >> > 1. M-x gnus, type `y' at the prompt, then type `B RET news.gmane.org RET >> > 1 RET' to open the most recent article in gmane.announce on the >> > news.gmane.org server. >> > 2. Click anywhere in the Article buffer (except on the texts following >> > the From: and To: headers, which are buttons) with mouse-1, release >> > mouse-1, move the mouse. >> > => A region is highlighted. >> > >> > Subsequently clicking and releasing mouse-1 does not deactivate the >> > mark (but clicking with mouse-2 or mouse-3 does). >> > >> > I have not observed this behavior anywhere besides Gnus Article buffers. >> > >> > This happens in master but not in emacs-25. It happens at least since >> > commit 62d7acae7405732268713006d839a5c3507b9482, which was my first >> > build from master after a long pause, so I don't know when this behavior >> > first appeared (I didn't save any earlier builds from master, which were >> > from many months before, but I'm sure they didn't show this behavior). >> >> Git bisect says: >> >> 72166f2f3dba18f1217c666574032f5a0351ed65 is the first bad commit >> commit 72166f2f3dba18f1217c666574032f5a0351ed65 >> Author: Martin Rudalics >> Date: Tue May 3 08:38:49 2016 +0200 >> >> Bind `widget-button-click' to mouse-1/-2 instead of down-mouse-1/-2 >> >> * lisp/wid-edit.el (widget-keymap): Bind `widget-button-click' >> to mouse-1/-2 instead of down-mouse-1/-2. Suggested by Stefan >> Monnier. (Bug#19185, Bug#20398) > > So I guess Gnus needs to do something to countermand the low-level > change, right? It turns out it's not just Gnus Article buffers (as presciently suggested by the title of bug#23653, which I merged with this one): in fact, the same problem appears to happen in all packages in which buffers use widget-keymap; there are quite a few of these, as rgrepping for widget-keymap on the lisp directory shows, and in all that I tried (cus-edit, wid-browse, recentf, printing, secrets, image-dired, todo-mode) the problem with mouse-1 occurred. So I think the fix should be in widget-button-click, or somewhere at that level, and not in all of its users. Steve Berman