From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Date: Mon, 18 Jul 2016 19:18:09 -0400 Message-ID: <87r3aqcz7y.fsf@users.sourceforge.net> References: <87k2gs8bak.fsf@lifelogs.com> <87wpkpwrfn.fsf@lifelogs.com> <877fcjt4xf.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468885359 23975 80.91.229.3 (18 Jul 2016 23:42:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2016 23:42:39 +0000 (UTC) To: 23945@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 01:42:27 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPIB8-0001my-Hp for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 01:42:26 +0200 Original-Received: from localhost ([::1]:50985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPIB7-0006Q7-Iu for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 19:42:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPHoZ-0001V1-2x for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 19:19:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPHoU-0003za-MG for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 19:19:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPHoU-0003zH-Iu for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 19:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPHoU-0005Uu-9l for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 19:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23945-submit@debbugs.gnu.org id=B23945.146888389621076 (code B ref 23945); Mon, 18 Jul 2016 23:19:02 +0000 Original-Received: (at 23945) by debbugs.gnu.org; 18 Jul 2016 23:18:16 +0000 Original-Received: from localhost ([127.0.0.1]:56084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPHnk-0005Ts-EZ for submit@debbugs.gnu.org; Mon, 18 Jul 2016 19:18:16 -0400 Original-Received: from mail-it0-f52.google.com ([209.85.214.52]:35119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPHni-0005Te-Po for 23945@debbugs.gnu.org; Mon, 18 Jul 2016 19:18:15 -0400 Original-Received: by mail-it0-f52.google.com with SMTP id u186so80242534ita.0 for <23945@debbugs.gnu.org>; Mon, 18 Jul 2016 16:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9vudXXdBJDuhnfOHAV/gAjAET9PNMvVf4JvOuNH/x+Q=; b=XAWnmM4ejoBYOI3MVpOfkVuPodTycdkQzD73rPAvZJmY1PvotEhQM4erNbfItmJQ/V NGuMmBtQbDIoGoqN+rTDxd0F71PDDBHX8sAk4nF3ItiQ8HoUfeHQijTkfuA3ytPYJyKF R8t1xKuGCAMhVr2IPP1JxmCsecTEP032jAut6cxD56a5WWUgMgyI5Zu8w2bly3Qn1DCy tWGlR55VZ8yJkFifk/GvXWUiZr5yqsdzKjyBAtEfj5JE0PbuiEZNOWQ7sF3AtewmOylc 5Yc4p6mlDpRIvl4efGAalyM0TcV11X74o7elSaF6+q5y7MI88kqMiPI2mLNyb/FoOuaZ vwNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=9vudXXdBJDuhnfOHAV/gAjAET9PNMvVf4JvOuNH/x+Q=; b=FmjT5cFEM6hTCOLAXGwITDtcf8gekpRDB/LQ+xdZzp8AmxivAHOHbFzzjizvbDE2aY U5Q4UVF+8A3B6o/vhaBGfQZ2LhAYqIaOO8Vl5sHmLxwomP7hm2ya33/8vdBH3gH2CuwV sMOtucCGqtX07Otc1HGxNiNpHq9KVdfPILY3BTT2cDS3kHFI6HhxrTtNRUJ9opqdOAvo +NTQSJtnTV4RZALt7YSnkBGxTGc69GC0qGIBmAGZ2Xa6PpSrJCSI9DVSvIEDrztXX/Eo L0zwjMyOS+e+Jn93PcgnookY2Fc0Vlt+dwkCiSbl7SzRJqHc/ZHA1my61nbEKmeEpgUx E8ow== X-Gm-Message-State: ALyK8tJnERs65Qmr3BcWjisKprROmwNrsl5+p9w539Fg/+a1LwoDNW7cCB6xoTh2lv0SwA== X-Received: by 10.36.230.5 with SMTP id e5mr959732ith.92.1468883889113; Mon, 18 Jul 2016 16:18:09 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id b66sm1487416itd.0.2016.07.18.16.18.08 for <23945@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2016 16:18:08 -0700 (PDT) In-Reply-To: <877fcjt4xf.fsf@lifelogs.com> (Ted Zlatanov's message of "Mon, 18 Jul 2016 10:08:12 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121243 Archived-At: Ted Zlatanov writes: > On Wed, 13 Jul 2016 10:20:12 -0400 Ted Zlatanov wrote: > > TZ> On Mon, 11 Jul 2016 11:05:55 -0400 Teodor Zlatanov wrote: > TZ> I've published the proposed changes to the Gnus Cloud code in the branch > TZ> `scratch/gnus-cloud' and would like to request a code review. It's a > TZ> single commit which I've tested over the last 2 weeks with the help of > TZ> other Gnus users. > > TZ> I'll add documentation if the code is acceptable. > > TZ> There is one piece I remembered was missing: making the cloud host > TZ> persistent. > > I converted `gnus-cloud-method' to a defcustom and added the necessary > code to set it, resolving this question. > > Since no one has been interested in reviewing this code, I will merge it > tomorrow. Perhaps this is partly because I'm not familiar with the code (or what "Gnus Cloud" is), but it seems to me that you're missing a good summary line explaining what any of these changes are for. The bug title and commit message summary line mentions only "Gnus Cloud work". What "work"? This feels actively reviewer-hostile. The 2nd commit titled "Minor gnus-cloud UI improvements" is a bit better (at least we can tell it's about UI), though adding 20 or so "Merge branch 'master' of git.sv.gnu.org:/srv/git/emacs" in between doesn't help much either.