From: npostavs@users.sourceforge.net
To: 23945@debbugs.gnu.org
Subject: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud
Date: Mon, 18 Jul 2016 19:18:09 -0400 [thread overview]
Message-ID: <87r3aqcz7y.fsf@users.sourceforge.net> (raw)
In-Reply-To: <877fcjt4xf.fsf@lifelogs.com> (Ted Zlatanov's message of "Mon, 18 Jul 2016 10:08:12 -0400")
Ted Zlatanov <tzz@lifelogs.com> writes:
> On Wed, 13 Jul 2016 10:20:12 -0400 Ted Zlatanov <tzz@lifelogs.com> wrote:
>
> TZ> On Mon, 11 Jul 2016 11:05:55 -0400 Teodor Zlatanov <tzz@lifelogs.com> wrote:
> TZ> I've published the proposed changes to the Gnus Cloud code in the branch
> TZ> `scratch/gnus-cloud' and would like to request a code review. It's a
> TZ> single commit which I've tested over the last 2 weeks with the help of
> TZ> other Gnus users.
>
> TZ> I'll add documentation if the code is acceptable.
>
> TZ> There is one piece I remembered was missing: making the cloud host
> TZ> persistent.
>
> I converted `gnus-cloud-method' to a defcustom and added the necessary
> code to set it, resolving this question.
>
> Since no one has been interested in reviewing this code, I will merge it
> tomorrow.
Perhaps this is partly because I'm not familiar with the code (or what
"Gnus Cloud" is), but it seems to me that you're missing a good summary
line explaining what any of these changes are for. The bug title and
commit message summary line mentions only "Gnus Cloud work". What
"work"? This feels actively reviewer-hostile.
The 2nd commit titled "Minor gnus-cloud UI improvements" is a bit better
(at least we can tell it's about UI), though adding 20 or so "Merge
branch 'master' of git.sv.gnu.org:/srv/git/emacs" in between doesn't
help much either.
next prev parent reply other threads:[~2016-07-18 23:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 15:05 bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Teodor Zlatanov
2016-07-13 14:20 ` Ted Zlatanov
2016-07-18 14:08 ` Ted Zlatanov
2016-07-18 23:18 ` npostavs [this message]
2016-07-19 14:50 ` Ted Zlatanov
2016-07-19 20:15 ` Ted Zlatanov
2016-07-20 1:36 ` Noam Postavsky
2016-07-20 12:55 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3aqcz7y.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=23945@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).