From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24751: 26.0.50; Regex stack overflow not detected properly (gets "Variable binding depth exceeds max-specpdl-size") Date: Tue, 15 Nov 2016 20:06:29 -0500 Message-ID: <87r36ckzca.fsf@users.sourceforge.net> References: <87twc6tl0i.fsf@users.sourceforge.net> <83h97nlknj.fsf@gnu.org> <87mvhdoh4q.fsf@users.sourceforge.net> <83zilcipcr.fsf@gnu.org> <87a8d4lyzo.fsf@users.sourceforge.net> <83a8d3cq9s.fsf@gnu.org> <87wpg5l9st.fsf@users.sourceforge.net> <83d1hwhgdi.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1479258398 19182 195.159.176.226 (16 Nov 2016 01:06:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Nov 2016 01:06:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24751@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 16 02:06:29 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6og3-0001We-1F for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2016 02:06:15 +0100 Original-Received: from localhost ([::1]:49986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6og3-0002Ny-6F for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2016 20:06:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6oft-0002N7-G9 for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 20:06:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6ofq-0000uf-CR for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 20:06:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43263) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6ofq-0000uN-8Q for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 20:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c6ofp-0000WQ-VH for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2016 20:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2016 01:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24751 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24751-submit@debbugs.gnu.org id=B24751.14792583471984 (code B ref 24751); Wed, 16 Nov 2016 01:06:01 +0000 Original-Received: (at 24751) by debbugs.gnu.org; 16 Nov 2016 01:05:47 +0000 Original-Received: from localhost ([127.0.0.1]:58662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6ofb-0000Vw-Iv for submit@debbugs.gnu.org; Tue, 15 Nov 2016 20:05:47 -0500 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:36240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6ofa-0000Vk-NX for 24751@debbugs.gnu.org; Tue, 15 Nov 2016 20:05:47 -0500 Original-Received: by mail-it0-f42.google.com with SMTP id l8so37789193iti.1 for <24751@debbugs.gnu.org>; Tue, 15 Nov 2016 17:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EqnFxklJJ7PXXoNLnr8rcHGm+vGeoQ2NMwev66AY+eU=; b=BaQlYjHKu216MM7teDc4G0FkLuhU5vixpQjQ0a29922YdoU5RoIBqXRHmkkz8V1uwM CQC/yhO01aLCp6hg0tWUtc001J/6KE4FM8YGEQOn7aOJJmucBV1Fs9rDTEJih5hfw/VT kPwsa+jDjmOpVroigZUE45L47hRfwMyWAsCheOcT+EYXaCsaxlighDPyC7+iS8He7poB QbiZchKHqPZoZ/P4jmfVmh+I6moODPLIrrEl6u2ZxYr9qaDyqAKB9ocdOgr0Ngg/AClt sCyM19oCkYQr3pgUfkIrnZ32tEjrN6qNSDIz4olE93WKHbb3pvUOP6FEWh08mtbpPYUW aWug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=EqnFxklJJ7PXXoNLnr8rcHGm+vGeoQ2NMwev66AY+eU=; b=LCc59jXFmcHdldLh6mPrkHpnn8J/FbFpsstdicHPBp6fiYhpQnFr53zWuZYpNWmouy Fx0fn6pkgH2pR5Ns5bEOQl5qhW9bour75aKoeSqzE9CPJoozMHYkFNtYq9nZBZSn9+5P PonjVAUGDyhjZI3Fkql62QOhtprdBmKdmiLgUaCyrCT1mIBM/kCXzKYe9M6XMWM5UgPP eSrMM2EVLPlWShW93X5+RXBf/WM73T0qdKCJAjmlRZqndHFVQiQbi2Pd7Zw4+F09zhyN nsM1yik0l7yiR51cmv+7XTsXEbEZMsQATl4FWtOMJTDsjzxy6p8ySoAcTzRZMJYByv8L GGCQ== X-Gm-Message-State: ABUngve4cwNwWik/qaJMcJoT0Sibo6q+6HXe+++VO6InnLkVqC8cSWg6eZYv35jrG2pTjg== X-Received: by 10.107.84.2 with SMTP id i2mr626084iob.225.1479258341120; Tue, 15 Nov 2016 17:05:41 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id n127sm2438791ita.22.2016.11.15.17.05.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Nov 2016 17:05:40 -0800 (PST) In-Reply-To: <83d1hwhgdi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Nov 2016 18:12:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125741 Archived-At: >> @@ -869,6 +869,7 @@ main (int argc, char **argv) >> >> /* Don't let regex.c overflow the stack. */ >> re_max_failures = lim < extra ? 0 : min (lim - extra, SIZE_MAX) / ratio; >> + emacs_re_safe_alloca = re_max_failures * min_ratio; >> } >> #endif /* HAVE_SETRLIMIT and RLIMIT_STACK and not CYGWIN */ > > . we shouldn't set re_max_failures to zero if the amount of stack is > less than 'extra', since in that case we will allocate the failure > stack off the heap; Then what should we set it to? Maybe we shouldn't modify it at all, since the stack isn't actually a limiting factor?