From: Stephen Berman <stephen.berman@gmx.net>
To: 24963@debbugs.gnu.org
Subject: bug#24963: 26.0.50; toggle-frame-maximized broken by double-buffering patch
Date: Sat, 26 Nov 2016 00:29:10 +0100 [thread overview]
Message-ID: <87r35zb0l5.fsf@rub.de> (raw)
In-Reply-To: <87h975f0p5.fsf@gmx.net> (Stephen Berman's message of "Fri, 18 Nov 2016 13:10:30 +0100")
On Fri, 18 Nov 2016 13:10:30 +0100 Stephen Berman <stephen.berman@gmx.net> wrote:
> 0. emacs -Q
> 1. M-x toggle-frame-maximized
> => frame is maximized
> 2. M-x toggle-frame-maximized
> => frame remains maximized, echo area displays "You can run the
> command ‘toggle-frame-maximized’ with <M-f10>"
> 3. M-x toggle-frame-maximized
> => now frame is restored to its prior size
>
> Git bisect says
>
> c29071587c64efb30792bd72248d3c791abd9337 is the first bad commit
> commit c29071587c64efb30792bd72248d3c791abd9337
> Author: Daniel Colascione <dancol@dancol.org>
> Date: Thu Oct 20 20:34:36 2016 -0700
>
> Add double-buffering support to reduce flicker
>
> Something in this patch seems to have affected modify-frame-parameters:
> in step 1 of the above recipe, the following code is executed (via
> set-frame-parameter):
>
> (modify-frame-parameters nil (list (cons 'fullscreen 'maximized)))
>
> However, subsequently evaluating (frame-parameter nil 'fullscreen)
> returns nil, so that in step 2, the frame-parameter is (again) modified,
> though the frame is already maximized. Now, however, evaluating
> (frame-parameter nil 'fullscreen) returns `maximized', so in step 3, the
> frame is now demaximized.
>
> I executed modify-frame-parameters with a couple of other frame
> parameters, but didn't observe a similar problem.
>
> In GNU Emacs 26.0.50.5 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15)
> of 2016-11-16 built on rosalinde
> Repository revision: f63976857b4458bc7712e91d95c04fe2e2ca0106
> Windowing system distributor 'The X.Org Foundation', version 11.0.11601000
> System Description: openSUSE 13.2 (Harlequin) (x86_64)
I just determined that the failure to demaximize in step 2 above only
happens when scroll-bar-mode is enabled. I guess this is related to the
code added to src/gtkutil.c by the above patch to "[f]orce [GTK+] scroll
bars to be real X11 windows".
Steve Berman
next prev parent reply other threads:[~2016-11-25 23:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 12:10 bug#24963: 26.0.50; toggle-frame-maximized broken by double-buffering patch Stephen Berman
2016-11-18 14:01 ` Óscar Fuentes
2016-11-18 18:43 ` Stephen Berman
2016-11-18 19:52 ` Óscar Fuentes
2016-11-18 20:36 ` Stephen Berman
2016-11-25 23:29 ` Stephen Berman [this message]
2017-03-02 11:01 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r35zb0l5.fsf@rub.de \
--to=stephen.berman@gmx.net \
--cc=24963@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).