From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#25482: Fwd: Re: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Date: Fri, 20 Jan 2017 06:42:10 +0100 Message-ID: <87r33yb83x.fsf@gmail.com> References: <871svzzcn4.fsf@gmail.com> <83lgu76nuf.fsf@gnu.org> <87vatac0a2.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1484891007 21648 195.159.176.226 (20 Jan 2017 05:43:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jan 2017 05:43:27 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 24.5.1 To: 25482@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 20 06:43:23 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cURye-00045Q-Rc for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jan 2017 06:43:08 +0100 Original-Received: from localhost ([::1]:52621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cURyj-0006qj-R1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jan 2017 00:43:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cURyb-0006qR-P0 for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2017 00:43:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cURyY-0006fI-Mt for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2017 00:43:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cURyY-0006fE-Ht for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2017 00:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cURyY-0000dc-3p for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2017 00:43:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <871svzzcn4.fsf@gmail.com> Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2017 05:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25482 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25482-submit@debbugs.gnu.org id=B25482.14848909402406 (code B ref 25482); Fri, 20 Jan 2017 05:43:02 +0000 Original-Received: (at 25482) by debbugs.gnu.org; 20 Jan 2017 05:42:20 +0000 Original-Received: from localhost ([127.0.0.1]:35977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cURxs-0000ck-AE for submit@debbugs.gnu.org; Fri, 20 Jan 2017 00:42:20 -0500 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:36683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cURxr-0000cW-AL for 25482@debbugs.gnu.org; Fri, 20 Jan 2017 00:42:19 -0500 Original-Received: by mail-wm0-f46.google.com with SMTP id c85so23046283wmi.1 for <25482@debbugs.gnu.org>; Thu, 19 Jan 2017 21:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=yqOY8CNPFfEkUoQcig2+vkGlnWOCGUpiAG2CUapLy9U=; b=kD5V/uOn44OKc3KlNALCkZTUAtTnfK1LjD3ViIImxfvfIX2am7sq20LODeqSjUUDUV QgVrQ1FrsC2pOGiCHMk49SBlVwCew0ub9AVCox8ldqqifn8rbGJhK0z0oaMD3/hwJSmJ AtlyluWFAWv9gv8wuYygwUnABGaup6fwrA+gRI8DV/gEoxUAEWMNVL5hekgjwRhDE2eb 8U+rWbpvxTITKFATcST2ENifx4P+NLp9MdoYrLbIxAS+16ywh/kpIgc64L1y1VmGmGpt ZRuDWYhRgHQZWXCX5EGA7aWIvwKfVcBCLS4oBLFxqCzby9lj2tcnWgZT0aZ8FBiwI3zO AJ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :message-id:mime-version:content-transfer-encoding; bh=yqOY8CNPFfEkUoQcig2+vkGlnWOCGUpiAG2CUapLy9U=; b=FL/AMwEAYxTQyiwLmD99dwr3VtJ7gAtDgrB8zLYdv+DA1Q/xjKe/2U0UFZISqsUF8s bqGwKucqnLQM0KvUzOlv3Wgda1hh5fEuupghkunNKBbgu7P83jpjnl3Z8GrLuifRhfP0 mz+zd6VeZKF2gawS0pDBrSsxIrXqSdzdS6mtDi2TFgFG/GoYNwTjNeIsd8+HiYYbKScI hZSPe0Xvtf1Ti4pWwLGlOaia6LFkheNJUhNwQwK9auhAeqqT8O342Mt9bk37aLoKJ9iw 4Lv5v6YTC5G5lcBGY4BNmj63KldS508KTk1TkmoyLgnLMgFSUFcpSanGj9d5fHTmUqn0 cVMw== X-Gm-Message-State: AIkVDXIO0cuFhaLW2IBF18U3vAe0K/mpcZukvdqkQ9RKphbKfJ78vQaTgKDzQXXRs7PiGg== X-Received: by 10.223.176.93 with SMTP id g29mr10066530wra.12.1484890933286; Thu, 19 Jan 2017 21:42:13 -0800 (PST) Original-Received: from dell-14z ([37.160.42.143]) by smtp.gmail.com with ESMTPSA id e14sm3437676wmd.14.2017.01.19.21.42.11 for <25482@debbugs.gnu.org> (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 19 Jan 2017 21:42:12 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128263 Archived-At: Thierry Volpiatto writes: > Eli Zaretskii writes: > >> Sorry, I don't think I follow: you should be able to set this variable >> to " -> ", a string, to get the old behavior and avoid non-ASCII >> strings in your minibuffer-history. > > No, you don't have the same behavior, you endup with a non ascii string > which goes to minibuffer-history, so the behavior is not as emacs-24.5 > if you set this variable to " -> ". > >> So why did you need the value of nil? > > Because when it is nil the string is not added to history, just like in > 24.5. > >>> + (when (stringp query-replace-from-to-separator) >>> + (setq query-replace-from-to-separator >>> + (propertize (if (char-displayable-p >>> + (string-to-char query-replace-from-to-separator)) >> >> This doesn't look right: string-to-char will return the blank >> character, which is the first character of " → ", and I don't think >> you meant that. > > Yes, you are right, thanks, however see how the actual code is wrong, > what if someone set the separator to another unicode string. > >> In any case, this looks more complex than it has to be, because you >> for some reason want to have the nil value. Please elaborate on the >> need for that. > > To retrieve the same behavior as in emacs-24.5, see above. -- Thierry