From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#25529: diagnosis and one approach to a fix Date: Fri, 10 Feb 2017 21:06:20 -0700 Message-ID: <87r3355q2r.fsf@tromey.com> References: <87wpd58ag6.fsf@tromey.com> <87shnt89be.fsf@tromey.com> <87o9yg8qdi.fsf@tromey.com> <87k2948onb.fsf@tromey.com> <183374a4-6469-44af-6ae6-fec02874547a@yandex.ru> <87bmuf8c1l.fsf@tromey.com> <87vash5wag.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486786037 4724 195.159.176.226 (11 Feb 2017 04:07:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Feb 2017 04:07:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) Cc: Tom Tromey , 25529@debbugs.gnu.org, Dmitry Gutov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 11 05:07:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccOxp-0000fw-U5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Feb 2017 05:07:10 +0100 Original-Received: from localhost ([::1]:47035 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccOxu-0007aZ-Fa for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 23:07:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccOxm-0007aR-8o for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 23:07:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccOxj-0006pd-4e for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 23:07:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ccOxi-0006pX-Rp for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 23:07:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ccOxi-00021I-IU for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 23:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Feb 2017 04:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25529 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25529-submit@debbugs.gnu.org id=B25529.14867860087742 (code B ref 25529); Sat, 11 Feb 2017 04:07:02 +0000 Original-Received: (at 25529) by debbugs.gnu.org; 11 Feb 2017 04:06:48 +0000 Original-Received: from localhost ([127.0.0.1]:35239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccOxU-00020o-8K for submit@debbugs.gnu.org; Fri, 10 Feb 2017 23:06:48 -0500 Original-Received: from gproxy2-pub.mail.unifiedlayer.com ([69.89.18.3]:36253) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ccOxS-00020Z-Kx for 25529@debbugs.gnu.org; Fri, 10 Feb 2017 23:06:47 -0500 Original-Received: (qmail 30795 invoked by uid 0); 11 Feb 2017 04:06:32 -0000 Original-Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy2.mail.unifiedlayer.com with SMTP; 11 Feb 2017 04:06:32 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id jG6R1u00b2f2jeq01G6UmX; Fri, 10 Feb 2017 21:06:32 -0700 X-Authority-Analysis: v=2.1 cv=Pets2ERd c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=KG2WNKdU-cRD97Zh_uAA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZjiCtssUDzUock0EY4h98kFsxv4OgfRRvt8r/S38uD4=; b=tWQ+337ae0DBZoCJOrgtiHnOWR dPZumQhrUXMIth9pnUv+ycbl6NacDke06Mmkb4kgqBzeUwftsLobL6rlpoTa4lp/3n5RvLVoviBWl POuKA6V1fhIG7OSpvUCdjgfKR; Original-Received: from 75-171-188-196.hlrn.qwest.net ([75.171.188.196]:49604 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ccOx7-0007IO-B6; Fri, 10 Feb 2017 21:06:25 -0700 X-Attribution: Tom In-Reply-To: (Stefan Monnier's message of "Fri, 10 Feb 2017 22:45:54 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.171.188.196 X-Exim-ID: 1ccOx7-0007IO-B6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-171-188-196.hlrn.qwest.net (bapiya) [75.171.188.196]:49604 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129230 Archived-At: >>>>> "Stefan" == Stefan Monnier writes: >> -(defun js-syntax-propertize-regexp (end) >> +(defun js-syntax-propertize-regexp () Stefan> Removing the `end` argument is fundamentally wrong. It's OK to play it Stefan> fast-and-loose and ignore that argument, but the function *should* keep Stefan> the buffer untouched after `end`. I thought it was ok because the region is always extended to the end of the line, and I think this regexp can't span lines. >> + (put-text-property (match-beginning 1) (match-end 1) Stefan> ^^^^^^^^^^^^^ Stefan> (min end (match-end 1)) Stefan> should do it. If this change is still needed, should the final goto-char also be treated this way? Tom