From: Tom Tromey <tom@tromey.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Tom Tromey <tom@tromey.com>,
25529@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#25529: diagnosis and one approach to a fix
Date: Fri, 10 Feb 2017 21:06:20 -0700 [thread overview]
Message-ID: <87r3355q2r.fsf@tromey.com> (raw)
In-Reply-To: <jwvfujlv1e1.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Fri, 10 Feb 2017 22:45:54 -0500")
>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> -(defun js-syntax-propertize-regexp (end)
>> +(defun js-syntax-propertize-regexp ()
Stefan> Removing the `end` argument is fundamentally wrong. It's OK to play it
Stefan> fast-and-loose and ignore that argument, but the function *should* keep
Stefan> the buffer untouched after `end`.
I thought it was ok because the region is always extended to the end of
the line, and I think this regexp can't span lines.
>> + (put-text-property (match-beginning 1) (match-end 1)
Stefan> ^^^^^^^^^^^^^
Stefan> (min end (match-end 1))
Stefan> should do it.
If this change is still needed, should the final goto-char also be
treated this way?
Tom
next prev parent reply other threads:[~2017-02-11 4:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 7:22 bug#25529: 25.1.90; js-mode: Regexp literal with unbalanced brackets breaks font-lock Mikhail Gusarov
2017-02-05 5:37 ` bug#25529: diagnosis and one approach to a fix Tom Tromey
2017-02-05 6:01 ` Tom Tromey
2017-02-05 18:05 ` Tom Tromey
2017-02-05 18:43 ` Tom Tromey
2017-02-06 1:12 ` Dmitry Gutov
2017-02-06 17:27 ` Tom Tromey
2017-02-07 2:20 ` Dmitry Gutov
2017-02-07 13:07 ` Tom Tromey
2017-02-07 13:11 ` Dmitry Gutov
2017-02-07 14:56 ` Stefan Monnier
2017-02-11 1:52 ` Tom Tromey
2017-02-11 3:45 ` Stefan Monnier
2017-02-11 4:06 ` Tom Tromey [this message]
2017-02-11 4:22 ` Stefan Monnier
2017-02-11 15:27 ` Tom Tromey
2017-02-11 15:41 ` Stefan Monnier
2017-02-11 17:13 ` Tom Tromey
2017-02-11 19:11 ` Dmitry Gutov
2017-02-11 19:37 ` bug#25529: done Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3355q2r.fsf@tromey.com \
--to=tom@tromey.com \
--cc=25529@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).