From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#25983: 25.2; set dired-directory in vc-dir mode Date: Sun, 05 Mar 2017 10:55:21 -0700 Message-ID: <87r32b1ud2.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1488736579 4918 195.159.176.226 (5 Mar 2017 17:56:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Mar 2017 17:56:19 +0000 (UTC) To: 25983@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 05 18:56:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckaO7-0000Eo-RJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Mar 2017 18:56:08 +0100 Original-Received: from localhost ([::1]:39879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckaOD-0001mu-Oh for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Mar 2017 12:56:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckaO5-0001mk-Du for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2017 12:56:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckaO2-0002Cd-7m for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2017 12:56:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43030) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckaO2-0002CV-1z for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2017 12:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ckaO1-0001Bi-SB for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2017 12:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Mar 2017 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14887365564553 (code B ref -1); Sun, 05 Mar 2017 17:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Mar 2017 17:55:56 +0000 Original-Received: from localhost ([127.0.0.1]:41229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckaNv-0001BI-Ga for submit@debbugs.gnu.org; Sun, 05 Mar 2017 12:55:55 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckaNt-0001Az-Mb for submit@debbugs.gnu.org; Sun, 05 Mar 2017 12:55:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckaNn-00028U-0g for submit@debbugs.gnu.org; Sun, 05 Mar 2017 12:55:48 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ckaNm-000289-Tm for submit@debbugs.gnu.org; Sun, 05 Mar 2017 12:55:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckaNl-0001la-8m for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2017 12:55:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckaNi-00024O-4k for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2017 12:55:45 -0500 Original-Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:36494) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ckaNh-000236-Kj for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2017 12:55:42 -0500 Original-Received: (qmail 5842 invoked by uid 0); 5 Mar 2017 17:55:27 -0000 Original-Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy6.mail.unifiedlayer.com with SMTP; 5 Mar 2017 17:55:27 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id sHvP1u00W2f2jeq01HvStv; Sun, 05 Mar 2017 10:55:27 -0700 X-Authority-Analysis: v=2.1 cv=R4+QR7hX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=6Iz7jQTuP9IA:10 a=l05HkUJgB8fd0-uaMoQA:9 a=77Na18wavAi-fx8F:21 a=BiSx3WcNwXM56b2X:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EiSn1hyPPN0mPq4nnEYaa6Sl7ayFoNyt4xol3AvdbhY=; b=cpFYvEAFP2CCEbBWvlhcnLjE1z MRX0ZtXBsft1w8tWset9WLMgiMIeuIIPxFA+Ebswm8E+cB5usRI1girK5jyW7yEnNnjCtdYr8a72B JWD/Fdvujuds6Hs14baDB3zZI; Original-Received: from 71-218-43-111.hlrn.qwest.net ([71.218.43.111]:57486 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ckaNP-0003eI-84 for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2017 10:55:23 -0700 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.218.43.111 X-Exim-ID: 1ckaNP-0003eI-84 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-218-43-111.hlrn.qwest.net (bapiya) [71.218.43.111]:57486 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130218 Archived-At: I'd find it handy if vc-dir buffers had dired-directory set. This can serve as an indication that the buffer is associated with some directory, even though it's not visiting a file. I've appended the patch I would like to apply. Let me know what you think. Tom diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el index 0363aab..2281333 100644 --- a/lisp/vc/vc-dir.el +++ b/lisp/vc/vc-dir.el @@ -1016,6 +1016,7 @@ vc-dir-mode (set (make-local-variable 'vc-ewoc) (ewoc-create #'vc-dir-printer)) (set (make-local-variable 'revert-buffer-function) 'vc-dir-revert-buffer-function) + (setq dired-directory default-directory) (setq list-buffers-directory (expand-file-name "*vc-dir*" default-directory)) (add-to-list 'vc-dir-buffers (current-buffer)) ;; Make sure that if the directory buffer is killed, the update In GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.8) of 2017-03-02 built on bapiya Repository revision: 6e788ef0e262fafc014c21f4ad52cc5dc9f1715b Windowing system distributor 'Fedora Project', version 11.0.11901000 System Description: Fedora release 25 (Twenty Five) Configured using: 'configure --prefix=/home/tromey/Emacs/install/ --with-modules' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: VC dir Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t which-function-mode: t global-auto-revert-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent messages: Mark set [2 times] Sending... Mark set [2 times] Sending via mail... Type C-x 1 to delete the help window. [2 times] Sending email Sending email done Sending...done a is undefined Scanning for dabbrevs...done Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.2/lisp/play/bubbles /home/tromey/.emacs.d/elpa/soap-client-3.1.1/soap-inspect hides /home/tromey/Emacs/install/share/emacs/25.2/lisp/net/soap-inspect /home/tromey/.emacs.d/elpa/soap-client-3.1.1/soap-client hides /home/tromey/Emacs/install/share/emacs/25.2/lisp/net/soap-client Features: (shadow emacsbug network-stream nsm starttls tls gnutls mailalias smtpmail sort mailcap bbdb-message sendmail mail-extr vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs whitespace log-edit message idna dired rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util cc-mode cc-fonts cc-guess cc-menus cc-cmds shell rx dabbrev eieio-opt speedbar sb-image ezimage dframe find-func copyright debug add-log vc-git diff-mode easy-mmode misearch multi-isearch jka-compr flyspell ispell diminish edmacro kmacro projectile grep compile ibuf-ext ibuffer dash appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu minimap autorevert filenotify cus-start cus-load status erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source eieio gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp warnings advice vc-dir ewoc vc vc-dispatcher cc-styles cc-align cc-engine cc-vars cc-defs bbdb bbdb-site timezone ange-ftp comint ansi-color ring server savehist finder-inf dwarf-mode-autoloads gdb-shell-autoloads eieio-core lisppaste-autoloads pydoc-info-autoloads info-look cl-seq cl-macs cl weblogger-autoloads info package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib bbdb-loaddefs time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 349646 37130) (symbols 48 38486 0) (miscs 40 928 1341) (strings 32 81666 10590) (string-bytes 1 2782947) (vectors 16 40092) (vector-slots 8 1457709 144853) (floats 8 533 448) (intervals 56 14838 166) (buffers 976 42))