From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#26969: 26.0.50; diff-changed invisible by default Date: Mon, 22 May 2017 23:19:02 +0300 Organization: LINKOV.NET Message-ID: <87r2zgzlu1.fsf@localhost> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1495484474 15445 195.159.176.226 (22 May 2017 20:21:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 May 2017 20:21:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (x86_64-pc-linux-gnu) Cc: 26969@debbugs.gnu.org, Justin Burkett To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 22 22:21:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCtpG-0003tv-0J for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 May 2017 22:21:10 +0200 Original-Received: from localhost ([::1]:44763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCtpL-0005HE-GK for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 May 2017 16:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCtoE-0004T3-Sb for bug-gnu-emacs@gnu.org; Mon, 22 May 2017 16:20:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCtoA-00075w-Pc for bug-gnu-emacs@gnu.org; Mon, 22 May 2017 16:20:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCtoA-00075j-Mj for bug-gnu-emacs@gnu.org; Mon, 22 May 2017 16:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dCtoA-0005kx-Ae for bug-gnu-emacs@gnu.org; Mon, 22 May 2017 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2017 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26969 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26969-submit@debbugs.gnu.org id=B26969.149548440022114 (code B ref 26969); Mon, 22 May 2017 20:20:02 +0000 Original-Received: (at 26969) by debbugs.gnu.org; 22 May 2017 20:20:00 +0000 Original-Received: from localhost ([127.0.0.1]:33280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCto8-0005kc-Dr for submit@debbugs.gnu.org; Mon, 22 May 2017 16:20:00 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:46344 helo=homiemail-a39.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCto6-0005kT-4L for 26969@debbugs.gnu.org; Mon, 22 May 2017 16:19:58 -0400 Original-Received: from homiemail-a39.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a39.g.dreamhost.com (Postfix) with ESMTP id D61CC150074; Mon, 22 May 2017 13:19:54 -0700 (PDT) Original-Received: from localhost.linkov.net (unknown [213.102.32.142]) (Authenticated sender: jurta@jurta.org) by homiemail-a39.g.dreamhost.com (Postfix) with ESMTPA id B4A6515006D; Mon, 22 May 2017 13:19:53 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 17 May 2017 15:12:50 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132740 Archived-At: > Nowadays the `diff-changed` face is defined to be "invisible" (i.e. the > text is displayed identically with or without that face). > IOW it can only be used as a parent of diff-added or diff-removed (or > some other such face). > > This is a bad idea since in cases such as vdiff.el where some changes > are neither additions nor removals, it would make sense to highlight th= e > buffer as just "changed" and using that face is a natural choice. > > I suggest the patch below for that. It is designed such that it should > make no visible difference to users of diff-added and diff-removed sinc= e > these faces override the parts that are set by my patch in diff-changed= . This might break a fragile condition in =E2=80=98diff-use-changed-face=E2= =80=99 that was created to support backward-compatibility of previously customized faces. But maybe it's time to simplify the logic of diff face definitions. > Another option would be to introduce a new face (not sure how to call > it, maybe diff-unspecified-change, maybe?) which inherits from > diff-changed as well. Then authors of external packages have to wait for the next Emacs release to start using it. > (defface diff-changed > - '((t nil)) > + '((((class color) (min-colors 88) (background light)) > + :background "grey90") > + (((class color) (min-colors 88) (background dark)) > + :background "grey20") > + (((class color)) > + :foreground "grey")) I wonder why grey? It used to be yellow.