unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#27022: url-retrieve + .authinfo bug
@ 2017-05-22 18:09 Andy Wingo
  2019-07-26  8:46 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Wingo @ 2017-05-22 18:09 UTC (permalink / raw)
  To: 27022

Hi,

If you try to do a url-retrieve over HTTP on a URL that requires HTTP
basic authentication, and you have an .authinfo file, and that .authinfo
contains an incorrect login, then Emacs will keep appending the same
Authorization: header to the request -- over and over, making the
request larger and larger, with no stop condition.  Eventually nginx
produces a "400 Bad Request" error because there were too many headers.

Emacs should instead error after the first attempt at authentication
fails.

  $ emacs --version
  GNU Emacs 25.2.1

Andy





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#27022: url-retrieve + .authinfo bug
  2017-05-22 18:09 bug#27022: url-retrieve + .authinfo bug Andy Wingo
@ 2019-07-26  8:46 ` Lars Ingebrigtsen
  2019-07-26  8:56   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-26  8:46 UTC (permalink / raw)
  To: Andy Wingo; +Cc: 27022

Andy Wingo <wingo@pobox.com> writes:

> If you try to do a url-retrieve over HTTP on a URL that requires HTTP
> basic authentication, and you have an .authinfo file, and that .authinfo
> contains an incorrect login, then Emacs will keep appending the same
> Authorization: header to the request -- over and over, making the
> request larger and larger, with no stop condition.  Eventually nginx
> produces a "400 Bad Request" error because there were too many headers.
>
> Emacs should instead error after the first attempt at authentication
> fails.

I'm able to reproduce this with this in my .authinfo file:

machine jigsaw.w3.org:443 login guest password wrong

and then:

(url-retrieve "https://jigsaw.w3.org/HTTP/Basic/" #'ignore)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#27022: url-retrieve + .authinfo bug
  2019-07-26  8:46 ` Lars Ingebrigtsen
@ 2019-07-26  8:56   ` Lars Ingebrigtsen
  0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-26  8:56 UTC (permalink / raw)
  To: Andy Wingo; +Cc: 27022

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Andy Wingo <wingo@pobox.com> writes:
>
>> If you try to do a url-retrieve over HTTP on a URL that requires HTTP
>> basic authentication, and you have an .authinfo file, and that .authinfo
>> contains an incorrect login, then Emacs will keep appending the same
>> Authorization: header to the request -- over and over, making the
>> request larger and larger, with no stop condition.  Eventually nginx
>> produces a "400 Bad Request" error because there were too many headers.
>>
>> Emacs should instead error after the first attempt at authentication
>> fails.
>
> I'm able to reproduce this with this in my .authinfo file:
>
> machine jigsaw.w3.org:443 login guest password wrong
>
> and then:
>
> (url-retrieve "https://jigsaw.w3.org/HTTP/Basic/" #'ignore)

And this should now be fixed on the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-26  8:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-22 18:09 bug#27022: url-retrieve + .authinfo bug Andy Wingo
2019-07-26  8:46 ` Lars Ingebrigtsen
2019-07-26  8:56   ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).