unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 27779@debbugs.gnu.org
Subject: bug#27779: 26.0.50: read -- Re-entering top level after C stack overflow
Date: Sat, 22 Jul 2017 22:45:14 -0400	[thread overview]
Message-ID: <87r2x798hx.fsf@users.sourceforge.net> (raw)
In-Reply-To: <m24lu4kvk8.wl%esq@lawlist.com> (Keith David Bershatsky's message of "Sat, 22 Jul 2017 14:31:35 -0700")

Keith David Bershatsky <esq@lawlist.com> writes:

> By process of elimination via the lo-tech method of trying different
> nightly builds from https://emacsformacosx.com/builds/all , I have
> determined that December 8, 2016 was the last build where I am able to
> successfully run from the terminal:

Likely candidate: [1: f0a1e9ec3f], specifically the addition of stackbuf
in this hunk means read1 will use a lot more stack per call.

@@ -2541,8 +2556,9 @@ read_integer (Lisp_Object readcharfun, EMACS_INT radix)
 read1 (Lisp_Object readcharfun, int *pch, bool first_in_list)
 {
   int c;
-  bool uninterned_symbol = 0;
+  bool uninterned_symbol = false;
   bool multibyte;
+  char stackbuf[MAX_ALLOCA];
 
   *pch = 0;

> At some point AFTER June 11, 2017, Emacs changed from
> crashing to just throwing an error message "Re-entering top level
> after C stack overflow".

I presume that's from [2: 9dee1c884e].

[1: f0a1e9ec3f]: 2016-12-08 13:00:32 -0800
  Make read1 more reentrant
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f0a1e9ec3fba3d5bea5bd62f525dba3fb005d1b1

[2: 9dee1c884e]: 2017-07-14 04:57:18 -0700
  Improve stack-overflow heuristic on GNU/Linux
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9dee1c884eb50ba282eb9dd2495c5269add25963





  reply	other threads:[~2017-07-23  2:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21  2:12 bug#27779: 26.0.50: read -- Re-entering top level after C stack overflow Keith David Bershatsky
2017-07-21  3:03 ` Keith David Bershatsky
2017-07-22  3:24   ` npostavs
2017-07-22  5:52 ` Keith David Bershatsky
2017-07-22 12:05   ` npostavs
2017-07-22 16:32 ` Keith David Bershatsky
2017-07-22 17:23   ` npostavs
2017-07-22 21:31 ` Keith David Bershatsky
2017-07-23  2:45   ` npostavs [this message]
2017-07-23 22:28 ` Keith David Bershatsky
2018-01-09  1:38 ` bug#27779: #27779; C stack overflow from `read' on deeply nested lisp object Keith David Bershatsky
2018-06-06 21:04 ` Vasilij Schneidermann
2018-06-06 21:30   ` Noam Postavsky
2018-06-07  8:18     ` Vasilij Schneidermann
2019-05-02  2:30   ` Noam Postavsky
2019-05-02  7:05 ` Keith David Bershatsky
2019-05-02  7:26   ` Paul Eggert
2019-05-02  8:00 ` Keith David Bershatsky
2022-04-21 13:33   ` bug#27779: 26.0.50: read -- Re-entering top level after C stack overflow Lars Ingebrigtsen
2022-04-21 18:56 ` Keith David Bershatsky
2022-04-22  0:26   ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2x798hx.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=27779@debbugs.gnu.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).