From: Stephen Berman <stephen.berman@gmx.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Noam Postavsky <npostavs@gmail.com>, 32212@debbugs.gnu.org
Subject: bug#32212: 26; `subword-mode' doc string shows empty key-binding list
Date: Fri, 20 Jul 2018 10:38:17 +0200 [thread overview]
Message-ID: <87r2jyjo92.fsf@gmx.net> (raw)
In-Reply-To: <83tvou1jdb.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Jul 2018 10:01:04 +0300")
On Fri, 20 Jul 2018 10:01:04 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Noam Postavsky <npostavs@gmail.com>
>> Date: Thu, 19 Jul 2018 20:58:52 -0400
>> Cc: 32212@debbugs.gnu.org
>>
>> > emacs -Q
>> >
>> > C-h f subword-mode
>> >
>> > You see this at the end of buffer *Help*:
>> >
>> > key binding
>> > --- -------
>> >
>> >
>> > It's not just about this appearing before the library is loaded.
>> > Loading the library does not populate the list of keys and their
>> > bindings. You always get such a heading, with no keys shown.
>>
>>
>> Seems to be a regression in 25.1, in 24.5 I see
>>
>> key binding
>> --- -------
>>
>> <remap> Prefix Command
>>
>> <remap> <backward-kill-word> subword-backward-kill
>
> ISTR that the implementation changed radically, so perhaps this is the
> (unintended) consequence.
Maybe due to this change:
commit 6ddc44225e743e2b2a0d5c192f50aefd7a4a915b
Author: Daniel Colascione <dancol@dancol.org>
Date: Sun Mar 23 00:36:26 2014 -0700
Merge capitalized-words-mode and subword-mode
diff --git a/lisp/progmodes/subword.el b/lisp/progmodes/subword.el
--- a/lisp/progmodes/subword.el
+++ b/lisp/progmodes/subword.el
@@ -104,12 +82,6 @@
(defvar subword-mode-map
- (let ((map (make-sparse-keymap)))
- (dolist (cmd '(forward-word backward-word mark-word kill-word
- backward-kill-word transpose-words
- capitalize-word upcase-word downcase-word
- left-word right-word))
- (let ((othercmd (let ((name (symbol-name cmd)))
- (string-match "\\([[:alpha:]-]+\\)-word[s]?" name)
- (intern (concat "subword-" (match-string 1 name))))))
- (define-key map (vector 'remap cmd) othercmd)))
- map)
+ ;; We originally remapped motion keys here, but now use Emacs core
+ ;; hooks. Leave this keymap around so that user additions to it
+ ;; keep working.
+ (make-sparse-keymap)
"Keymap used in `subword-mode' minor mode.")
Steve Berman
next prev parent reply other threads:[~2018-07-20 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 15:10 bug#32212: 26; `subword-mode' doc string shows empty key-binding list Drew Adams
2018-07-20 0:58 ` Noam Postavsky
2018-07-20 7:01 ` Eli Zaretskii
2018-07-20 8:38 ` Stephen Berman [this message]
2018-07-22 20:22 ` Noam Postavsky
2018-07-22 22:36 ` Phil Sainty
2018-07-23 1:01 ` Drew Adams
2018-07-23 4:15 ` Phil Sainty
2018-07-23 4:19 ` Drew Adams
2018-07-23 2:26 ` Eli Zaretskii
2018-07-23 12:22 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2jyjo92.fsf@gmx.net \
--to=stephen.berman@gmx.net \
--cc=32212@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).