From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32257: 26.1; read-multiple-choice inf loops on mouse clicks Date: Fri, 27 Jul 2018 08:45:03 -0400 Message-ID: <87r2jo3l0w.fsf@gmail.com> References: <87muug4z52.fsf@gmail.com> <87y3dy3i05.fsf@gmail.com> <83muudrqol.fsf@gnu.org> <83effosvx2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532695451 17236 195.159.176.226 (27 Jul 2018 12:44:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Jul 2018 12:44:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: Andy Moreton , 32257@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 27 14:44:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj26I-0004N3-Gf for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 14:44:06 +0200 Original-Received: from localhost ([::1]:41081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj28O-0007Ep-IJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 08:46:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj28E-0007Dd-2I for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 08:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj28A-0002ce-WC for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 08:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54690) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fj28A-0002cW-R0 for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 08:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fj28A-0004Sx-JK for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 08:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jul 2018 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32257-submit@debbugs.gnu.org id=B32257.153269551617094 (code B ref 32257); Fri, 27 Jul 2018 12:46:02 +0000 Original-Received: (at 32257) by debbugs.gnu.org; 27 Jul 2018 12:45:16 +0000 Original-Received: from localhost ([127.0.0.1]:59705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj27Q-0004Rd-GF for submit@debbugs.gnu.org; Fri, 27 Jul 2018 08:45:16 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:54795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj27L-0004RL-Ap for 32257@debbugs.gnu.org; Fri, 27 Jul 2018 08:45:13 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id s7-v6so7322272itb.4 for <32257@debbugs.gnu.org>; Fri, 27 Jul 2018 05:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hXrFDDRlzmndZOqzECM3IxzU2FDNPE3HDt68qDs4Sp0=; b=HWUns7d2qULw6i9qDTJxAQ6ADuPNVJLpFcRGE8PyWQez/wA017SxoZIzQoXquFNX8R FNQSMy/Vicn2WTzr49QV3koDnfVX6lh85tlEy9a5rkAmS6Zc8OCgFDscipP/jsONEPaT a89GlJTeiDIJZi41FNjk8HvYSXD4VeMSGsEUMB2bHc38zufLuvx709A/+vV2hEXCC8BB tWGa6oDmHgLrVMON3RBH0tSbxfjrgZrxi3gETqskzWj6DlNReeLASrRZcTFt+cwBEDFW h8qt8IgjvU/vGs9g25sQHpuTwPYmxsjEgc3EfC2RxDWIiI+SpLhNEYe4ZK4AKvy3AA90 HUmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hXrFDDRlzmndZOqzECM3IxzU2FDNPE3HDt68qDs4Sp0=; b=joZxElgWc1CynzWIetYAgEbdfuCrEJaLQB26ELk0IDqC+vh8lNrfB72TkX6WfLCp4I oSbrFoYwcvErnFWJ93rbWV0dV5J76LenK+eLjfAYL0ufgJvxGagQ8HDLrDyGOFnkgDjI he/NTeUTa95FNgya8AKPJudmQsotv+NfQNFZvt4EMfwsrT/3z01/hyW27qbcEGoV17AX bZaTAo2ALkXUgM+qK0e1SV/348n1gNC9RCx2mWvr2IcsOPmFEW+o7ZML2DgS94COrqmM mvzH9Ll1pYyo/f2EHGeAXws4hf4f4Byul8pR2xqWUyOt0rdpUJAzUvIohdtBxru5l1BD wYrg== X-Gm-Message-State: AOUpUlF+vMtzY6c5VelN20hfqoWI5vNR7DOpHG7cfSbdPObIv6g+oOBd ksxKduAW/QNeGl+nZt0+WH80wFca X-Google-Smtp-Source: AAOMgpeW3/Sl1+SitSxCsCZom1+7qms8aN6/Jk024kbtCuLiiL6BIefQ3rIrolVhWsrIInKNO2Hcpw== X-Received: by 2002:a24:eec7:: with SMTP id b190-v6mr5632029iti.32.1532695505342; Fri, 27 Jul 2018 05:45:05 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p70-v6sm2727122itb.3.2018.07.27.05.45.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jul 2018 05:45:04 -0700 (PDT) In-Reply-To: <83effosvx2.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 27 Jul 2018 15:30:33 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149015 Archived-At: Eli Zaretskii writes: >> From: Andy Moreton >> Date: Fri, 27 Jul 2018 12:35:27 +0100 >> >> > If we want this change on emacs-26, we should carefully audit all the >> > other users of rmc.el What should we check for though? >> > (and in generally, I'd prefer some more local >> > change in nsm.el on the release branch). We've had our share of >> > subtle bugs introduced by switching to an "almost-compatible" method >> > of reading input. >> >> read-multiple choice only has two callers (`nsm-query-user' and >> `message-fix-before-sending') in both master and emacs-26. > > In Emacs, yes. But what about the world out there? I expect all the callers out in the world will exhibit the same bug. > In case it wasn't clear I meant to make a safer change on emacs-26, > and change read-multiple-choice on master. At any rate, I don't see a way of fixing it in the caller, short of temporarily fsetting read-char into read-event. Also, read-multiple-choice is new in Emacs 26, so it seems to me we should rather fix it in 26.2.