* bug#32035: 27.0.50; master; tcl-mode indentation broken in namespaces
@ 2018-07-02 15:02 Bruce Stephens
2018-07-02 17:20 ` Glenn Morris
2018-08-12 0:24 ` bug#32035: done Tom Tromey
0 siblings, 2 replies; 5+ messages in thread
From: Bruce Stephens @ 2018-07-02 15:02 UTC (permalink / raw)
To: 32035
With a file in tcl-mode (foo.tcl, say), I enter
namespace eval Foo {
variable foo
I would expect the second line to be indented (basically because of the
{, indicating it's beginning the namespace), but now it has indentation
0.
If I revert commit cd5bb4bf3dbad8941d25823f398b595b8f0edbb9, "Fix two
tcl-mode defun-related bugs" (which fixes #23565) then I get the
expected indentation.
In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
of 2018-07-02, modified by Debian built on tinier
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Debian GNU/Linux buster/sid
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#32035: 27.0.50; master; tcl-mode indentation broken in namespaces
2018-07-02 15:02 bug#32035: 27.0.50; master; tcl-mode indentation broken in namespaces Bruce Stephens
@ 2018-07-02 17:20 ` Glenn Morris
2018-07-02 20:48 ` Tom Tromey
2018-08-12 0:24 ` bug#32035: done Tom Tromey
1 sibling, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2018-07-02 17:20 UTC (permalink / raw)
To: Bruce Stephens; +Cc: 32035, tom
Explicitly cc'ing the author of the cited commit.
Bruce Stephens wrote:
> With a file in tcl-mode (foo.tcl, say), I enter
>
> namespace eval Foo {
> variable foo
>
> I would expect the second line to be indented (basically because of the
> {, indicating it's beginning the namespace), but now it has indentation
> 0.
>
> If I revert commit cd5bb4bf3dbad8941d25823f398b595b8f0edbb9, "Fix two
> tcl-mode defun-related bugs" (which fixes #23565) then I get the
> expected indentation.
>
> In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
> of 2018-07-02, modified by Debian built on tinier
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#32035: 27.0.50; master; tcl-mode indentation broken in namespaces
2018-07-02 17:20 ` Glenn Morris
@ 2018-07-02 20:48 ` Tom Tromey
2018-07-03 10:01 ` Bruce Stephens
0 siblings, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2018-07-02 20:48 UTC (permalink / raw)
To: Glenn Morris; +Cc: Bruce Stephens, 32035, tom
>>>>> "GM" == Glenn Morris <rgm@gnu.org> writes:
GM> Explicitly cc'ing the author of the cited commit.
Thanks.
>> With a file in tcl-mode (foo.tcl, say), I enter
>>
>> namespace eval Foo {
>> variable foo
>>
>> I would expect the second line to be indented (basically because of the
>> {, indicating it's beginning the namespace), but now it has indentation
>> 0.
>>
>> If I revert commit cd5bb4bf3dbad8941d25823f398b595b8f0edbb9, "Fix two
>> tcl-mode defun-related bugs" (which fixes #23565) then I get the
>> expected indentation.
The appended worked for me, could you try it?
If it works for you I will write a test or two and install it.
Note that evaling this in Emacs isn't enough, see the doc comment of the
variable in question.
Tom
diff --git a/lisp/progmodes/tcl.el b/lisp/progmodes/tcl.el
index fad62e100a..586d8cc0ed 100644
--- a/lisp/progmodes/tcl.el
+++ b/lisp/progmodes/tcl.el
@@ -360,7 +360,7 @@ tcl-mode-hook
(defvar tcl-proc-list
- '("proc" "method" "itcl_class" "body" "configbody" "class")
+ '("proc" "method" "itcl_class" "body" "configbody" "class" "namespace")
"List of commands whose first argument defines something.
This exists because some people (eg, me) use `defvar' et al.
Call `tcl-set-proc-regexp' and `tcl-set-font-lock-keywords'
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#32035: 27.0.50; master; tcl-mode indentation broken in namespaces
2018-07-02 20:48 ` Tom Tromey
@ 2018-07-03 10:01 ` Bruce Stephens
0 siblings, 0 replies; 5+ messages in thread
From: Bruce Stephens @ 2018-07-03 10:01 UTC (permalink / raw)
To: Tom Tromey; +Cc: 32035
Tom Tromey <tom@tromey.com> writes:
[...]
> The appended worked for me, could you try it?
> If it works for you I will write a test or two and install it.
I can confirm it works for me, thanks.
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#32035: done
2018-07-02 15:02 bug#32035: 27.0.50; master; tcl-mode indentation broken in namespaces Bruce Stephens
2018-07-02 17:20 ` Glenn Morris
@ 2018-08-12 0:24 ` Tom Tromey
1 sibling, 0 replies; 5+ messages in thread
From: Tom Tromey @ 2018-08-12 0:24 UTC (permalink / raw)
To: 32035-done
The fix to this was checked in a while ago.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-12 0:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-02 15:02 bug#32035: 27.0.50; master; tcl-mode indentation broken in namespaces Bruce Stephens
2018-07-02 17:20 ` Glenn Morris
2018-07-02 20:48 ` Tom Tromey
2018-07-03 10:01 ` Bruce Stephens
2018-08-12 0:24 ` bug#32035: done Tom Tromey
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).