From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Date: Wed, 28 Nov 2018 01:49:54 +0200 Organization: LINKOV.NET Message-ID: <87r2f6hzf1.fsf@mail.linkov.net> References: <9B715204-BE6D-4F02-B484-1EA9EDACE0EB@scratch.space> <87wope15gh.fsf@mail.linkov.net> <4D07BB6C-98A9-4EC2-BB37-097D5D753E53@scratch.space> <87wopbzeuy.fsf@mail.linkov.net> <87d0r04tmg.fsf@mail.linkov.net> <87sgzv747k.fsf@mail.linkov.net> <740AF1DA-7EDB-4310-8C6E-F7944D714513@scratch.space> <87sgzuca5o.fsf@mail.linkov.net> <87a7m0hi5t.fsf@mail.linkov.net> <837eh4gpjd.fsf@gnu.org> <87a7lyi29o.fsf@mail.linkov.net> <837eh1jeak.fsf@gnu.org> <87k1l0c3be.fsf@mail.linkov.net> <83h8g3j0aa.fsf@gnu.org> <87y39fmnbn.fsf@mail.linkov.net> <83mupvgj18.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1543365889 18439 195.159.176.226 (28 Nov 2018 00:44:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Nov 2018 00:44:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Van L , 33398@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 28 01:44:45 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRny7-0004gt-Tn for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Nov 2018 01:44:44 +0100 Original-Received: from localhost ([::1]:45262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRo0E-00044c-DH for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Nov 2018 19:46:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRnzU-0003kq-SE for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 19:46:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRnzQ-00028u-AH for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 19:46:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRnzQ-00028o-6I for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 19:46:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gRnzQ-0002oW-4L for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 19:46:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Nov 2018 00:46:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33398-submit@debbugs.gnu.org id=B33398.154336593410700 (code B ref 33398); Wed, 28 Nov 2018 00:46:04 +0000 Original-Received: (at 33398) by debbugs.gnu.org; 28 Nov 2018 00:45:34 +0000 Original-Received: from localhost ([127.0.0.1]:52638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRnyv-0002mQ-MY for submit@debbugs.gnu.org; Tue, 27 Nov 2018 19:45:33 -0500 Original-Received: from insect.birch.relay.mailchannels.net ([23.83.209.93]:30816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRnyt-0002mE-Jk for 33398@debbugs.gnu.org; Tue, 27 Nov 2018 19:45:32 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7FA35123292; Wed, 28 Nov 2018 00:45:30 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.11.179]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 21A26123A09; Wed, 28 Nov 2018 00:45:30 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 28 Nov 2018 00:45:30 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thread-Spicy: 1f9402a37dd71885_1543365930276_3109036661 X-MC-Loop-Signature: 1543365930275:1342416674 X-MC-Ingress-Time: 1543365930275 Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id D413880924; Tue, 27 Nov 2018 16:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=xQeVuIxVoPpW26S05TYSj2P1vU4=; b= 3GVxucxI6lHFlfyJsk0jEZek8YiSZCUK1L3cfFcQHwQVsHZ56dvJ/iiX2m31qjOu r1XSStA3W6y8eNh3ZKD1VsBoEYRFQh6O6K7nFBVpR3p0JTUEmlyXjoxr4OPmKQ1t /okozgPaiVx12wZ5HOW3wYEGxEqCdC41YuMmAXGhqRU= Original-Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id AFB8980921; Tue, 27 Nov 2018 16:45:27 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 In-Reply-To: <83mupvgj18.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 27 Nov 2018 07:56:51 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddvtddgvdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddvgedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrvdegvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152837 Archived-At: >> Maybe something like this, but I'm not sure because the red background would >> be too glaring on 88 colors, but more readable orchid1 is not quite red. > > Is OrangeRed better? OrangeRed is not better than red, but simply Orange looks much better, so a new face could be named hi-orange. >> Also blue would be too dark for a light background, but more readable >> DarkSlateGray1 is not quite blue as its name suggests. > > That's okay, I think. I found a better color: Aquamarine, it's very close to DarkSlateGray1, but it's name has a stronger association with blue. >> (defface hi-green-b >> - '((((min-colors 88)) (:weight bold :foreground "green1")) >> + '((((min-colors 88)) (:weight bold :foreground "green3")) >> (t (:weight bold :foreground "green"))) >> "Face for hi-lock mode." >> :group 'hi-lock-faces) >> >> (defface hi-red-b >> - '((((min-colors 88)) (:weight bold :foreground "red1")) >> + '((((min-colors 88)) (:weight bold :foreground "firebrick2")) >> (t (:weight bold :foreground "red"))) >> "Face for hi-lock mode." >> :group 'hi-lock-faces) > > So why are you still changing the existing faces? Not that I see any > problem with these changes on low-color TTYs, but still: why change? The original complain from Van L was that "green1" and "red1" are too glaring, and I agree. The new colors are dimmed down versions that are more easy to read. diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el index f503c2764b..f66a512755 100644 --- a/lisp/hi-lock.el +++ b/lisp/hi-lock.el @@ -177,6 +177,24 @@ hi-blue "Face for hi-lock mode." :group 'hi-lock-faces) +(defface hi-orange + '((((min-colors 88) (background dark)) + (:background "orange" :foreground "black")) + (((background dark)) (:background "red" :foreground "black")) + (((min-colors 88)) (:background "orange")) + (t (:background "red"))) + "Face for hi-lock mode." + :group 'hi-lock-faces) + +(defface hi-aquamarine + '((((min-colors 88) (background dark)) + (:background "aquamarine" :foreground "black")) + (((background dark)) (:background "blue" :foreground "black")) + (((min-colors 88)) (:background "aquamarine")) + (t (:background "blue"))) + "Face for hi-lock mode." + :group 'hi-lock-faces) + (defface hi-black-b '((t (:weight bold))) "Face for hi-lock mode." @@ -189,13 +207,13 @@ hi-blue-b :group 'hi-lock-faces) (defface hi-green-b - '((((min-colors 88)) (:weight bold :foreground "green1")) + '((((min-colors 88)) (:weight bold :foreground "green3")) (t (:weight bold :foreground "green"))) "Face for hi-lock mode." :group 'hi-lock-faces) (defface hi-red-b - '((((min-colors 88)) (:weight bold :foreground "red1")) + '((((min-colors 88)) (:weight bold :foreground "firebrick2")) (t (:weight bold :foreground "red"))) "Face for hi-lock mode." :group 'hi-lock-faces) @@ -216,8 +234,8 @@ hi-lock-interactive-patterns (define-obsolete-variable-alias 'hi-lock-face-history 'hi-lock-face-defaults "23.1") (defvar hi-lock-face-defaults - '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-black-b" - "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb") + '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-orange" "hi-aquamarine" + "hi-black-b" "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb") "Default faces for hi-lock interactive functions.") (define-obsolete-variable-alias 'hi-lock-regexp-history