From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files Date: Wed, 27 Feb 2019 10:15:59 +0100 Message-ID: <87r2bt1tio.fsf@gmx.de> References: <9d65284f-7a64-5e9c-ab02-fbbd1be41689@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="136371"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: =?UTF-8?Q?Felici=C3=A1n_?= =?UTF-8?Q?N=C3=A9meth?= , 34343@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 27 10:17:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gyvKx-000ZEH-9Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 10:17:11 +0100 Original-Received: from localhost ([127.0.0.1]:40721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyvKw-0004sh-87 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 04:17:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyvKp-0004sW-Sj for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 04:17:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyvKp-0004MC-3w for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 04:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyvKo-0004Lt-PY for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 04:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gyvKo-0006gZ-Gc for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 04:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Feb 2019 09:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34343-submit@debbugs.gnu.org id=B34343.155125897025638 (code B ref 34343); Wed, 27 Feb 2019 09:17:02 +0000 Original-Received: (at 34343) by debbugs.gnu.org; 27 Feb 2019 09:16:10 +0000 Original-Received: from localhost ([127.0.0.1]:53528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyvJy-0006fS-I3 for submit@debbugs.gnu.org; Wed, 27 Feb 2019 04:16:10 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:47383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyvJw-0006fD-Fv for 34343@debbugs.gnu.org; Wed, 27 Feb 2019 04:16:09 -0500 Original-Received: from detlef.gmx.de ([213.220.147.65]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LbuCq-1hOOFZ1SgG-00jIbk; Wed, 27 Feb 2019 10:16:01 +0100 In-Reply-To: (Dmitry Gutov's message of "Tue, 26 Feb 2019 04:09:10 +0300") X-Provags-ID: V03:K1:78jk0XDcp8ESBefoJQVpjU0kGLpuIbmedmu81LHD2GkTH5T8Joy BdzkPNtZweqrPSJe+VA0EFlu7QuOg/69UKhQuXaVn05qGh5lKr8OFZzWp3vUnxMYY6ByqIg 3EtEvShXvyH8Ov+MtYxAA+Sjn7/M88cneNOx7+/YTE1WFOeRRNHVVOE5orRcxiNT9yZJaUA h1GFCZ9d/PYMw+yfTOtMg== X-UI-Out-Filterresults: notjunk:1;V03:K0:TQVPijulAJc=:1sGsSgJxfkx42Ev6IwXDOF WQGB8KHojeisCmyqN04uALP0PVVWm+g4dzZHAJMfTdczCxTzVBI2U8XitSt6Xq502shB/aZSO 6t6J0C8SNGpRVTjq3Aky7B7kB36DcYyVAdulxvfAsv/KY69ShkJmEAxAa2cUPmrU/+k7JgmXu 7kIGPeLNDY4vN+Gp/H+UBrEIO2RcMkYJ4E1/cfJD0KU/rUulQ3g+IRzOrNbllbI+aQKSyHKvO fZhVT6Ef7p98xPMvIEuuZ/fa+7KL/mEDlZQoGGoZd8HWHmI9aBop+NWN0RGlD6bmqo6aRG70x jyEmhw1XmAKx/ouopNCdSCliB9uIvIShoQI3+NZ+1TYw1zWNjV9JDkBz2FxNSkbYgZ5PN8DMi tkscId6pO5x6p4kZG/lHn+phAcjoKWp+6IaZ9Y5hOyRfYWeCFjlWKs6rDJk30/aFxR3frOVIZ bRrSbRNSIiVLG0sVaHqZiIYKxzDgR41+wO8T8vQAa0b6Ly6ytJE66r73ACV7+pmU3XZRncHSq SUVaPtFwwKBtUOj38D9kNMUjJHn2h6wHbd4Qxe2Hca02ifz6FhYIJoXO2cLoILyIQVc1/W+rL fJ711n8tKrXd7/744CmqKQRcbiEx+ZzB7LHZ0pxAsK90mvj9mXrI5CovkRL3KNtkWtIj+VtKu 8OyDw8tPVmGwumeSuhJ8HfiQUvB1+rxnVGq+gXnGKEtfeOLT/ObMq/PP3ESm2NdrsxeW3gJh1 WdlEdfBmJFEZq3dom36+D4XmNpboG8lkUYCbXZY7sObuzviSMOHxrVUGOfZ6Th6SwrAZQfuq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155838 Archived-At: Dmitry Gutov writes: Hi Dmitry, > Thank you. Before I apply this, I'd like to clarify one question with > Tramp's maintainer. > > Michael, do you think it's doing the right thing, conceptually? > > We first call the process in project-files, then process the returned > files names to make them remote (if necessary). > > Then, in project--find-regexp-in-files parses the files names again to > extract the remote id and the local names, does the process calls and > prepends the remote id again. > > Some kind of alternative would be to only use the local names until > the end, and keep the remote id in one place only. E.g. in > default-directory. Well, I don't know the internal logic in project.el. But indeed, it is an option to work only with the local file names, and to prepend the remote part of default-directory at the very end to the results. This must be done consequently, everywhere. Best regards, Michael.