* bug#33256: nxml-mode completion of attribute no longer adds =" after emacs 26 [not found] <0499B553-F989-4945-9827-643FB5A72D27@gmail.com> @ 2019-04-04 3:48 ` Noam Postavsky 2019-04-04 23:38 ` Martin Fowler 0 siblings, 1 reply; 3+ messages in thread From: Noam Postavsky @ 2019-04-04 3:48 UTC (permalink / raw To: Martin Fowler; +Cc: 33256 tags 33256 + unreproducible quit Martin Fowler <martinfowlercom@gmail.com> writes: > I've used nxml-mode for a long time. When typing in an xml attribute > and using completion, emacs would respond by completing the attribute > and also adding =" to allow me to immediately type the value of the > xml attribute. I recently upgraded to emacs 26, and it now only > completes the attribute hame. The original completion behavior (adding > =") is described in the manual at > <https://www.gnu.org/software/emacs/manual/html_node/nxml-mode/Completion.html> > . > > To replicate > > - open an html file in nxml mode > - ensure it's tied to the html schema file > - type "<html xmln" > - trigger completion (C-M-i, or whatever calls completion-at-point) > > expected behavior (pre emacs 26) > > line shows: > > <html xmlns=" > > actual behavior, line shows > > <html xmlns I can't reproduce this exactly, with 26.1 and later I get <html xmlns="-!-" (where -!- represents point). While the doc does say there should only be an opening quote added, this is arguably an improvement, so... ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#33256: nxml-mode completion of attribute no longer adds =" after emacs 26 2019-04-04 3:48 ` bug#33256: nxml-mode completion of attribute no longer adds =" after emacs 26 Noam Postavsky @ 2019-04-04 23:38 ` Martin Fowler 2019-04-10 23:41 ` Noam Postavsky 0 siblings, 1 reply; 3+ messages in thread From: Martin Fowler @ 2019-04-04 23:38 UTC (permalink / raw To: Noam Postavsky; +Cc: 33256 My apologies on this, I think I neglected to test this bug with no initialization file. I tried it with `emacs -q` and got the behavior you describe (which I agree is reasonable). I got the behavior I mentioned with all my inits loaded, so I expect it's some interaction between nxml-mode and one of those. That will be a fun exercise to try and figure out ;-) Again my apologies for not having tested this properly before raising the bug. Martin Fowler http://martinfowler.com > On Apr 3, 2019, at 23:48, Noam Postavsky <npostavs@gmail.com> wrote: > > tags 33256 + unreproducible > quit > > Martin Fowler <martinfowlercom@gmail.com> writes: > >> I've used nxml-mode for a long time. When typing in an xml attribute >> and using completion, emacs would respond by completing the attribute >> and also adding =" to allow me to immediately type the value of the >> xml attribute. I recently upgraded to emacs 26, and it now only >> completes the attribute hame. The original completion behavior (adding >> =") is described in the manual at >> <https://www.gnu.org/software/emacs/manual/html_node/nxml-mode/Completion.html> >> . >> >> To replicate >> >> - open an html file in nxml mode >> - ensure it's tied to the html schema file >> - type "<html xmln" >> - trigger completion (C-M-i, or whatever calls completion-at-point) >> >> expected behavior (pre emacs 26) >> >> line shows: >> >> <html xmlns=" >> >> actual behavior, line shows >> >> <html xmlns > > I can't reproduce this exactly, with 26.1 and later I get > > <html xmlns="-!-" > > (where -!- represents point). While the doc does say there should only > be an opening quote added, this is arguably an improvement, so... ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#33256: nxml-mode completion of attribute no longer adds =" after emacs 26 2019-04-04 23:38 ` Martin Fowler @ 2019-04-10 23:41 ` Noam Postavsky 0 siblings, 0 replies; 3+ messages in thread From: Noam Postavsky @ 2019-04-10 23:41 UTC (permalink / raw To: Martin Fowler; +Cc: 33256 close 33256 quit Martin Fowler <martinfowlercom@gmail.com> writes: > My apologies on this, I think I neglected to test this bug with no > initialization file. No worries, it happens. :) > I tried it with `emacs -q` and got the behavior > you describe (which I agree is reasonable). I've meanwhile tracked down where the change happened [1: d7896a6f77], and updated the manual to reflect the slightly different new behaviour [2: cb5a340823], so I'm closing the bug. [1: d7896a6f77]: 2016-01-16 14:03:29 -0500 * lisp/nxml: Use standard completion; it also works for company-mode https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d7896a6f773dc4ae4e1b56c34b6708fe2bc5610a [2: cb5a340823]: 2019-04-10 19:33:21 -0400 Update nxml-mode.texi: completion now gives xmlns="-!-" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cb5a34082342695676f2db11e1465bd28347e9de ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-10 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0499B553-F989-4945-9827-643FB5A72D27@gmail.com>
2019-04-04 3:48 ` bug#33256: nxml-mode completion of attribute no longer adds =" after emacs 26 Noam Postavsky
2019-04-04 23:38 ` Martin Fowler
2019-04-10 23:41 ` Noam Postavsky
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).