bug#35236: 27.0.50; Make application/x-patch inlinable

bug#35236: 27.0.50; Make application/x-patch inlinable

[Basil L. Contovounesios]

Severity: wishlist

The patch attached in bug#33016#29[1] shows up as application/x-patch,
rather than the more common text/x-patch or text/x-diff.

[1] https://debbugs.gnu.org/33016#29

IWBNI Gnus recognised this mime type as inlinable, similar to the other
two.  Patch to follow.

Thanks,

-- 
Basil

Gnus v5.13
GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-04-11

bug#35236: 27.0.50; Make application/x-patch inlinable

[Basil L. Contovounesios]

[-- Attachment #1: Type: text/plain, Size: 109 bytes --]

tags 35236 patch
quit

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Patch to follow.

Here it is:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-application-x-patch-inlinable-in-mm-decode.el.patch --]
[-- Type: text/x-diff, Size: 1669 bytes --]

From 543c4cf9099abee5ece33c3200d48962e52cde30 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Thu, 11 Apr 2019 14:42:20 +0100
Subject: [PATCH] Make application/x-patch inlinable in mm-decode.el

* lisp/gnus/mm-decode.el (mm-inline-media-tests, mm-inlined-types):
Include application/x-patch as a synonym of text/x-patch and
text/x-diff. (bug#35236)
---
 lisp/gnus/mm-decode.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
index 3f255419e7..93b57706f8 100644
--- a/lisp/gnus/mm-decode.el
+++ b/lisp/gnus/mm-decode.el
@@ -236,6 +236,7 @@ mm-inline-media-tests
     ("text/x-patch" mm-display-patch-inline identity)
     ;; In case mime.types uses x-diff (as does Debian's mime-support-3.40).
     ("text/x-diff" mm-display-patch-inline identity)
+    ("application/x-patch" mm-display-patch-inline identity)
     ("application/emacs-lisp" mm-display-elisp-inline identity)
     ("application/x-emacs-lisp" mm-display-elisp-inline identity)
     ("application/x-shellscript" mm-display-shell-script-inline identity)
@@ -303,8 +304,9 @@ mm-inline-media-tests
 
 (defcustom mm-inlined-types
   '("image/.*" "text/.*" "message/delivery-status" "message/rfc822"
-    "message/partial" "message/external-body" "application/emacs-lisp"
-    "application/x-emacs-lisp"
+    "message/partial" "message/external-body"
+    "application/x-patch"
+    "application/emacs-lisp" "application/x-emacs-lisp"
     "application/pgp-signature" "application/x-pkcs7-signature"
     "application/pkcs7-signature" "application/x-pkcs7-mime"
     "application/pkcs7-mime"
-- 
2.20.1


[-- Attachment #3: Type: text/plain, Size: 27 bytes --]


WDYT?  Thanks,

-- 
Basil

bug#35236: 27.0.50; Make application/x-patch inlinable

[Basil L. Contovounesios]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Patch to follow.
>
> Here it is:
>
> From 543c4cf9099abee5ece33c3200d48962e52cde30 Mon Sep 17 00:00:00 2001
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Thu, 11 Apr 2019 14:42:20 +0100
> Subject: [PATCH] Make application/x-patch inlinable in mm-decode.el
>
> * lisp/gnus/mm-decode.el (mm-inline-media-tests, mm-inlined-types):
> Include application/x-patch as a synonym of text/x-patch and
> text/x-diff. (bug#35236)
> ---
>  lisp/gnus/mm-decode.el | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
> index 3f255419e7..93b57706f8 100644
> --- a/lisp/gnus/mm-decode.el
> +++ b/lisp/gnus/mm-decode.el
> @@ -236,6 +236,7 @@ mm-inline-media-tests
>      ("text/x-patch" mm-display-patch-inline identity)
>      ;; In case mime.types uses x-diff (as does Debian's mime-support-3.40).
>      ("text/x-diff" mm-display-patch-inline identity)
> +    ("application/x-patch" mm-display-patch-inline identity)
>      ("application/emacs-lisp" mm-display-elisp-inline identity)
>      ("application/x-emacs-lisp" mm-display-elisp-inline identity)
>      ("application/x-shellscript" mm-display-shell-script-inline identity)
> @@ -303,8 +304,9 @@ mm-inline-media-tests
>  
>  (defcustom mm-inlined-types
>    '("image/.*" "text/.*" "message/delivery-status" "message/rfc822"
> -    "message/partial" "message/external-body" "application/emacs-lisp"
> -    "application/x-emacs-lisp"
> +    "message/partial" "message/external-body"
> +    "application/x-patch"
> +    "application/emacs-lisp" "application/x-emacs-lisp"
>      "application/pgp-signature" "application/x-pkcs7-signature"
>      "application/pkcs7-signature" "application/x-pkcs7-mime"
>      "application/pkcs7-mime"
> -- 
> 2.20.1
>
>
> WDYT?

The suggested change seems harmless enough to me, so I intend to push it
to master within the next week if there are no objections before then.

Thanks,

-- 
Basil

bug#35236: 27.0.50; Make application/x-patch inlinable

[Basil L. Contovounesios]

tags 35236 fixed
close 35236
quit

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> The suggested change seems harmless enough to me, so I intend to push it
> to master within the next week if there are no objections before then.

I pushed it to master[1] and am therefore closing this report.

[1: bb60144d00]: Make application/x-patch inlinable in mm-decode.el
  2019-05-12 12:27:40 +0100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=bb60144d00fce90d7db1fdb5b67d6aa266e5010a

-- 
Basil