From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35204: 27.0.50; Crash on Cygwin Date: Sat, 13 Apr 2019 23:26:13 +0100 Message-ID: <87r2a5fsoq.fsf@tcd.ie> References: <83ftqr7bnb.fsf@gnu.org> <8336mq6i49.fsf@gnu.org> <83ef6865nj.fsf@gnu.org> <83a7gv4s1b.fsf@gnu.org> <56e372ca-748c-a335-1066-a1032ae1d894@cornell.edu> <831s27mezn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="234577"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: yamaoka@jpl.org, 35204@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 14 00:27:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFR7C-000ysr-I3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Apr 2019 00:27:14 +0200 Original-Received: from localhost ([127.0.0.1]:56563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFR7B-0007RT-HM for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 18:27:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFR72-0007Q6-BU for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 18:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFR70-0007sP-OF for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 18:27:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFR70-0007ro-C5 for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 18:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hFR70-0004F9-3e for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 18:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2019 22:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35204 X-GNU-PR-Package: emacs Original-Received: via spool by 35204-submit@debbugs.gnu.org id=B35204.155519438416263 (code B ref 35204); Sat, 13 Apr 2019 22:27:02 +0000 Original-Received: (at 35204) by debbugs.gnu.org; 13 Apr 2019 22:26:24 +0000 Original-Received: from localhost ([127.0.0.1]:59367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFR6N-0004ED-13 for submit@debbugs.gnu.org; Sat, 13 Apr 2019 18:26:24 -0400 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:38690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFR6L-0004Dx-2X for 35204@debbugs.gnu.org; Sat, 13 Apr 2019 18:26:21 -0400 Original-Received: by mail-ed1-f41.google.com with SMTP id d13so11413328edr.5 for <35204@debbugs.gnu.org>; Sat, 13 Apr 2019 15:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=fJFom/CthiZLpafJ86BeGJja2ba0Xfqb00JmaSUv/Cw=; b=KHGwgQy4IyILSV34i1q4C1asUL2JL7GSFTScuf0dYpDI13DCjhq05N0fyWMm5OQLYl EGfellTuNbiZ4UIeU1a9Spw8vT4bUIpkQqYn3vxXowODLs7KyhcY1NOAOj4zHTU6V7c8 bn+rPoDWEUs4t+j6jW8LPxhYjYdHKhvgTQ0XI8FGrcTqU/7bHrrnpbRb3OqlRa9jp8XH +JHBiQbfgnHy+zhF/MV/SILtQkl6T+kQHmByQQ6LEXpU7WKmYDoariMhYLBuZFJnc27T oOFya2ThH1cg07xNtSH6t12ykfJgXgT7XS+V2EeWeCUUOs72vxiry7DTQudkWrVhcFrj f+Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=fJFom/CthiZLpafJ86BeGJja2ba0Xfqb00JmaSUv/Cw=; b=Wzi1qdoy+HIuD8DpcVH6RrLgS1umiN0CcsKAlZQDiZDMyaPJ/qRDXzpgCpCKOD+KBF pPYaEjj0mMxyJFXuQuPUTEFxg4iWJ5dJxmnmJGVfDllO2gz3IyglpQlbJfQ8TvNcfB1Q 6PdngfVVZh5ruYfpiHiyynWLHWWYsIbMS4u9TuUvYj+1iaLO5AhdJGACeghXAMEI51+p hh6iv31VlRXwXE0Jw/SabrPffOVqQqHAXXYviorAARmm+LnmDPC+pxh1na7D8BEML1XN /rw4i2mdn+eEh9QVoMcHpy5N1poGDJ9AzNQ04nSycVCsolnw70nMJL4B5CQV5hi9gONt 6G6w== X-Gm-Message-State: APjAAAUE/hHGgMUunRGhN3lZiRPmaIznSA0DHFGBJqcK+W7g4npHIkfe 9kTSaucYikhzWpwIk2q9+c81yQ== X-Google-Smtp-Source: APXvYqyfKk2fz/V3lkyu7yUQOwSOdSmtZosKzCl65RQ4iBo/iUwt9QJiJ04Lrw2YZxkkrjKHOL9K7g== X-Received: by 2002:a50:8ecb:: with SMTP id x11mr4941562edx.88.1555194375429; Sat, 13 Apr 2019 15:26:15 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id u10sm5731111edf.50.2019.04.13.15.26.14 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 13 Apr 2019 15:26:14 -0700 (PDT) In-Reply-To: <831s27mezn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Apr 2019 18:15:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157598 Archived-At: Eli Zaretskii writes: >> From: Ken Brown >> CC: "35204@debbugs.gnu.org" <35204@debbugs.gnu.org> >> Date: Fri, 12 Apr 2019 14:54:21 +0000 >> >> I can replicate the crash on my system, but reverting only a tiny part of the >> commits in question seems to fix it, in the sense that I can successfully >> evaluate x-display-monitor-attributes-list: >> >> diff --git a/src/xfns.c b/src/xfns.c >> index 13f66f0718..3e4d037716 100644 >> --- a/src/xfns.c >> +++ b/src/xfns.c >> @@ -5030,7 +5030,7 @@ Internal use only, use `display-monitor-attributes-list' >> instead. */) >> mi->mm_height = height_mm; >> >> #if GTK_CHECK_VERSION (3, 22, 0) >> - mi->name = xstrdup (gdk_monitor_get_model (monitor)); >> + mi->name = g_strdup (gdk_monitor_get_model (monitor)); >> #elif GTK_CHECK_VERSION (2, 14, 0) >> mi->name = gdk_screen_get_monitor_plug_name (gscreen, i); >> #endif >> >> I don't know enough about GTK to know why this fixes it or why no one else has >> reported the problem. It's hard to see why this would be specific to Cygwin. > > We release storage of mi->name (in free_monitors) by calling xfree, so > I'm surprised g_strdup is right here, as that is documented to need > g_free instead. I wonder what am I missing. I think the missing clue is in bug#35259: gdk_monitor_get_model may return NULL, which g_strdup gladly accepts, but xstrdup does not. https://debbugs.gnu.org/35259 -- Basil